[jboss-as7-dev] ACTION REQUIRED: Replace hardcoded URLs and adresses with arquillian resources.

Kabir Khan kabir.khan at jboss.com
Fri Feb 10 05:06:23 EST 2012


Where do we set up what gets injected for

@ArquillianResource
URL baseUrl;

On 10 Feb 2012, at 06:57, Rostislav Svoboda wrote:

> Hi Ondra.
> 
> I fixed all WS tests in AS7 TS 3 months ago (https://github.com/rsvoboda/jboss-as/commit/1e3ab6e8125d5b53f1ac06ed94f66f80644a6c56).
> Since that time all new WS tests are using @ArquillianResource annotation.
> 
> Cheers.
> Rosta
> 
> ----- Original Message -----
>> Hi,
>> 
>> 
>> I'd like to ask everyone to fix "their" tests regarding $SUBJ.
>> E.g. this is not acceptable:
>> ModelControllerClient client =
>> ModelControllerClient.Factory.create(InetAddress.getByName("127.0.0.1"),
>> 9999, getCallbackHandler());
>> or
>> MBeanServerConnection mbeanServer = JMXConnectorFactory.connect(new
>> JMXServiceURL("service:jmx:remoting-jmx://127.0.0.1:9999")).getMBeanServerConnection();
>> 
>> Such like these MUST be rewritten to fetch the addresses and ports
>> from an injected @ArquillianResource.
>> 
>> Here's a tracking jira: https://issues.jboss.org/browse/AS7-3696
>> Empty so far. Next week, I'll start going through the tests looking
>> for such cases, and fixing them. Or, creating jiras and assigning
>> them to the test authors.
>> That's why I hope this call to action will relieve me from most of
>> that tedious work :)
>> 
>> 
>> Thanks for cooperation.
>> Ondra
>> 
>> 
>> 
>> 
>> 
>> 
>> 
> _______________________________________________
> jboss-as7-dev mailing list
> jboss-as7-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev




More information about the jboss-as7-dev mailing list