[jboss-as7-dev] Question about recently resolved branding issue
Brian Stansberry
brian.stansberry at redhat.com
Wed Jan 11 11:29:29 EST 2012
On 1/11/12 10:12 AM, Max Rydahl Andersen wrote:
>> I cannot speak for 1), because it covers too many areas which I have not been involved with.
>
> okey … I hope someone else can then :)
>
https://github.com/jbossas/jboss-as/commit/e4a6c58306e27be51734776c9634f392b9c97b60#diff-21
^^^ is to the commit that implements this, showing the class that's at
the heart of it. The class is pretty self-explanatory. The "consoleSlot"
is used to determine what "slot" (implemented as a directory under
modules/org/jboss/as/console) holds the console implementation to use.
(I won't explain further since my knowledge of the details of this is
entirely derived from reading the above class.)
>> But 2) can probably be retrieved through the HTTP API:
>>
>>
>> :read-attribute(name=<product-name|product-version>)
>
> That is too late since we need to identify this on disk, before the server is started
>
Can tools implement the same algorithm?
> /max
>
>>
>>
>> It's currently not set on master, but I would expect it to be there on a final build.
>>
Jason can correct me, but I don't think so. AIUI these two attributes
will be undefined on a community build since a community build is not a
product.
:read-attribute(name=<release-name|release-version>)
provides the community info.
>> On Jan 11, 2012, at 4:24 PM, Max Rydahl Andersen wrote:
>>
>>> 1) how was this in the end implemented ? Something need to change at startup?
>>>
>>> 2) can we use this branding content to somehow identify the server (type/name)
>>
>> --
>>
>> Heiko Braun
>> Senior Software Engineer
>> JBoss by Red Hat
>> http://about.me/hbraun
>>
>>
>>
>>
>>
>>
>>
>> Begin forwarded message:
>>
>>> From: Max Rydahl Andersen<max.andersen at redhat.com>
>>> Subject: Re: [jboss-as7-dev] Question about recently resolved branding issue
>>> Date: January 11, 2012 4:24:17 PM GMT+01:00
>>> To: Heiko Braun<hbraun at redhat.com>
>>> Cc: "jboss-as7-dev at lists.jboss.org Development"<jboss-as7-dev at lists.jboss.org>
>>>
>>>> I've been involved with branding in the past, but you need to be more specific in order to help.
>>>> What exactly are you looking for?
>>>
>>> As discussed on the jira (https://issues.jboss.org/browse/AS7-1807 now that jira is up)
>>> I was concerned about the suggestion that stated the startup scripts had to state the used branding.
>>> If that is the case then that creates a challenge for every tool/script that does not use the startup scripts.
>>>
>>> And furthermore depending on how this branding is implemented this could be used to
>>> identify what server we are actually installing from disk. (i.e. SOA-P vs EAP etc. since I assume/hope that SOA-P main jar will still
>>> be the same as EAP thus it will say EAP not SOA-P so something else is needed to separate these).
>>>
>>> 1) how was this in the end implemented ? Something need to change at startup?
>>>
>>> 2) can we use this branding content to somehow identify the server (type/name)
>>>
>>> /max
>>>
>>>>
>>>> /Ike
>>>>
>>>> On Jan 11, 2012, at 3:44 PM, Max Rydahl Andersen wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Jira (some number I can't find right now since jira is down) about supporting branding of AS7 for EAP6, SOA-P 6 etc. got resolved with no comments/info
>>>>> on *how* it was solved and how tools, JON, etc. is to react/use this.
>>>>>
>>>>> Could anyone spill the beans on that ?
>>>>>
>>>>> /max
>>>>> http://about.me/maxandersen
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> jboss-as7-dev mailing list
>>>>> jboss-as7-dev at lists.jboss.org
>>>>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>>>>
>>>> --
>>>>
>>>> Heiko Braun
>>>> Senior Software Engineer
>>>> JBoss by Red Hat
>>>> http://about.me/hbraun
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>> /max
>>> http://about.me/maxandersen
>>>
>>>
>>>
>>
>>
>> Begin forwarded message:
>>
>>> From: Max Rydahl Andersen<max.andersen at redhat.com>
>>> Subject: Re: [jboss-as7-dev] Question about recently resolved branding issue
>>> Date: January 11, 2012 4:24:17 PM GMT+01:00
>>> To: Heiko Braun<hbraun at redhat.com>
>>> Cc: "jboss-as7-dev at lists.jboss.org Development"<jboss-as7-dev at lists.jboss.org>
>>>
>>>> I've been involved with branding in the past, but you need to be more specific in order to help.
>>>> What exactly are you looking for?
>>>
>>> As discussed on the jira (https://issues.jboss.org/browse/AS7-1807 now that jira is up)
>>> I was concerned about the suggestion that stated the startup scripts had to state the used branding.
>>> If that is the case then that creates a challenge for every tool/script that does not use the startup scripts.
>>>
>>> And furthermore depending on how this branding is implemented this could be used to
>>> identify what server we are actually installing from disk. (i.e. SOA-P vs EAP etc. since I assume/hope that SOA-P main jar will still
>>> be the same as EAP thus it will say EAP not SOA-P so something else is needed to separate these).
>>>
>>> 1) how was this in the end implemented ? Something need to change at startup?
>>>
>>> 2) can we use this branding content to somehow identify the server (type/name)
>>>
>>> /max
>>>
>>>>
>>>> /Ike
>>>>
>>>> On Jan 11, 2012, at 3:44 PM, Max Rydahl Andersen wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Jira (some number I can't find right now since jira is down) about supporting branding of AS7 for EAP6, SOA-P 6 etc. got resolved with no comments/info
>>>>> on *how* it was solved and how tools, JON, etc. is to react/use this.
>>>>>
>>>>> Could anyone spill the beans on that ?
>>>>>
>>>>> /max
>>>>> http://about.me/maxandersen
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> jboss-as7-dev mailing list
>>>>> jboss-as7-dev at lists.jboss.org
>>>>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>>>>
>>>> --
>>>>
>>>> Heiko Braun
>>>> Senior Software Engineer
>>>> JBoss by Red Hat
>>>> http://about.me/hbraun
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>> /max
>>> http://about.me/maxandersen
>>>
>>>
>>>
>>
>>
>> Begin forwarded message:
>>
>>> From: Max Rydahl Andersen<max.andersen at redhat.com>
>>> Subject: Re: [jboss-as7-dev] Question about recently resolved branding issue
>>> Date: January 11, 2012 4:24:17 PM GMT+01:00
>>> To: Heiko Braun<hbraun at redhat.com>
>>> Cc: "jboss-as7-dev at lists.jboss.org Development"<jboss-as7-dev at lists.jboss.org>
>>>
>>>> I've been involved with branding in the past, but you need to be more specific in order to help.
>>>> What exactly are you looking for?
>>>
>>> As discussed on the jira (https://issues.jboss.org/browse/AS7-1807 now that jira is up)
>>> I was concerned about the suggestion that stated the startup scripts had to state the used branding.
>>> If that is the case then that creates a challenge for every tool/script that does not use the startup scripts.
>>>
>>> And furthermore depending on how this branding is implemented this could be used to
>>> identify what server we are actually installing from disk. (i.e. SOA-P vs EAP etc. since I assume/hope that SOA-P main jar will still
>>> be the same as EAP thus it will say EAP not SOA-P so something else is needed to separate these).
>>>
>>> 1) how was this in the end implemented ? Something need to change at startup?
>>>
>>> 2) can we use this branding content to somehow identify the server (type/name)
>>>
>>> /max
>>>
>>>>
>>>> /Ike
>>>>
>>>> On Jan 11, 2012, at 3:44 PM, Max Rydahl Andersen wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Jira (some number I can't find right now since jira is down) about supporting branding of AS7 for EAP6, SOA-P 6 etc. got resolved with no comments/info
>>>>> on *how* it was solved and how tools, JON, etc. is to react/use this.
>>>>>
>>>>> Could anyone spill the beans on that ?
>>>>>
>>>>> /max
>>>>> http://about.me/maxandersen
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> jboss-as7-dev mailing list
>>>>> jboss-as7-dev at lists.jboss.org
>>>>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>>>>
>>>> --
>>>>
>>>> Heiko Braun
>>>> Senior Software Engineer
>>>> JBoss by Red Hat
>>>> http://about.me/hbraun
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>> /max
>>> http://about.me/maxandersen
>>>
>>>
>>>
>
> /max
> http://about.me/maxandersen
>
>
>
>
> _______________________________________________
> jboss-as7-dev mailing list
> jboss-as7-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
--
Brian Stansberry
Principal Software Engineer
JBoss by Red Hat
More information about the jboss-as7-dev
mailing list