[jboss-as7-dev] cli terminal changes

[Darran Lofthouse]

On 05/07/2012 02:57 PM, "Ståle W. Pedersen" wrote:
> hi, im the one to blame for jreadline. currently you can runtime
> disable/enable history (Setting().getInstance().setHistoryDisabled(..).
> however it will only read the history file once and that is during init.
>
> masking works as with jline afaik, but setting the mask char to "" will
> cause jreadline to insert a space instead.

Would be good if we could change that to not output any spaces so there 
is no indication of length - this is something that was previously 
requested.

> these are the commits so far for replacing jline with jreadline if you
> want to test it out yourself:
> https://github.com/stalep/jboss-as/compare/cli_jreadline

Provided this is post 7.1.2 I don't mind if the changes go in, I will 
start to test it and report issues as I find them if there is anything 
not operating as it should.

> - let me know if there are any issues and ill take a look.
>
> ståle
>
> On 05/07/2012 12:16 PM, Darran Lofthouse wrote:
>> Hi Alexey,
>>
>> No concerns about the actual change but just in case anyone asks for it
>> please do not get a pull request into AS 7.1.2.
>>
>> Before this makes it into an actual release I would like to take some
>> time myself to verify the security integrations as those used some
>> specific features such as not echoing passwords and suspending history
>> capture.
>>
>> Regards,
>> Darran Lofthouse.
>>
>>
>> On 05/07/2012 07:18 AM, Alexey Loubyansky wrote:
>>> I'd like to let everybody know that thanks to Stale's efforts we are
>>> switching from jline to Stale's jreadline project as the base
>>> console/terminal for the CLI.
>>>
>>> jline has a number of bugs that we can't do anything about. jreadline
>>> has fixed those and Stale is happy to continue improving things.
>>>
>>> Of course, a few changes will come along with the switch. They are
>>>
>>> - the ordering of columns are different compared to jline, jreadline
>>> does it similar to bash;
>>> - tab-completion is more like bash, i.e. if there are 'file' and
>>> 'file2', completing 'f' will result in 'file' w/o showing 'file2'
>>> candidate (like jline would do) unless the tab key is pressed after 'file';
>>> - there are no more files that are read to enable key bindings. By
>>> default emacs-mode is enabled, but vi-mode is also supported. jreadline
>>> has more keybindings compared to jline and also follows what's default
>>> in bash;
>>> - atm reading the ~/.inputrc is not enabled, but we could enable if
>>> necessary. If people have defined vi-mode, it will catch it and enable
>>> vi-mode by default;
>>> - undo and redo is another new feature afaik.
>>>
>>> In the future it will also be possible to customize different bindings
>>> to different actions in that file, but its not supported now.
>>>
>>> Here are a couple of major issues that'll be fixed with the switch:
>>> - to be able to navigate and edit commands that spread across multiple
>>> lines (AS7-2615 Backspace doesn't work over linebreaks);
>>> - AS7-2436 clear screen doesn't work on windows 7.
>>>
>>>
>>> The pull request hasn't been sent yet. It's just a warning that this is
>>> coming.
>>>
>>> Please, let us know if you have any concerns about this.
>>>
>>> Thanks,
>>> Alexey
>>> _______________________________________________
>>> jboss-as7-dev mailing list
>>> jboss-as7-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>> _______________________________________________
>> jboss-as7-dev mailing list
>> jboss-as7-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>
>