[jboss-as7-dev] Revisit server dependency on embedded
Thomas Diesler
thomas.diesler at jboss.com
Wed Nov 21 11:46:05 EST 2012
Folks,
while working on a minimal modular server I noticed a questionable
dependency from server to embedded. Server only uses types from embedded
in EmbeddedStandAloneServerFactory, which should live in embedded. Other
than that there are no embedded usages in server. Embedded uses
convoluted refection code to access types in server because it does not
have a dependency on it. IMHO, the dependency direction should be the
other way around and EmbeddedStandAloneServerFactory should move to
embedded.
Reversing the order of dependency reduces the transitive graph of binary
dependencies for a minimal server from 739 to 188 and the download size
by 78% to 18MB
The pull request is: #3425 <https://github.com/jbossas/jboss-as/pull/3425>
cheers
--thomas
--
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jboss-as7-dev/attachments/20121121/3658fde0/attachment.html
More information about the jboss-as7-dev
mailing list