[jboss-as7-dev] Netty upgrade for AS7

[David M. Lloyd]

This is not the first time a group ID has changed.  What you have to do is:

1. Examine dependency:tree and add exclusions to every project pulling 
in Netty in the main POM (this should already have been done, since 
*every* artifact should have all its transitives excluded, but people 
are getting lazy about this).  You may have to run dependency:tree 
several times to find them all.
2. Add an enforcer rule to ban the old coordinates.
3. Replace the old dependency with the new one in all modules that 
require Netty directly or transitively.
4. Test!

On 10/05/2012 09:20 AM, Jeff Mesnil wrote:
> Hi guys,
>
> This is of interest for infinispan, web & messaging subsystem and the test suite.
>
> As a part of upgrading HornetQ to 2.3.O.BETA1 in AS7[1], we also need to upgrade its dependency to Netty 3.4.5.Final[2].
> Inside AS7, the Web subsystem also depends on Netty. Guys, is it ok for you to upgrade to 3.4.5?
>
> Unfortunately, to move from Netty 3.2.x to Netty 3.4.x, we must also change its groupId from org.jboss.netty to io.netty.
>
> If I do that, I can no longer build AS7 test suite because of bad dependencies which requires Netty 3.2.x:
>
> +-org.jboss.as:jboss-as-testsuite:7.2.0.Alpha1-SNAPSHOT
>     +-org.jboss.as:jboss-as-build:7.2.0.Alpha1-SNAPSHOT
>       +-org.jboss.as:jboss-as-core-model-test:7.2.0.Alpha1-SNAPSHOT
>         +-org.jboss.as:jboss-as-model-test:7.2.0.Alpha1-SNAPSHOT
>           +-org.sonatype.aether:aether-connector-asynchttpclient:1.13.1
>             +-com.ning:async-http-client:1.6.5
>               +-org.jboss.netty:netty:3.2.5.Final
> and
> +-org.jboss.as:jboss-as-testsuite:7.2.0.Alpha1-SNAPSHOT
>     +-org.projectodd.stilts:stilts-stomp-client:0.1.26
>       +-org.projectodd.stilts:stilts-stomp-api:0.1.26
>         +-org.jboss.netty:netty:3.2.1.Final
>
> Since only the test suite depends on Netty 3.2.x, in my PR, I have 2 versions of Netty:
> * io.netty Netty 3.4.5.Final => used by AS7 codebase
> * org.jboss.netty Netty 3.2.x => used by AS7 test suite
>
> This is ugly but this works...
> However, I'd like to reconcile these 2 versions and upgrade everything to 3.4.5.Final
>
> I have submitted patches for Stilts[3] and Aether connector[4] to upgrade their dependencies to Netty 3.4.x (groupId=io.netty).
> Until they release new versions of their components, we are stuck with Netty 3.2.x.
>
> Another question is about the recent upgrade to Infinispan 5.2.0.BETA1[5]. When I look at this version's POM[6], it depends on
> Netty 3.4.6.Final. Shouldn't have Netty been updated at the same time than Infinispan?
> If that's not required to upgrade a component dependencies when the component is upgraded, I could postpone Netty 3.4.x upgrade.
> However some HornetQ bugs requires this version (e.g. for WebSockets support[7]). I really want to keep the AS7 dependencies in
> sync with the deps of HornetQ that is integrated.
>
> wdyt?
>
> jeff
>
>
> [1] https://issues.jboss.org/browse/AS7-5683
> [2] https://issues.jboss.org/browse/AS7-5402
> [3] https://github.com/projectodd/stilts/pull/8
> [4] https://bugs.eclipse.org/bugs/show_bug.cgi?id=391233
> [5] https://github.com/jbossas/jboss-as/commit/7107c3abcd6220f71380b3602398edaa2978a472#diff-19
> [6] https://github.com/infinispan/infinispan/blob/5.2.0.Beta1/parent/pom.xml#L141
> [7] https://issues.jboss.org/browse/HORNETQ-819
>


-- 
- DML