[jboss-as7-dev] Using Guava in a subsystem
James R. Perkins
jperkins at redhat.com
Mon Apr 22 18:33:40 EDT 2013
I just scanned for imports of com.google and didn't find any. I don't
necessarily object to Guava in general, just any general purpose
dependency like Guava that no subsystems currently depend on.
On 04/22/2013 02:45 PM, Brian Stansberry wrote:
> Unless the module.xml for org.jboss.as.weld:main was wrong, this is not
> a new dependency. I see guava listed as a dependency at least as far
> back as 7.1.2.Final.
>
> So even if there was a great argument for keeping it out, it's too late
> now. :)
>
> On 4/22/13 4:24 PM, Jozef Hartinger wrote:
>> Hi all,
>>
>> during a pull request[1] review James brought to my attention that a
>> change I was about to make to the Weld subsystem would introduce a
>> dependency on Guava. Since I consider Guava to be a useful library it
>> surprised me to find out that it is not used anywhere in the JBoss AS /
>> WildFly codebase. Is this intentional or did just nobody happen to use
>> it in the codebase before?
>>
>> Guava itself is used a lot in Weld core. Therefore, using Guava in a
>> subsystem does not have any implications on the size of the JBoss AS /
>> WildFly build as Guava needs to be bundled anyway. Still, if there are
>> any guidelines or conventions on which libraries to use / avoid, please
>> point me to them. Even better, if there is an alternative to Guava's
>> LoadingCache I could use within JBoss AS / WildFly codebase please let
>> me know.
>>
>> Thanks,
>>
>> Jozef
>>
>> [1] https://github.com/jbossas/jboss-as/pull/4417
>> _______________________________________________
>> jboss-as7-dev mailing list
>> jboss-as7-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>>
>
--
James R. Perkins
JBoss by Red Hat
More information about the jboss-as7-dev
mailing list