[Jboss-cvs] JBossAS SVN: r55347 - in branches/MC_VDF_WORK/system-jmx/src: main/org/jboss/system/metadata main/org/jboss/system/microcontainer tests/org/jboss/test/system/controller/legacy

[jboss-cvs-commits at lists.jboss.org]

Author: adrian at jboss.org
Date: 2006-08-05 12:31:20 -0400 (Sat, 05 Aug 2006)
New Revision: 55347

Modified:
   branches/MC_VDF_WORK/system-jmx/src/main/org/jboss/system/metadata/ServiceDependencyMetaData.java
   branches/MC_VDF_WORK/system-jmx/src/main/org/jboss/system/metadata/ServiceMetaDataParser.java
   branches/MC_VDF_WORK/system-jmx/src/main/org/jboss/system/microcontainer/ServiceControllerContext.java
   branches/MC_VDF_WORK/system-jmx/src/main/org/jboss/system/microcontainer/ServiceProxy.java
   branches/MC_VDF_WORK/system-jmx/src/tests/org/jboss/test/system/controller/legacy/OldServiceConfigurator.java
   branches/MC_VDF_WORK/system-jmx/src/tests/org/jboss/test/system/controller/legacy/OldServiceCreator.java
Log:
Just some sourcecode tidyup

Modified: branches/MC_VDF_WORK/system-jmx/src/main/org/jboss/system/metadata/ServiceDependencyMetaData.java
===================================================================
--- branches/MC_VDF_WORK/system-jmx/src/main/org/jboss/system/metadata/ServiceDependencyMetaData.java	2006-08-05 16:24:44 UTC (rev 55346)
+++ branches/MC_VDF_WORK/system-jmx/src/main/org/jboss/system/metadata/ServiceDependencyMetaData.java	2006-08-05 16:31:20 UTC (rev 55347)
@@ -47,7 +47,7 @@
    /**
     * Set the iDependOn.
     * 
-    * @param dependOn the iDependOn.
+    * @param iDependOn the iDependOn.
     */
    public void setIDependOn(ObjectName iDependOn)
    {

Modified: branches/MC_VDF_WORK/system-jmx/src/main/org/jboss/system/metadata/ServiceMetaDataParser.java
===================================================================
--- branches/MC_VDF_WORK/system-jmx/src/main/org/jboss/system/metadata/ServiceMetaDataParser.java	2006-08-05 16:24:44 UTC (rev 55346)
+++ branches/MC_VDF_WORK/system-jmx/src/main/org/jboss/system/metadata/ServiceMetaDataParser.java	2006-08-05 16:31:20 UTC (rev 55347)
@@ -507,6 +507,8 @@
     * Get an elements text content
     * 
     * @param element the element
+    * @param trim whether to trim
+    * @param replace whetehr to replace properties
     * @return the concatentation of the text nodes
     * @throws Exception for any error
     */

Modified: branches/MC_VDF_WORK/system-jmx/src/main/org/jboss/system/microcontainer/ServiceControllerContext.java
===================================================================
--- branches/MC_VDF_WORK/system-jmx/src/main/org/jboss/system/microcontainer/ServiceControllerContext.java	2006-08-05 16:24:44 UTC (rev 55346)
+++ branches/MC_VDF_WORK/system-jmx/src/main/org/jboss/system/microcontainer/ServiceControllerContext.java	2006-08-05 16:31:20 UTC (rev 55347)
@@ -145,6 +145,7 @@
     * Get the service proxy
     * 
     * @return the service proxy
+    * @throws Exception for any error
     */
    public Service getServiceProxy() throws Exception
    {

Modified: branches/MC_VDF_WORK/system-jmx/src/main/org/jboss/system/microcontainer/ServiceProxy.java
===================================================================
--- branches/MC_VDF_WORK/system-jmx/src/main/org/jboss/system/microcontainer/ServiceProxy.java	2006-08-05 16:24:44 UTC (rev 55346)
+++ branches/MC_VDF_WORK/system-jmx/src/main/org/jboss/system/microcontainer/ServiceProxy.java	2006-08-05 16:31:20 UTC (rev 55347)
@@ -85,6 +85,7 @@
     * @param objectName the object name
     * @param server the mbean server
     * @return The Service value
+    * @throws Exception for any error
     */
    public static Service getServiceProxy(ObjectName objectName, MBeanServer server) throws Exception
    {
@@ -103,8 +104,9 @@
     * the Service interface methods set the corresponding hasOp array value
     * to true.
     *
-    * @param objectName
-    * @param opInfo
+    * @param objectName the object name
+    * @param server the mbean server
+    * @param opInfo the MBean operation info
     */
    public ServiceProxy(ObjectName objectName, MBeanServer server, MBeanOperationInfo[] opInfo)
    {

Modified: branches/MC_VDF_WORK/system-jmx/src/tests/org/jboss/test/system/controller/legacy/OldServiceConfigurator.java
===================================================================
--- branches/MC_VDF_WORK/system-jmx/src/tests/org/jboss/test/system/controller/legacy/OldServiceConfigurator.java	2006-08-05 16:24:44 UTC (rev 55346)
+++ branches/MC_VDF_WORK/system-jmx/src/tests/org/jboss/test/system/controller/legacy/OldServiceConfigurator.java	2006-08-05 16:31:20 UTC (rev 55347)
@@ -146,6 +146,7 @@
     * The mbean configuration can be nested.
     * @param config the xml <code>Element</code> containing the configuration of
     * the mbeans to create and configure.
+    * @param loaderName the class loader
     * @return a <code>List</code> of ObjectNames of created mbeans.
     * @throws DeploymentException if an error occurs
     */
@@ -202,6 +203,9 @@
    /**
     * Builds a string that consists of the configuration elements of the
     * currently running MBeans registered in the server.
+    * 
+    * @param objectNames the object names
+    * @return the xml string
     * @throws Exception Failed to construct configuration.
     * @todo replace with more sophisticated mbean persistence mechanism.
     */
@@ -811,6 +815,8 @@
     * 
     * @param element - the parent dom element whose contents are to be extracted as an xml document string. 
     * @return the xml document string.
+    * @throws IOException for an IO problem
+    * @throws TransformerException for an error during the transformation
     */
    public static StringBuffer getElementContent(Element element) throws IOException, TransformerException
    {

Modified: branches/MC_VDF_WORK/system-jmx/src/tests/org/jboss/test/system/controller/legacy/OldServiceCreator.java
===================================================================
--- branches/MC_VDF_WORK/system-jmx/src/tests/org/jboss/test/system/controller/legacy/OldServiceCreator.java	2006-08-05 16:24:44 UTC (rev 55346)
+++ branches/MC_VDF_WORK/system-jmx/src/tests/org/jboss/test/system/controller/legacy/OldServiceCreator.java	2006-08-05 16:31:20 UTC (rev 55347)
@@ -45,7 +45,7 @@
 /**
  * A helper class for the controller.
  *
- * @see Service
+ * @see org.jboss.system.Service
  *
  * @author <a href="mailto:marc.fleury at jboss.org">Marc Fleury</a>
  * @author <a href="mailto:d_jencks at users.sourceforge.net">David Jencks</a>
@@ -70,6 +70,8 @@
    
    /**
     * CTOR
+    * 
+    * @param server the MBeanServer
     */
    public OldServiceCreator(final MBeanServer server)
    {
@@ -90,11 +92,11 @@
     * Parses the given configuration document and creates MBean
     * instances in the current MBean server.
     *
-    * @param configuration     The configuration document.
-    *
-    * @throws ConfigurationException   The configuration document contains
-    *                                  invalid or missing syntax.
-    * @throws Exception                Failed for some other reason.
+    * @param mbeanName the object name
+    * @param loaderName the classloader
+    * @param mbeanElement the config
+    * @return the created object instance
+    * @throws Exception for any error
     */
    public ObjectInstance install(ObjectName mbeanName, ObjectName loaderName,
       Element mbeanElement) throws Exception