Wed Dec 6 09:59:11 EST 2006

Author: adrian at jboss.org
Date: 2006-12-06 09:58:47 -0500 (Wed, 06 Dec 2006)
New Revision: 58864

Modified:
   projects/microcontainer/trunk/container/src/main/org/jboss/annotation/factory/javassist/ProxyMapCreator.java
   projects/microcontainer/trunk/container/src/main/org/jboss/beans/info/plugins/AbstractBeanInfoFactory.java
   projects/microcontainer/trunk/container/src/main/org/jboss/classadapter/spi/ClassAdapter.java
   projects/microcontainer/trunk/container/src/main/org/jboss/metadata/plugins/context/CachingMetaDataContext.java
   projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/AnnotationValueFactory.java
   projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/ArrayValueImpl.java
   projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/ClassInfoImpl.java
   projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/ValueConvertor.java
   projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/javassist/JavassistReflectionFactory.java
   projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/javassist/JavassistTypeInfo.java
   projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/javassist/JavassistTypeInfoFactoryImpl.java
   projects/microcontainer/trunk/container/src/main/org/jboss/reflect/spi/PrimitiveInfo.java
   projects/microcontainer/trunk/container/src/main/org/jboss/repository/plugins/AbstractKernelRepository.java
   projects/microcontainer/trunk/container/src/main/org/jboss/repository/plugins/InvocationMetaDataCombiner.java
   projects/microcontainer/trunk/container/src/main/org/jboss/util/collection/temp/WeakTypeCache.java
   projects/microcontainer/trunk/container/src/main/org/jboss/virtual/classloading/VFSClassLoader.java
   projects/microcontainer/trunk/container/src/main/org/jboss/virtual/plugins/context/file/LinkHandler.java
   projects/microcontainer/trunk/container/src/main/org/jboss/virtual/plugins/context/jar/NoCopyNestedJarHandler.java
   projects/microcontainer/trunk/container/src/tests/org/jboss/test/beaninfo/test/AbstractBeanInfoTest.java
   projects/microcontainer/trunk/container/src/tests/org/jboss/test/classinfo/support/AnnotatedSubClass.java
   projects/microcontainer/trunk/container/src/tests/org/jboss/test/classinfo/test/AbstractClassInfoTest.java
   projects/microcontainer/trunk/container/src/tests/org/jboss/test/classinfo/test/JavassistArrayUnitTestCase.java
Log:
Update the non-VFS TODOs to include a reference to the JIRA issue.

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/annotation/factory/javassist/ProxyMapCreator.java
===================================================================

--- projects/microcontainer/trunk/container/src/main/org/jboss/annotation/factory/javassist/ProxyMapCreator.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/annotation/factory/javassist/ProxyMapCreator.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -230,7 +230,7 @@
 
    public static Map<String, Object> createProxyMap(Class annotation, javassist.bytecode.annotation.Annotation info)
    {
-      //TODO: Need to handle default values for annotations in jdk 1.5
+      // TODO JBMICROCONT-126 Need to handle default values for annotations in jdk 1.5
       Map<String, Object> map = new HashMap<String, Object>();
 
       if (info.getMemberNames() == null) return map;

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/beans/info/plugins/AbstractBeanInfoFactory.java
===================================================================
--- projects/microcontainer/trunk/container/src/main/org/jboss/beans/info/plugins/AbstractBeanInfoFactory.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/beans/info/plugins/AbstractBeanInfoFactory.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -298,7 +298,7 @@
             Map.Entry<String, List<MethodInfo>> entry = i.next();
             String name = entry.getKey();
             List<MethodInfo> setterList = entry.getValue();
-            // Review: Maybe should just create duplicate propertyInfo and let the configurator guess?
+            // TODO JBMICROCONT-125 Maybe should just create duplicate propertyInfo and let the configurator guess?
             if (setterList.size() == 1)
             {
                MethodInfo setter = setterList.get(0);

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/classadapter/spi/ClassAdapter.java
===================================================================
--- projects/microcontainer/trunk/container/src/main/org/jboss/classadapter/spi/ClassAdapter.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/classadapter/spi/ClassAdapter.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -48,14 +48,6 @@
  * <li> Obtain the JoinpointFactory so the instance can be
  *       constructed.
  * </ol>
- *
- * FIXME: This class deals with too many concerns
- * FIXME: Need a mechanism to allow different use cases
- *              for the unadvised case.
- *              i.e. whether in the absence of aop requirements 
- *              the adapter should give a proxy advisor,
- *              instrument the class for aop anyway
- *              or default back to reflection (most likely!)
  * 
  * @author <a href="mailto:adrian at jboss.org">Adrian Brock</a>
  */

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/metadata/plugins/context/CachingMetaDataContext.java
===================================================================
--- projects/microcontainer/trunk/container/src/main/org/jboss/metadata/plugins/context/CachingMetaDataContext.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/metadata/plugins/context/CachingMetaDataContext.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -37,7 +37,7 @@
 /**
  * CachingMetaDataContext.
  * 
- * @TODO LRU Cache
+ * TODO JBMICROCONT-120 LRU Cache
  * @author <a href="adrian at jboss.com">Adrian Brock</a>
  * @version $Revision$
  */

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/AnnotationValueFactory.java
===================================================================
--- projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/AnnotationValueFactory.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/AnnotationValueFactory.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -77,7 +77,8 @@
       }
       else if (type instanceof ClassInfo)
       {
-         rtnValue = new ClassValueImpl(((Class)value).getName(), type); //FixMe - do not depend on Class
+         // TODO JBMICROCONT-118 do not depend on Class
+         rtnValue = new ClassValueImpl(((Class)value).getName(), type);
       }
       
       return rtnValue;

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/ArrayValueImpl.java
===================================================================
--- projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/ArrayValueImpl.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/ArrayValueImpl.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -103,7 +103,6 @@
     */
    protected void calculateHash()
    {
-      // FIXME java5 hash = Arrays.hashCode(values);
-      hash = hash * 29 +  type.hashCode();
+      hash = Arrays.hashCode(values);
    }
 }

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/ClassInfoImpl.java
===================================================================
--- projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/ClassInfoImpl.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/ClassInfoImpl.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -38,7 +38,7 @@
 /**
  * Class info
  *
- * @todo fix the introspection assumption
+ * TODO JBMICROCONT-118 fix the introspection assumption
  * @author <a href="mailto:bill at jboss.org">Bill Burke</a>
  * @author <a href="mailto:adrian at jboss.org">Adrian Brock</a>
  */
@@ -171,7 +171,7 @@
    /**
     * Get an array class
     * 
-    * @todo there must be a better way to do this!
+    * TODO JBMICROCONT-123 there must be a better way to do this!
     * @param clazz the class
     * @param depth the depth
     * @return the array class

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/ValueConvertor.java
===================================================================
--- projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/ValueConvertor.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/ValueConvertor.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -34,7 +34,7 @@
 /**
  * PropertyEditorHelper.
  *
- * @todo fix the introspection assumption
+ * TODO JBMICROCONT-118 fix the introspection assumption
  * @author <a href="adrian at jboss.com">Adrian Brock</a>
  * @version $Revision$
  */
@@ -58,7 +58,7 @@
    /**
     * Convert a value
     * 
-    * @todo look at integer progression, e.g. Integer.longValue()
+    * TODO JBMICROCONT-119 look at integer progression, e.g. Integer.longValue()
     * @param clazz the class
     * @param value the value
     * @return the value or null if there is no editor
@@ -108,7 +108,7 @@
       }
       
 
-      // TODO improve <init>(String) might not be relevent?
+      // TODO JBMICROCONT-132 improve <init>(String) might not be relevent?
       if (valueClass == String.class)
       {
          try

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/javassist/JavassistReflectionFactory.java
===================================================================
--- projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/javassist/JavassistReflectionFactory.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/javassist/JavassistReflectionFactory.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -42,8 +42,8 @@
 /**
  * JavassistReflectionFactory.
  * 
- * @todo proper classpool with pruning
- * @todo non compiler based implementation
+ * TODO JBMICROCONT-122 proper classpool with pruning
+ * TODO JBMICROCONT-121 non compiler based implementation
  * @author <a href="adrian at jboss.com">Adrian Brock</a>
  * @version $Revision$
  */
@@ -604,7 +604,7 @@
    /**
     * Get the boxed type
     * 
-    * @todo integer progression?
+    * TODO JBMICROCONT-119 integer progression?
     * @param type the type to box
     * @return the boxed type name
     */

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/javassist/JavassistTypeInfo.java
===================================================================
--- projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/javassist/JavassistTypeInfo.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/javassist/JavassistTypeInfo.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -158,7 +158,7 @@
 
    public ClassInfo getGenericSuperclass()
    {
-      // TODO getGenericSuperclass
+      // TODO JBMICROCONT-129 getGenericSuperclass
       throw new org.jboss.util.NotImplementedException("getGenericSuperclass");
    }
 
@@ -182,7 +182,7 @@
 
    public InterfaceInfo[] getGenericInterfaces()
    {
-      // TODO getGenericInterfaces
+      // TODO JBMICROCONT-129 getGenericInterfaces
       throw new org.jboss.util.NotImplementedException("getGenericInterfaces");
    }
 
@@ -318,7 +318,7 @@
    /**
     * Get an array class
     * 
-    * @todo there must be a better way to do this!
+    * TODO JBMICROCONT-123 there must be a better way to do this!
     * @param clazz the class
     * @param depth the depth
     * @return the array class

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/javassist/JavassistTypeInfoFactoryImpl.java
===================================================================
--- projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/javassist/JavassistTypeInfoFactoryImpl.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/reflect/plugins/javassist/JavassistTypeInfoFactoryImpl.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -279,7 +279,7 @@
       if (type instanceof Class)
          return getTypeInfo((Class) type);
 
-      // TODO getTypeInfo
+      // TODO JBMICROCONT-129 getTypeInfo
       throw new org.jboss.util.NotImplementedException("getTypeInfo");
    }
 

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/reflect/spi/PrimitiveInfo.java
===================================================================
--- projects/microcontainer/trunk/container/src/main/org/jboss/reflect/spi/PrimitiveInfo.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/reflect/spi/PrimitiveInfo.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -32,7 +32,7 @@
 /**
  * Primitive info
  *
- * @todo fix the introspection assumption
+ * TODO JBMICROCONT-118 fix the introspection assumption
  * @author <a href="mailto:bill at jboss.org">Bill Burke</a>
  * @author <a href="mailto:adrian at jboss.org">Adrian Brock</a>
  */

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/repository/plugins/AbstractKernelRepository.java
===================================================================
--- projects/microcontainer/trunk/container/src/main/org/jboss/repository/plugins/AbstractKernelRepository.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/repository/plugins/AbstractKernelRepository.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -33,7 +33,6 @@
 import org.jboss.repository.spi.CommonNames;
 
 /**
- @todo update for synchronization and concurrent reader maps
 
  @author Scott.Stark at jboss.org
  @version $Revision$
@@ -72,8 +71,6 @@
    }
 
    /**
-    @todo should the loader be used to attempt to load data if the requested
-      name does not currently exist?
 
     @param key
     @param combiner
@@ -159,7 +156,6 @@
    }
 
    /**
-    @todo Not implemented.
     @param nameRE
     @param attributes
     @return null currently

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/repository/plugins/InvocationMetaDataCombiner.java
===================================================================
--- projects/microcontainer/trunk/container/src/main/org/jboss/repository/plugins/InvocationMetaDataCombiner.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/repository/plugins/InvocationMetaDataCombiner.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -56,7 +56,7 @@
 
    public Object combine(Key key, MetaData[] levelData)
    {
-      Object value = null; // @todo Some function of context
+      Object value = null;
       if( value != null )
          return value;
       value = next.combine(key, levelData);

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/util/collection/temp/WeakTypeCache.java
===================================================================
--- projects/microcontainer/trunk/container/src/main/org/jboss/util/collection/temp/WeakTypeCache.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/util/collection/temp/WeakTypeCache.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -153,7 +153,7 @@
     */
    private T getTypeVariable(TypeVariable type)
    {
-      // TODO improve this
+      // TODO JBMICROCONT-131 improve this
       return get(type.getBounds()[0]);
    }
 
@@ -165,7 +165,7 @@
     */
    private T getGenericArrayType(GenericArrayType type)
    {
-      // TODO this needs implementing properly
+      // TODO JBMICROCONT-131 this needs implementing properly
       return get(Object[].class);
    }
 
@@ -199,7 +199,7 @@
 
       synchronized (classLoaderCache)
       {
-         // TODO something better than toString()?
+         // TODO JBMICROCONT-131 something better than toString()?
          classLoaderCache.put(type.toString(), result);
       }
    }

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/virtual/classloading/VFSClassLoader.java
===================================================================
--- projects/microcontainer/trunk/container/src/main/org/jboss/virtual/classloading/VFSClassLoader.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/virtual/classloading/VFSClassLoader.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -150,7 +150,6 @@
     */
    public String[] getPackageNames()
    {
-      // TODO Auto-generated method stub
       return null;
    }
 

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/virtual/plugins/context/file/LinkHandler.java
===================================================================
--- projects/microcontainer/trunk/container/src/main/org/jboss/virtual/plugins/context/file/LinkHandler.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/virtual/plugins/context/file/LinkHandler.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -83,7 +83,6 @@
 
       public List<VirtualFileHandler> getChildren(boolean ignoreErrors) throws IOException
       {
-         // TODO Auto-generated method stub
          return null;
       }
 

Modified: projects/microcontainer/trunk/container/src/main/org/jboss/virtual/plugins/context/jar/NoCopyNestedJarHandler.java
===================================================================
--- projects/microcontainer/trunk/container/src/main/org/jboss/virtual/plugins/context/jar/NoCopyNestedJarHandler.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/main/org/jboss/virtual/plugins/context/jar/NoCopyNestedJarHandler.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -126,7 +126,6 @@
    @Override
    public List<VirtualFileHandler> getChildren(boolean ignoreErrors) throws IOException
    {
-      // TODO Auto-generated method stub
       return super.getChildren(ignoreErrors);
    }
    

Modified: projects/microcontainer/trunk/container/src/tests/org/jboss/test/beaninfo/test/AbstractBeanInfoTest.java
===================================================================
--- projects/microcontainer/trunk/container/src/tests/org/jboss/test/beaninfo/test/AbstractBeanInfoTest.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/tests/org/jboss/test/beaninfo/test/AbstractBeanInfoTest.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -263,7 +263,7 @@
             Map.Entry<String, List<Method>> entry = i.next();
             String name = entry.getKey();
             List<Method> setterList = entry.getValue();
-            // Review: Maybe should just create duplicate propertyInfo and let the configurator guess?
+            // TODO JBMICROCONT-125 Maybe should just create duplicate propertyInfo and let the configurator guess?
             if (setterList.size() == 1)
             {
                Method setter = setterList.get(0);

Modified: projects/microcontainer/trunk/container/src/tests/org/jboss/test/classinfo/support/AnnotatedSubClass.java
===================================================================
--- projects/microcontainer/trunk/container/src/tests/org/jboss/test/classinfo/support/AnnotatedSubClass.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/tests/org/jboss/test/classinfo/support/AnnotatedSubClass.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -32,7 +32,7 @@
 
    public AnnotatedSubClass(int i, String x)
    {
-      // FIXME AnnotatedSubClass constructor
+      // TODO JBMICROCONT-124 AnnotatedSubClass constructor
       super(i, x);
    }
 

Modified: projects/microcontainer/trunk/container/src/tests/org/jboss/test/classinfo/test/AbstractClassInfoTest.java
===================================================================
--- projects/microcontainer/trunk/container/src/tests/org/jboss/test/classinfo/test/AbstractClassInfoTest.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/tests/org/jboss/test/classinfo/test/AbstractClassInfoTest.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -84,7 +84,7 @@
       getLog().debug("Type: " + info.getType());
       assertEquals(clazz, info.getType());
       
-      // TODO fix the serialization
+      // TODO JBMICROCONT-128 fix the serialization
       //byte[] bytes = serialize(info);
       //Object deserialized = deserialize(bytes);
       //assertEquals(info, deserialized);
@@ -471,7 +471,7 @@
       {
          Class type = annotation.annotationType();
          AnnotationInfoImpl info = new AnnotationInfoImpl(type.getName(), type.getModifiers());
-         // TODO attributes
+         // TODO JBMICROCONT-127 attributes
          AnnotationValue a = new AnnotationValueImpl(info, new HashMap<String, Value>());
          expected.add(a);
       }

Modified: projects/microcontainer/trunk/container/src/tests/org/jboss/test/classinfo/test/JavassistArrayUnitTestCase.java
===================================================================
--- projects/microcontainer/trunk/container/src/tests/org/jboss/test/classinfo/test/JavassistArrayUnitTestCase.java	2006-12-06 14:48:01 UTC (rev 58863)
+++ projects/microcontainer/trunk/container/src/tests/org/jboss/test/classinfo/test/JavassistArrayUnitTestCase.java	2006-12-06 14:58:47 UTC (rev 58864)
@@ -47,12 +47,12 @@
 
    protected void assertInterfaces(Class<?> clazz, ClassInfo classInfo) throws Throwable
    {
-      // TODO this is broken for javassist
+      // TODO JBMICROCONT-130 this is broken for javassist
    }
 
    protected void assertModifiers(Class<?> clazz, ClassInfo classInfo) throws Throwable
    {
-      // TODO this is broken for javassist
+      // TODO JBMICROCONT-130 this is broken for javassist
    }
 
    protected TypeInfoFactory getTypeInfoFactory()


