[jboss-cvs] JBoss Messaging SVN: r1824 - trunk/src/main/org/jboss/jms/client/container

[jboss-cvs-commits at lists.jboss.org]

Author: clebert.suconic at jboss.com
Date: 2006-12-19 11:26:29 -0500 (Tue, 19 Dec 2006)
New Revision: 1824

Modified:
   trunk/src/main/org/jboss/jms/client/container/ValveAspect.java
Log:
no major modifications.. just removing unused comments

Modified: trunk/src/main/org/jboss/jms/client/container/ValveAspect.java
===================================================================
--- trunk/src/main/org/jboss/jms/client/container/ValveAspect.java	2006-12-19 06:51:01 UTC (rev 1823)
+++ trunk/src/main/org/jboss/jms/client/container/ValveAspect.java	2006-12-19 16:26:29 UTC (rev 1824)
@@ -58,8 +58,6 @@
 
    private ClientConnectionDelegate delegate;
 
-   // alternative implementation
-   //private Valve valve = new Valve();
    private ReadWriteLock lockValve;
 
    ValveAspect(ClientConnectionDelegate delegate, HAAspect copy)
@@ -102,18 +100,6 @@
             log.info("Retrying a call " + i);
          }
 
-
-         // An alternate way of playing with Valves is to set an attribute to true
-         // and wait for notifications until it's being set. Valve encpasulates this logic
-         //  if (i > 0)
-         //  {
-         //     valve.open(true);
-         //  }
-         //  else
-         //  {
-         //     valve.isOpened(true);
-         //  }
-
          // We shouldn't have any calls being made while the failover is being executed
          if (i > 0)
          {
@@ -148,12 +134,6 @@
          }
          finally
          {
-            // An alternate way of playing with Valves is to set an attribute to true
-            // and wait for notifications until it's being set. Valve encpasulates this logic
-            //if (i>0)
-            //{
-            //   valve.reset();
-            //}
             if (i > 0)
             {
                lockValve.writeLock().release();
@@ -204,13 +184,6 @@
       // only one execution should be performed if multiple exceptions happened at the same time
       lockValve.writeLock().acquire();
 
-      // An alternate way of playing with Valves is to set an attribute to true
-      // and wait for notifications until it's being set. Valve encpasulates this logic
-//      if (!valve.open())
-//      {
-//         return;
-//      }
-
       try
       {
          if (jmsConnection.isFailed())
@@ -231,10 +204,6 @@
       }
       finally
       {
-         // An alternate way of playing with Valves is to set an attribute to true
-         // and wait for notifications until it's being set. Valve encpasulates this logic
-//         valve.close();
-//         valve = new Valve();
          lockValve.writeLock().release();
       }