[jboss-cvs] jbosside/core/plugins/org.jboss.ide.eclipse.packages.core/src/main/org/jboss/ide/eclipse/packages/core/model/types ...

[Robert Stryker]

  User: rawb    
  Date: 06/12/21 20:08:40

  Modified:    core/plugins/org.jboss.ide.eclipse.packages.core/src/main/org/jboss/ide/eclipse/packages/core/model/types  
                        JARPackageType.java
  Removed:     core/plugins/org.jboss.ide.eclipse.packages.core/src/main/org/jboss/ide/eclipse/packages/core/model/types  
                        AbstractPackageType.java
  Log:
  The Extension Manager had several errors. It used the incorrect method of instantiating a provided class (Class.forName led to class not found errors. configElement.createExecutable("attribute") is the proper method)
  
  It also assumed all provided classes would be of type AbstractPackageType, instead of IPackageType. It then made use of methods not present in IPackageType (setId, setLabel). I've removed all references to AbstractPackageType, the JARPackageType now directly returns its information (jar, JAR), and the extension point data is essentially ignored.
  
  Suck It. 
  
  Revision  Changes    Path
  1.7       +9 -2      jbosside/core/plugins/org.jboss.ide.eclipse.packages.core/src/main/org/jboss/ide/eclipse/packages/core/model/types/JARPackageType.java
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: JARPackageType.java
  ===================================================================
  RCS file: /cvsroot/jboss/jbosside/core/plugins/org.jboss.ide.eclipse.packages.core/src/main/org/jboss/ide/eclipse/packages/core/model/types/JARPackageType.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -b -r1.6 -r1.7
  --- JARPackageType.java	20 Dec 2006 20:43:47 -0000	1.6
  +++ JARPackageType.java	22 Dec 2006 01:08:40 -0000	1.7
  @@ -21,10 +21,9 @@
    * The name of the resulting JAR will be the project's name followed by a ".jar" extension.
    * @author Marshall
    */
  -public class JARPackageType extends AbstractPackageType {
  +public class JARPackageType implements IPackageType {
   
   	public static final String TYPE_ID = "jar";
  -
   	public IPackage createDefaultConfiguration(IProject project, IProgressMonitor monitor)
   	{
   		Assert.isNotNull(project);
  @@ -79,4 +78,12 @@
   		
   		return SUPPORT_NONE;
   	}
  +	
  +	public String getId() {
  +		return "jar";
  +	}
  +
  +	public String getLabel() {
  +		return "JAR";
  +	}
   }