[jboss-cvs] jboss-portal/core/src/main/org/jboss/portal/core/metadata ...

[Julien Viet]

  User: julien  
  Date: 06/07/21 06:02:12

  Modified:    core/src/main/org/jboss/portal/core/metadata 
                        PortalObjectMetaData.java
  Log:
  - simpler default security configuration of portal objects
  
  Revision  Changes    Path
  1.32      +14 -11    jboss-portal/core/src/main/org/jboss/portal/core/metadata/PortalObjectMetaData.java
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: PortalObjectMetaData.java
  ===================================================================
  RCS file: /cvsroot/jboss/jboss-portal/core/src/main/org/jboss/portal/core/metadata/PortalObjectMetaData.java,v
  retrieving revision 1.31
  retrieving revision 1.32
  diff -u -b -r1.31 -r1.32
  --- PortalObjectMetaData.java	24 Jun 2006 04:22:30 -0000	1.31
  +++ PortalObjectMetaData.java	21 Jul 2006 10:02:12 -0000	1.32
  @@ -26,6 +26,7 @@
   import org.jboss.portal.common.util.XML;
   import org.jboss.portal.core.model.portal.PortalObject;
   import org.jboss.portal.core.model.portal.PortalObjectContainer;
  +import org.jboss.portal.core.model.portal.PortalObjectPermission;
   import org.jboss.portal.security.spi.provider.SecurityConfigurationException;
   import org.jboss.portal.security.spi.provider.DomainConfigurator;
   import org.jboss.portal.security.RoleSecurityBinding;
  @@ -42,7 +43,7 @@
   
   /**
    * @author <a href="mailto:julien at jboss.org">Julien Viet</a>
  - * @version $Revision: 1.31 $
  + * @version $Revision: 1.32 $
    */
   public abstract class PortalObjectMetaData implements MetaData
   {
  @@ -137,18 +138,20 @@
   
         // Configure security
         SecurityConstraintsMetaData securityConstraints = getSecurityConstraints();
  -      if (securityConstraints != null)
  +
  +      // Default is view recursive
  +      if (securityConstraints == null)
         {
  +         securityConstraints = new SecurityConstraintsMetaData();
  +         RoleSecurityBinding binding = new RoleSecurityBinding(PortalObjectPermission.VIEW_RECURSIVE_ACTION, SecurityConstants.UNCHECKED_ROLE_NAME);
  +         securityConstraints.getConstraints().add(binding);
  +      }
  +
  +      // Apply the constraint
            PortalObjectContainer poc = buildContext.getContainer();
            DomainConfigurator domainConfigurator = poc.getAuthorizationDomain().getConfigurator();
            domainConfigurator.setBindings(object.getId(), securityConstraints.getConstraints());
         }
  -//      if (securityConstraints == null)
  -//      {
  -//         securityConstraints = new SecurityConstraintsMetaData();
  -//         securityConstraints.getConstraints().add(new RoleSecurityBinding("view", SecurityConstants.UNCHECKED_ROLE_NAME));
  -//      }
  -   }
   
      public static PortalObjectMetaData buildMetaData(Element portalObjectElt) throws Exception
      {