[jboss-cvs] jboss-seam/src/main/org/jboss/seam/jsf ...

Gavin King gavin.king at jboss.com
Fri Nov 3 20:27:43 EST 2006


  User: gavin   
  Date: 06/11/03 20:27:43

  Modified:    src/main/org/jboss/seam/jsf    
                        SeamExtendedManagedPersistencePhaseListener.java
                        SeamExtendedManagedPersistencePortletPhaseListener.java
  Added:       src/main/org/jboss/seam/jsf    
                        TransactionalSeamPhaseListener.java
                        TransactionalSeamPortletPhaseListener.java
  Log:
  JBSEAM-461
  
  Revision  Changes    Path
  1.23      +4 -54     jboss-seam/src/main/org/jboss/seam/jsf/SeamExtendedManagedPersistencePhaseListener.java
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: SeamExtendedManagedPersistencePhaseListener.java
  ===================================================================
  RCS file: /cvsroot/jboss/jboss-seam/src/main/org/jboss/seam/jsf/SeamExtendedManagedPersistencePhaseListener.java,v
  retrieving revision 1.22
  retrieving revision 1.23
  diff -u -b -r1.22 -r1.23
  --- SeamExtendedManagedPersistencePhaseListener.java	27 Sep 2006 03:53:49 -0000	1.22
  +++ SeamExtendedManagedPersistencePhaseListener.java	4 Nov 2006 01:27:43 -0000	1.23
  @@ -1,59 +1,9 @@
  -//$Id: SeamExtendedManagedPersistencePhaseListener.java,v 1.22 2006/09/27 03:53:49 gavin Exp $
   package org.jboss.seam.jsf;
   
  -import javax.faces.event.PhaseEvent;
  -import javax.faces.event.PhaseId;
  -
  -import org.jboss.seam.core.Init;
  -
   /**
  - * Transaction management for extended persistence contexts.
  - * A transaction spans the restore view, apply request values, process validations,
  - * update model values and invoke application phases. It is committed when
  - * invoke application is complete, or renderResponse() or responseComplete() is
  - * called. A second transaction spans the render response phase.
  - * 
  + * @deprecated use TransactionalSeamPhaseListener
    * @author Gavin King
  + *
    */
  -public class SeamExtendedManagedPersistencePhaseListener extends SeamPhaseListener
  -{
  -   
  -   @Override
  -   public void handleTransactionsBeforePhase(PhaseEvent event)
  -   {
  -      PhaseId phaseId = event.getPhaseId();
  -      boolean beginTran = phaseId==PhaseId.RESTORE_VIEW || 
  -            ( phaseId==PhaseId.RENDER_RESPONSE && !Init.instance().isClientSideConversations() );
  -      
  -      if (beginTran) 
  -      {
  -         begin(phaseId);
  -      }
  -   }
  -
  -   @Override
  -   public void handleTransactionsAfterPhase(PhaseEvent event)
  -   {
  -      PhaseId phaseId = event.getPhaseId();
  -      boolean commitTran = phaseId==PhaseId.INVOKE_APPLICATION || 
  -            event.getFacesContext().getRenderResponse() || //TODO: no need to commit the tx if we failed to restore the view
  -            event.getFacesContext().getResponseComplete() ||
  -            ( phaseId==PhaseId.RENDER_RESPONSE && !Init.instance().isClientSideConversations() );
  -      
  -      if (commitTran)
  -      { 
  -         commitOrRollback(phaseId); //we commit before destroying contexts, cos the contexts have the PC in them
  -      }     
  -   }
  -
  -   @Override
  -   protected void handleTransactionsAfterPageActions(PhaseEvent event)
  -   {
  -      commitOrRollback(PhaseId.INVOKE_APPLICATION);
  -      if ( !event.getFacesContext().getResponseComplete() )
  -      {
  -         begin(PhaseId.INVOKE_APPLICATION);
  -      }
  -   }
  -
  -}
  +public class SeamExtendedManagedPersistencePhaseListener extends
  +      TransactionalSeamPhaseListener {}
  
  
  
  1.7       +4 -50     jboss-seam/src/main/org/jboss/seam/jsf/SeamExtendedManagedPersistencePortletPhaseListener.java
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: SeamExtendedManagedPersistencePortletPhaseListener.java
  ===================================================================
  RCS file: /cvsroot/jboss/jboss-seam/src/main/org/jboss/seam/jsf/SeamExtendedManagedPersistencePortletPhaseListener.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -b -r1.6 -r1.7
  --- SeamExtendedManagedPersistencePortletPhaseListener.java	27 Sep 2006 03:53:49 -0000	1.6
  +++ SeamExtendedManagedPersistencePortletPhaseListener.java	4 Nov 2006 01:27:43 -0000	1.7
  @@ -1,58 +1,12 @@
  -//$Id: SeamExtendedManagedPersistencePortletPhaseListener.java,v 1.6 2006/09/27 03:53:49 gavin Exp $
   package org.jboss.seam.jsf;
   
  -import javax.faces.event.PhaseEvent;
  -import javax.faces.event.PhaseId;
  -
   /**
  - * Transaction management for extended persistence contexts.
  - * A transaction spans the restore view, apply request values, process validations,
  - * update model values and invoke application phases. It is committed when
  - * invoke application is complete, or renderResponse() or responseComplete() is
  - * called. A second transaction spans the render response phase.
  - * 
  + * @deprecated use TransactionalSeamPortletPhaseListener
    * @author Gavin King
  + *
    */
  -public class SeamExtendedManagedPersistencePortletPhaseListener extends SeamPortletPhaseListener
  +public class SeamExtendedManagedPersistencePortletPhaseListener extends
  +      TransactionalSeamPortletPhaseListener
   {
      
  -   @Override
  -   public void handleTransactionsBeforePhase(PhaseEvent event)
  -   {
  -      PhaseId phaseId = event.getPhaseId();
  -      boolean beginTran = phaseId==PhaseId.RESTORE_VIEW || 
  -            phaseId==PhaseId.RENDER_RESPONSE || 
  -            phaseId==PhaseId.INVOKE_APPLICATION; //TODO: why is this here?
  -      
  -      if ( beginTran ) 
  -      {
  -         begin(phaseId);
  -      }
  -   }
  -
  -   @Override
  -   public void handleTransactionsAfterPhase(PhaseEvent event)
  -   {
  -      PhaseId phaseId = event.getPhaseId();
  -      boolean commitTran = phaseId==PhaseId.INVOKE_APPLICATION || 
  -            event.getFacesContext().getRenderResponse() || //TODO: no need to commit the tx if we failed to restore the view
  -            event.getFacesContext().getResponseComplete() || //TODO: unnecessary for portlet?
  -            phaseId==PhaseId.RENDER_RESPONSE;
  -      
  -      if (commitTran)
  -      { 
  -         commitOrRollback(phaseId); //we commit before destroying contexts, cos the contexts have the PC in them
  -      }    
  -   }
  -
  -   @Override
  -   protected void handleTransactionsAfterPageActions(PhaseEvent event)
  -   {
  -      commitOrRollback(PhaseId.INVOKE_APPLICATION);
  -      if ( !event.getFacesContext().getResponseComplete() ) //TODO: unnecessary for portlet?
  -      {
  -         begin(PhaseId.INVOKE_APPLICATION);
  -      }
  -   }
  -
   }
  
  
  
  1.1      date: 2006/11/04 01:27:43;  author: gavin;  state: Exp;jboss-seam/src/main/org/jboss/seam/jsf/TransactionalSeamPhaseListener.java
  
  Index: TransactionalSeamPhaseListener.java
  ===================================================================
  //$Id: TransactionalSeamPhaseListener.java,v 1.1 2006/11/04 01:27:43 gavin Exp $
  package org.jboss.seam.jsf;
  
  import javax.faces.event.PhaseEvent;
  import javax.faces.event.PhaseId;
  
  import org.jboss.seam.core.Init;
  
  /**
   * Transaction management for extended persistence contexts.
   * A transaction spans the restore view, apply request values, process validations,
   * update model values and invoke application phases. It is committed when
   * invoke application is complete, or renderResponse() or responseComplete() is
   * called. A second transaction spans the render response phase.
   * 
   * @author Gavin King
   */
  public class TransactionalSeamPhaseListener extends SeamPhaseListener
  {
     
     @Override
     public void handleTransactionsBeforePhase(PhaseEvent event)
     {
        PhaseId phaseId = event.getPhaseId();
        boolean beginTran = phaseId==PhaseId.RESTORE_VIEW || 
              ( phaseId==PhaseId.RENDER_RESPONSE && !Init.instance().isClientSideConversations() );
        
        if (beginTran) 
        {
           begin(phaseId);
        }
     }
  
     @Override
     public void handleTransactionsAfterPhase(PhaseEvent event)
     {
        PhaseId phaseId = event.getPhaseId();
        boolean commitTran = phaseId==PhaseId.INVOKE_APPLICATION || 
              event.getFacesContext().getRenderResponse() || //TODO: no need to commit the tx if we failed to restore the view
              event.getFacesContext().getResponseComplete() ||
              ( phaseId==PhaseId.RENDER_RESPONSE && !Init.instance().isClientSideConversations() );
        
        if (commitTran)
        { 
           commitOrRollback(phaseId); //we commit before destroying contexts, cos the contexts have the PC in them
        }     
     }
  
     @Override
     protected void handleTransactionsAfterPageActions(PhaseEvent event)
     {
        commitOrRollback(PhaseId.INVOKE_APPLICATION);
        if ( !event.getFacesContext().getResponseComplete() )
        {
           begin(PhaseId.INVOKE_APPLICATION);
        }
     }
  
  }
  
  
  
  1.1      date: 2006/11/04 01:27:43;  author: gavin;  state: Exp;jboss-seam/src/main/org/jboss/seam/jsf/TransactionalSeamPortletPhaseListener.java
  
  Index: TransactionalSeamPortletPhaseListener.java
  ===================================================================
  //$Id: TransactionalSeamPortletPhaseListener.java,v 1.1 2006/11/04 01:27:43 gavin Exp $
  package org.jboss.seam.jsf;
  
  import javax.faces.event.PhaseEvent;
  import javax.faces.event.PhaseId;
  
  /**
   * Transaction management for extended persistence contexts.
   * A transaction spans the restore view, apply request values, process validations,
   * update model values and invoke application phases. It is committed when
   * invoke application is complete, or renderResponse() or responseComplete() is
   * called. A second transaction spans the render response phase.
   * 
   * @author Gavin King
   */
  public class TransactionalSeamPortletPhaseListener extends SeamPortletPhaseListener
  {
     
     @Override
     public void handleTransactionsBeforePhase(PhaseEvent event)
     {
        PhaseId phaseId = event.getPhaseId();
        boolean beginTran = phaseId==PhaseId.RESTORE_VIEW || 
              phaseId==PhaseId.RENDER_RESPONSE || 
              phaseId==PhaseId.INVOKE_APPLICATION; //TODO: why is this here?
        
        if ( beginTran ) 
        {
           begin(phaseId);
        }
     }
  
     @Override
     public void handleTransactionsAfterPhase(PhaseEvent event)
     {
        PhaseId phaseId = event.getPhaseId();
        boolean commitTran = phaseId==PhaseId.INVOKE_APPLICATION || 
              event.getFacesContext().getRenderResponse() || //TODO: no need to commit the tx if we failed to restore the view
              event.getFacesContext().getResponseComplete() || //TODO: unnecessary for portlet?
              phaseId==PhaseId.RENDER_RESPONSE;
        
        if (commitTran)
        { 
           commitOrRollback(phaseId); //we commit before destroying contexts, cos the contexts have the PC in them
        }    
     }
  
     @Override
     protected void handleTransactionsAfterPageActions(PhaseEvent event)
     {
        commitOrRollback(PhaseId.INVOKE_APPLICATION);
        if ( !event.getFacesContext().getResponseComplete() ) //TODO: unnecessary for portlet?
        {
           begin(PhaseId.INVOKE_APPLICATION);
        }
     }
  
  }
  
  
  



More information about the jboss-cvs-commits mailing list