[jboss-cvs] JBossCache/src/org/jboss/cache/jmx ...

[Brian Stansberry]

  User: bstansberry
  Date: 06/11/05 00:08:49

  Modified:    src/org/jboss/cache/jmx  JmxUtil.java
  Log:
  Change default ObjectName
  
  Revision  Changes    Path
  1.3       +8 -2      JBossCache/src/org/jboss/cache/jmx/JmxUtil.java
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: JmxUtil.java
  ===================================================================
  RCS file: /cvsroot/jboss/JBossCache/src/org/jboss/cache/jmx/JmxUtil.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -b -r1.2 -r1.3
  --- JmxUtil.java	25 Sep 2006 05:50:04 -0000	1.2
  +++ JmxUtil.java	5 Nov 2006 05:08:49 -0000	1.3
  @@ -35,13 +35,14 @@
    *
    * @author Jerry Gauthier
    * @author Manik Surtani
  - * @version $Id: JmxUtil.java,v 1.2 2006/09/25 05:50:04 bwang Exp $
  + * @version $Id: JmxUtil.java,v 1.3 2006/11/05 05:08:49 bstansberry Exp $
    */
   public class JmxUtil
   {
      public static final String MBEAN_CLASS_SUFFIX = "MBean";
      public static final String MBEAN_KEY = ",treecache-interceptor=";
  -   public static final String PREFIX = "jboss.cache:service=";
  +   public static final String JBOSS_CACHE_DOMAIN = "jboss.cache";
  +   public static final String PREFIX = JBOSS_CACHE_DOMAIN + ":service=Cache,clusterName=";
      private static final String JBOSS_SERVER_DOMAIN = "jboss";
   
      /*
  @@ -63,6 +64,9 @@
         String tmpName = getCacheObjectName(cache.getCacheSPI());
   
         // register the cache
  +      // TODO (BES 2006-11-04) I don't think there is any use case for not registering.
  +      // This check is legacy stuff from 1.4, when the AS JMX microkernel may have
  +      // already registered the old monolithic cache.
         if (registerCache)
         {
            ObjectName tmpObj = new ObjectName(tmpName);
  @@ -150,6 +154,8 @@
         }
   
         // unregister the cache itself
  +      // TODO (BES 2006-11-04) I don't think there is any use case for not unregistering.
  +      // See comment in registerInterceptors
         if (unregisterCache)
         {
            ObjectName tmpObj = new ObjectName(tmpName);