[jboss-cvs] JBossCache/src/org/jboss/cache/lock ...

[Elias Ross]

  User: genman  
  Date: 06/11/06 18:34:09

  Modified:    src/org/jboss/cache/lock   LockStrategySerializable.java
                        SimpleLock.java
  Log:
  Fix potential NPE found using static analysis, clean up unused variables, use Integer.valueOf() as an optimization
  
  Revision  Changes    Path
  1.3       +3 -4      JBossCache/src/org/jboss/cache/lock/LockStrategySerializable.java
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: LockStrategySerializable.java
  ===================================================================
  RCS file: /cvsroot/jboss/JBossCache/src/org/jboss/cache/lock/LockStrategySerializable.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -b -r1.2 -r1.3
  --- LockStrategySerializable.java	5 Apr 2005 17:19:28 -0000	1.2
  +++ LockStrategySerializable.java	6 Nov 2006 23:34:09 -0000	1.3
  @@ -21,18 +21,17 @@
    * <p> Phantom read allows (t1) read n rows, (t2) insert k rows, and (t1) read n+k rows.</p>
    *
    * @author <a href="mailto:bwang00 at sourceforge.net">Ben Wang</a> July 15, 2003
  - * @version $Revision: 1.2 $
  + * @version $Revision: 1.3 $
    */
   public class LockStrategySerializable implements LockStrategy
   {
   //    Log log=LogFactory.getLog(getClass());
  -   private int permits_;
  +
      private FIFOSemaphore sem_;
   
      public LockStrategySerializable()
      {
  -      permits_ = 1;
  -      sem_ = new FIFOSemaphore(permits_);
  +      sem_ = new FIFOSemaphore(1);
      }
   
      /**
  
  
  
  1.3       +2 -4      JBossCache/src/org/jboss/cache/lock/SimpleLock.java
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: SimpleLock.java
  ===================================================================
  RCS file: /cvsroot/jboss/JBossCache/src/org/jboss/cache/lock/SimpleLock.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -b -r1.2 -r1.3
  --- SimpleLock.java	5 Apr 2005 17:19:28 -0000	1.2
  +++ SimpleLock.java	6 Nov 2006 23:34:09 -0000	1.3
  @@ -17,18 +17,16 @@
    * is transaction isolation level.
    *
    * @author <a href="mailto:bwang00 at sourceforge.net">Ben Wang</a> July 15, 2003
  - * @version $Revision: 1.2 $
  + * @version $Revision: 1.3 $
    */
   public class SimpleLock
   {
   //    Log log=LogFactory.getLog(getClass());
  -   private int permits_;
      private FIFOSemaphore sem_;
   
      public SimpleLock()
      {
  -      permits_ = 1;
  -      sem_ = new FIFOSemaphore(permits_);
  +      sem_ = new FIFOSemaphore(1);
      }
   
      /**