[jboss-cvs] JBossCache/src/org/jboss/cache ...
Brian Stansberry
brian.stansberry at jboss.com
Thu Nov 16 00:57:26 EST 2006
User: bstansberry
Date: 06/11/16 00:57:26
Modified: src/org/jboss/cache TreeCache.java
Log:
No fetchPartialState exception if singleton group!
Revision Changes Path
1.272 +6 -2 JBossCache/src/org/jboss/cache/TreeCache.java
(In the diff below, changes in quantity of whitespace are not shown.)
Index: TreeCache.java
===================================================================
RCS file: /cvsroot/jboss/JBossCache/src/org/jboss/cache/TreeCache.java,v
retrieving revision 1.271
retrieving revision 1.272
diff -u -b -r1.271 -r1.272
--- TreeCache.java 15 Nov 2006 23:48:31 -0000 1.271
+++ TreeCache.java 16 Nov 2006 05:57:26 -0000 1.272
@@ -94,7 +94,7 @@
* @author <a href="mailto:manik at jboss.org">Manik Surtani (manik at jboss.org)</a>
* @author Brian Stansberry
* @author Daniel Huang (dhuang at jboss.org)
- * @version $Id: TreeCache.java,v 1.271 2006/11/15 23:48:31 msurtani Exp $
+ * @version $Id: TreeCache.java,v 1.272 2006/11/16 05:57:26 bstansberry Exp $
* <p/>
* @see <a href="http://labs.jboss.com/portal/jbosscache/docs">JBossCache doc</a>
*/
@@ -565,6 +565,7 @@
if (sources == null || sources.length<1 || stateId == null)
{
// should this really be throwing an exception? Are there valid use cases where partial state may not be available? - Manik
+ // Yes -- cache is configured LOCAL but app doesn't know it -- Brian
//throw new IllegalArgumentException("Cannot fetch partial state, targets are " + sources + " and stateId is " + stateId);
if (log.isWarnEnabled()) log.warn("Cannot fetch partial state, targets are " + sources + " and stateId is " + stateId);
return;
@@ -576,7 +577,10 @@
if (targets.isEmpty())
{
- throw new IllegalArgumentException("Cannot fetch partial state. There are no target members specified");
+ // Definitely no exception here -- this happens every time the 1st node in the
+ // cluster activates a region!! -- Brian
+ log.debug("Cannot fetch partial state. There are no target members specified");
+ return;
}
log.debug("Node " + getLocalAddress() + " fetching partial state " + stateId + " from members " + targets);
More information about the jboss-cvs-commits
mailing list