[Jboss-cvs] JBoss Messaging SVN: r1332 - branches/Branch_1_0/src/main/org/jboss/jms/client

[jboss-cvs-commits at lists.jboss.org]

Author: ovidiu.feodorov at jboss.com
Date: 2006-09-20 19:34:26 -0400 (Wed, 20 Sep 2006)
New Revision: 1332

Modified:
   branches/Branch_1_0/src/main/org/jboss/jms/client/JBossConnection.java
Log:
removed the cause for occasional remote test failures: http://jira.jboss.org/jira/browse/JBMESSAGING-548

Modified: branches/Branch_1_0/src/main/org/jboss/jms/client/JBossConnection.java
===================================================================
--- branches/Branch_1_0/src/main/org/jboss/jms/client/JBossConnection.java	2006-09-20 22:35:28 UTC (rev 1331)
+++ branches/Branch_1_0/src/main/org/jboss/jms/client/JBossConnection.java	2006-09-20 23:34:26 UTC (rev 1332)
@@ -75,7 +75,6 @@
 
    protected ConnectionDelegate delegate;
    private int connectionType;
-   private boolean closed;
 
    // Constructors --------------------------------------------------
 
@@ -131,7 +130,6 @@
    {
       delegate.closing();
       delegate.close();
-      closed = true;
    }
 
    public ConnectionConsumer createConnectionConsumer(Destination destination,
@@ -264,16 +262,21 @@
       }
    }
 
-   protected void finalize() throws Throwable
-   {
-      super.finalize();
-      //If a user hasn't explicitly closed the connection due to sloppy programming
-      //then we close it here
-      if (!closed)
-      {
-         close();
-      }
-   }
+   // Temporarily commented out as it seems to produce random test failures
+   // See http://jira.jboss.org/jira/browse/JBMESSAGING-548
+   
+//   protected void finalize() throws Throwable
+//   {
+//      super.finalize();
+//
+//      // If a user hasn't explicitly closed the connection due to sloppy programming then
+//      // we close it here
+//
+//      if (!delegate.isClosed())
+//      {
+//         close();
+//      }
+//   }
 
    // Private -------------------------------------------------------