[jboss-cvs] JBossAS SVN: r62030 - projects/microcontainer/trunk/dependency/src/main/org/jboss/dependency/plugins.

jboss-cvs-commits at lists.jboss.org jboss-cvs-commits at lists.jboss.org
Tue Apr 3 09:00:24 EDT 2007


Author: adrian at jboss.org
Date: 2007-04-03 09:00:24 -0400 (Tue, 03 Apr 2007)
New Revision: 62030

Modified:
   projects/microcontainer/trunk/dependency/src/main/org/jboss/dependency/plugins/AbstractController.java
Log:
isActive() should have a read lock otherwise it could see an inconsistent view.

Modified: projects/microcontainer/trunk/dependency/src/main/org/jboss/dependency/plugins/AbstractController.java
===================================================================
--- projects/microcontainer/trunk/dependency/src/main/org/jboss/dependency/plugins/AbstractController.java	2007-04-03 12:47:12 UTC (rev 62029)
+++ projects/microcontainer/trunk/dependency/src/main/org/jboss/dependency/plugins/AbstractController.java	2007-04-03 13:00:24 UTC (rev 62030)
@@ -151,7 +151,15 @@
     */
    public boolean isActive()
    {
-      return allContexts.isEmpty() == false;
+      lockRead();
+      try
+      {
+         return allContexts.isEmpty() == false;
+      }
+      finally
+      {
+         unlockRead();
+      }
    }
 
    public ControllerContext getContext(Object name, ControllerState state)




More information about the jboss-cvs-commits mailing list