[jboss-cvs] JBossAS SVN: r62635 - in projects/microcontainer/trunk/kernel/src/main/org/jboss: beans/metadata/plugins/annotations and 2 other directories.

[jboss-cvs-commits at lists.jboss.org]

Author: adrian at jboss.org
Date: 2007-04-30 10:08:57 -0400 (Mon, 30 Apr 2007)
New Revision: 62635

Modified:
   projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/InstallCallbackMetaData.java
   projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/UninstallCallbackMetaData.java
   projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/annotations/CallbackInfo.java
   projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/annotations/Install.java
   projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/annotations/Uninstall.java
   projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/policy/AbstractScopeMetaData.java
   projects/microcontainer/trunk/kernel/src/main/org/jboss/kernel/plugins/dependency/CollectionCreator.java
Log:
Javadoc and serialversionuid fixes.

Modified: projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/InstallCallbackMetaData.java
===================================================================
--- projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/InstallCallbackMetaData.java	2007-04-30 13:35:22 UTC (rev 62634)
+++ projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/InstallCallbackMetaData.java	2007-04-30 14:08:57 UTC (rev 62635)
@@ -31,6 +31,9 @@
  */
 public class InstallCallbackMetaData extends AbstractCallbackMetaData
 {
+   /** The serialVersionUID */
+   private static final long serialVersionUID = -8687489846562385403L;
+
    public InstallCallbackMetaData()
    {
       super();

Modified: projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/UninstallCallbackMetaData.java
===================================================================
--- projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/UninstallCallbackMetaData.java	2007-04-30 13:35:22 UTC (rev 62634)
+++ projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/UninstallCallbackMetaData.java	2007-04-30 14:08:57 UTC (rev 62635)
@@ -31,6 +31,9 @@
  */
 public class UninstallCallbackMetaData extends AbstractCallbackMetaData
 {
+   /** The serialVersionUID */
+   private static final long serialVersionUID = 1888688138196290492L;
+
    public UninstallCallbackMetaData()
    {
       super();

Modified: projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/annotations/CallbackInfo.java
===================================================================
--- projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/annotations/CallbackInfo.java	2007-04-30 13:35:22 UTC (rev 62634)
+++ projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/annotations/CallbackInfo.java	2007-04-30 14:08:57 UTC (rev 62635)
@@ -35,6 +35,9 @@
  */
 class CallbackInfo extends JBossObject implements Serializable
 {
+   /** The serialVersionUID */
+   private static final long serialVersionUID = -2213756676713799799L;
+
    /* The cardinality */
    protected Cardinality cardinality;
 

Modified: projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/annotations/Install.java
===================================================================
--- projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/annotations/Install.java	2007-04-30 13:35:22 UTC (rev 62634)
+++ projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/annotations/Install.java	2007-04-30 14:08:57 UTC (rev 62635)
@@ -29,8 +29,8 @@
 import org.jboss.beans.metadata.spi.annotations.DependencyFactoryLookup;
 
 /**
- * Inistall callback.
- * @see @org.jboss.beans.metadata.plugins.annotations.Callback
+ * Install callback.
+ * @see org.jboss.beans.metadata.plugins.annotations.Callback
  *
  * @author <a href="mailto:ales.justin at jboss.com">Ales Justin</a>
  */

Modified: projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/annotations/Uninstall.java
===================================================================
--- projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/annotations/Uninstall.java	2007-04-30 13:35:22 UTC (rev 62634)
+++ projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/annotations/Uninstall.java	2007-04-30 14:08:57 UTC (rev 62635)
@@ -29,8 +29,8 @@
 import org.jboss.beans.metadata.spi.annotations.DependencyFactoryLookup;
 
 /**
- * Uninistall callback.
- * @see @org.jboss.beans.metadata.plugins.annotations.Callback
+ * Uninstall callback.
+ * @see org.jboss.beans.metadata.plugins.annotations.Callback
  * 
  * @author <a href="mailto:ales.justin at jboss.com">Ales Justin</a>
  */

Modified: projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/policy/AbstractScopeMetaData.java
===================================================================
--- projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/policy/AbstractScopeMetaData.java	2007-04-30 13:35:22 UTC (rev 62634)
+++ projects/microcontainer/trunk/kernel/src/main/org/jboss/beans/metadata/plugins/policy/AbstractScopeMetaData.java	2007-04-30 14:08:57 UTC (rev 62635)
@@ -55,6 +55,7 @@
       return scope;
    }
 
+   @SuppressWarnings("unchecked")
    public Object getValue(TypeInfo info, ClassLoader cl) throws Throwable
    {
       if (scope != null)
@@ -63,6 +64,13 @@
          ScopeFactoryLookup scopeFactoryLookup = annotation.getClass().getAnnotation(ScopeFactoryLookup.class);
          if (scopeFactoryLookup != null)
          {
+            // TODO do we really want to create a new factory for every annotation we look at?
+            // We could use some kind of soft reference map here (per classloader)
+            // Class<?> clazz = scopeFactoryLookup.value();
+            // WeakHashMap.put(clazz.getClassLoader(), new SoftMap())
+            // SoftValueHashMap.put(clazz.getName(), instance)
+            // If this is done, it should be moved to a common helper class
+            // that does generic construction from a factory given on the meta annotations
             ScopeFactory scopeFactory = scopeFactoryLookup.value().newInstance();
             return scopeFactory.create(annotation);
          }

Modified: projects/microcontainer/trunk/kernel/src/main/org/jboss/kernel/plugins/dependency/CollectionCreator.java
===================================================================
--- projects/microcontainer/trunk/kernel/src/main/org/jboss/kernel/plugins/dependency/CollectionCreator.java	2007-04-30 13:35:22 UTC (rev 62634)
+++ projects/microcontainer/trunk/kernel/src/main/org/jboss/kernel/plugins/dependency/CollectionCreator.java	2007-04-30 14:08:57 UTC (rev 62635)
@@ -31,6 +31,8 @@
 
 /**
  * Collection creator.
+ * 
+ * @param <T> the collection type
  */
 public interface CollectionCreator<T extends Collection<Object>>
 {