[jboss-cvs] JBossAS SVN: r62642 - in projects/test/trunk/src/main/java/org/jboss/test: logging/jdk and 1 other directory.
jboss-cvs-commits at lists.jboss.org
jboss-cvs-commits at lists.jboss.org
Mon Apr 30 12:01:53 EDT 2007
Author: adrian at jboss.org
Date: 2007-04-30 12:01:53 -0400 (Mon, 30 Apr 2007)
New Revision: 62642
Modified:
projects/test/trunk/src/main/java/org/jboss/test/JBossTestCase.java
projects/test/trunk/src/main/java/org/jboss/test/JBossTestServices.java
projects/test/trunk/src/main/java/org/jboss/test/JBossTestSetup.java
projects/test/trunk/src/main/java/org/jboss/test/logging/jdk/PatternConverter.java
projects/test/trunk/src/main/java/org/jboss/test/logging/jdk/PatternFormatter.java
projects/test/trunk/src/main/java/org/jboss/test/logging/jdk/PatternParser.java
Log:
Source code tidyup
Modified: projects/test/trunk/src/main/java/org/jboss/test/JBossTestCase.java
===================================================================
--- projects/test/trunk/src/main/java/org/jboss/test/JBossTestCase.java 2007-04-30 15:28:53 UTC (rev 62641)
+++ projects/test/trunk/src/main/java/org/jboss/test/JBossTestCase.java 2007-04-30 16:01:53 UTC (rev 62642)
@@ -64,6 +64,10 @@
// Static --------------------------------------------------------
/**
* Overriden to return JBossTestServices as the test delegate.
+ *
+ * @param clazz the test class
+ * @return the delegate
+ * @throws Exception for any error
*/
public static AbstractTestDelegate getDelegate(Class clazz) throws Exception
{
@@ -275,6 +279,7 @@
/**
* Get a JBossTestSetup that does login and deployment in setUp/tearDown
*
+ * @param clazz the test class
* @param test a Test
* @param jarNames is a comma seperated list of deployments
* @return the wrapping test that does the setup
Modified: projects/test/trunk/src/main/java/org/jboss/test/JBossTestServices.java
===================================================================
--- projects/test/trunk/src/main/java/org/jboss/test/JBossTestServices.java 2007-04-30 15:28:53 UTC (rev 62641)
+++ projects/test/trunk/src/main/java/org/jboss/test/JBossTestServices.java 2007-04-30 16:01:53 UTC (rev 62642)
@@ -34,7 +34,6 @@
import javax.naming.InitialContext;
import javax.security.auth.login.LoginContext;
-import org.jboss.logging.Logger;
import org.jboss.test.util.AppCallbackHandler;
/**
Modified: projects/test/trunk/src/main/java/org/jboss/test/JBossTestSetup.java
===================================================================
--- projects/test/trunk/src/main/java/org/jboss/test/JBossTestSetup.java 2007-04-30 15:28:53 UTC (rev 62641)
+++ projects/test/trunk/src/main/java/org/jboss/test/JBossTestSetup.java 2007-04-30 16:01:53 UTC (rev 62642)
@@ -29,7 +29,6 @@
import javax.management.ObjectName;
import javax.naming.InitialContext;
-import junit.extensions.TestSetup;
import junit.framework.Test;
import org.jboss.logging.Logger;
@@ -59,6 +58,7 @@
/**
* Constructor for the JBossTestCase object
*
+ * @param clazz the class
* @param test the test
* @throws Exception for any error
*/
Modified: projects/test/trunk/src/main/java/org/jboss/test/logging/jdk/PatternConverter.java
===================================================================
--- projects/test/trunk/src/main/java/org/jboss/test/logging/jdk/PatternConverter.java 2007-04-30 15:28:53 UTC (rev 62641)
+++ projects/test/trunk/src/main/java/org/jboss/test/logging/jdk/PatternConverter.java 2007-04-30 16:01:53 UTC (rev 62642)
@@ -57,12 +57,18 @@
/**
* Derived pattern converters must override this method in order to
* convert conversion specifiers in the correct way.
+ *
+ * @param event the event
+ * @return the converted event
*/
abstract
protected String convert(LogRecord event);
/**
* A template method for formatting in a converter specific way.
+ *
+ * @param sbuf the string buffer
+ * @param e the log recored
*/
public void format(StringBuffer sbuf, LogRecord e)
{
@@ -102,6 +108,9 @@
/**
* Fast space padding method.
+ *
+ * @param sbuf the string buffer
+ * @param length the length
*/
public void spacePad(StringBuffer sbuf, int length)
{
Modified: projects/test/trunk/src/main/java/org/jboss/test/logging/jdk/PatternFormatter.java
===================================================================
--- projects/test/trunk/src/main/java/org/jboss/test/logging/jdk/PatternFormatter.java 2007-04-30 15:28:53 UTC (rev 62641)
+++ projects/test/trunk/src/main/java/org/jboss/test/logging/jdk/PatternFormatter.java 2007-04-30 16:01:53 UTC (rev 62642)
@@ -24,6 +24,8 @@
import java.util.logging.Formatter;
import java.util.logging.LogRecord;
+import org.apache.log4j.spi.LoggingEvent;
+
/**
* A log4j style pattern formatter.
*
@@ -69,6 +71,8 @@
/**
* Constructs a PatternLayout using the supplied conversion pattern.
+ *
+ * @param pattern the pattern
*/
public PatternFormatter(String pattern)
{
@@ -81,6 +85,8 @@
* Set the <b>ConversionPattern</b> option. This is the string which
* controls formatting and consists of a mix of literal content and
* conversion specifiers.
+ *
+ * @param conversionPattern the conversion pattern
*/
public void setConversionPattern(String conversionPattern)
{
@@ -90,6 +96,8 @@
/**
* Returns the value of the <b>ConversionPattern</b> option.
+ *
+ * @return the conversion pattern
*/
public String getConversionPattern()
{
@@ -110,6 +118,8 @@
* <code>true</code>.
*
* @since 0.8.4
+ *
+ * @return true if the throwable is ignored
*/
public boolean ignoresThrowable()
{
@@ -122,6 +132,9 @@
* custom conversion characters.
*
* @since 0.9.0
+ *
+ * @param pattern the pattern
+ * @return the parser
*/
protected PatternParser createPatternParser(String pattern)
{
Modified: projects/test/trunk/src/main/java/org/jboss/test/logging/jdk/PatternParser.java
===================================================================
--- projects/test/trunk/src/main/java/org/jboss/test/logging/jdk/PatternParser.java 2007-04-30 15:28:53 UTC (rev 62641)
+++ projects/test/trunk/src/main/java/org/jboss/test/logging/jdk/PatternParser.java 2007-04-30 16:01:53 UTC (rev 62642)
@@ -26,6 +26,8 @@
import java.util.Date;
import java.util.logging.LogRecord;
+import org.apache.log4j.helpers.OptionConverter;
+
// Contributors: Nelson Minar <(nelson at monkey.org>
// Igor E. Poteryaev <jah at mail.ru>
// Reinhard Deschler <reinhard.deschler at web.de>
@@ -119,6 +121,8 @@
/**
* The option is expected to be in decimal and positive. In case of
* error, zero is returned.
+ *
+ * @return the precision
*/
protected int extractPrecisionOption()
{
More information about the jboss-cvs-commits
mailing list