[jboss-cvs] jbosside/core/plugins/org.jboss.ide.eclipse.packages.core/src/main/org/jboss/ide/eclipse/packages/core/model ...

Marshall Culpepper mculpepper at jboss.com
Wed Feb 14 14:10:18 EST 2007


  User: mculpepper
  Date: 07/02/14 14:10:18

  Modified:    core/plugins/org.jboss.ide.eclipse.packages.core/src/main/org/jboss/ide/eclipse/packages/core/model  
                        IPackageFileSet.java IPackage.java
  Log:
  changed getXXFolder to getXXPath (path is agnostic and doesnt' care if the root is filesystem based or not)
  
  Revision  Changes    Path
  1.4       +7 -7      jbosside/core/plugins/org.jboss.ide.eclipse.packages.core/src/main/org/jboss/ide/eclipse/packages/core/model/IPackageFileSet.java
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: IPackageFileSet.java
  ===================================================================
  RCS file: /cvsroot/jboss/jbosside/core/plugins/org.jboss.ide.eclipse.packages.core/src/main/org/jboss/ide/eclipse/packages/core/model/IPackageFileSet.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -b -r1.3 -r1.4
  --- IPackageFileSet.java	20 Dec 2006 19:56:40 -0000	1.3
  +++ IPackageFileSet.java	14 Feb 2007 19:10:18 -0000	1.4
  @@ -32,7 +32,7 @@
    * </p>
    * 
    * @author <a href="marshall at jboss.org">Marshall Culpepper</a>
  - * @version $Revision: 1.3 $
  + * @version $Revision: 1.4 $
    */
   public interface IPackageFileSet extends IPackageNode {
   
  @@ -53,7 +53,7 @@
   	public IFile getFile();
   	
   	/**
  -	 * If this fileset represents a single file, and that file is not in the workspace, this will return a filesystem path to that file.
  +	 * If this fileset represents a single file, this will return the path to that file.
   	 * Otherwise this will return null.
   	 */
   	public IPath getFilePath();
  @@ -75,10 +75,10 @@
   	public IContainer getSourceContainer();
   	
   	/**
  -	 * If this fileset is based in the external filesystem, this will return the absolute path of the root / base of this fileset.
  -	 * @return The path to the source folder ("basedir" in ant terminology) for this fileset
  +	 * @return The path to the source folder ("basedir" in ant terminology) for this fileset. Note that this path can be
  +	 * filesystem-based or workspace-based.
   	 */
  -	public IPath getSourceFolder();
  +	public IPath getSourcePath();
   	
   	/**
   	 * @return The includes pattern for this fileset
  @@ -156,10 +156,10 @@
   	public void setSourceContainer(IContainer container);
   	
   	/**
  -	 * Sets the "root" or "source" of this fileset to be an absolute path on the filesystem
  +	 * Sets the "root" or "source" of this fileset to be an absolute path.
   	 * @param path The absolute path that is the source of this fileset
   	 */
  -	public void setSourceFolder(IPath path);
  +	public void setSourcePath(IPath path);
   	
   	/**
   	 * Set the includes pattern for this fileset. This pattern uses the same syntax as Ant's include pattern.
  
  
  
  1.7       +8 -10     jbosside/core/plugins/org.jboss.ide.eclipse.packages.core/src/main/org/jboss/ide/eclipse/packages/core/model/IPackage.java
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: IPackage.java
  ===================================================================
  RCS file: /cvsroot/jboss/jbosside/core/plugins/org.jboss.ide.eclipse.packages.core/src/main/org/jboss/ide/eclipse/packages/core/model/IPackage.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -b -r1.6 -r1.7
  --- IPackage.java	9 Feb 2007 19:03:12 -0000	1.6
  +++ IPackage.java	14 Feb 2007 19:10:18 -0000	1.7
  @@ -35,7 +35,7 @@
    * </p>
    * 
    * @author <a href="marshall at jboss.org">Marshall Culpepper</a>
  - * @version $Revision: 1.6 $
  + * @version $Revision: 1.7 $
    */
   public interface IPackage extends IPackageNode {
   
  @@ -85,11 +85,10 @@
   	public boolean isDestinationInWorkspace();
   	
   	/**
  -	 * If this package's destination is external (and not in the workspace), this will
  -	 * return a file-system IPath to that destination. Otherwise this will return null
  -	 * @return The absolute IPath in the file-system to this package's external destination
  +	 * @return An IPath to this package's destination. Note that this destination can either be
  +	 * filesystem-based or in the workspace. (Use isDestinationInWorkspace() to check)
   	 */
  -	public IPath getDestinationFolder();
  +	public IPath getDestinationPath();
   	
   	/**
   	 * If this package's destination is in the workspace (and not external), this will
  @@ -121,8 +120,7 @@
   	public IFile getPackageFile();
   
   	/**
  -	 * Get the absolute path on the file system that corresponds with this package. Note that this method only works for external (filesystem) packages (null will be returned otherwise)
  -	 * @return The absolute path to the package (note the file may not exist)
  +	 * @return The path to this package's output file. This path can be filesyste-based or workspace-based.
   	 */
   	public IPath getPackageFilePath();
   	
  @@ -158,13 +156,13 @@
   	public void setManifest(IFile manifestFile);
   	
   	/**
  -	 * Sets the destination folder in the filesystem for this package
  +	 * Sets the destination path for this package.
   	 * @param path The absolute path where this package will be built
   	 */
  -	public void setDestinationFolder (IPath path);
  +	public void setDestinationPath (IPath path);
   	
   	/**
  -	 * Sets the destination container in the workspace for this package
  +	 * Convenience method. The same as <code>setDestinationPath(container.getLocation())</code>
   	 * @param container The container where this package will be built
   	 */
   	public void setDestinationContainer(IContainer container);
  
  
  



More information about the jboss-cvs-commits mailing list