[jboss-cvs] JBossAS SVN: r60552 - branches/Branch_4_2/connector/src/main/org/jboss/resource/adapter/jms/inflow.

[jboss-cvs-commits at lists.jboss.org]

Author: weston.price at jboss.com
Date: 2007-02-14 16:48:16 -0500 (Wed, 14 Feb 2007)
New Revision: 60552

Modified:
   branches/Branch_4_2/connector/src/main/org/jboss/resource/adapter/jms/inflow/JmsServerSessionPool.java
Log:
[JBAS-3972]Fixed incorrect synchronization handling of server sessions
as well as using the correct cloned session list in startup code.

Modified: branches/Branch_4_2/connector/src/main/org/jboss/resource/adapter/jms/inflow/JmsServerSessionPool.java
===================================================================
--- branches/Branch_4_2/connector/src/main/org/jboss/resource/adapter/jms/inflow/JmsServerSessionPool.java	2007-02-14 21:03:58 UTC (rev 60551)
+++ branches/Branch_4_2/connector/src/main/org/jboss/resource/adapter/jms/inflow/JmsServerSessionPool.java	2007-02-14 21:48:16 UTC (rev 60552)
@@ -178,6 +178,7 @@
    protected void setupSessions() throws Exception
    {
       JmsActivationSpec spec = activation.getActivationSpec();
+      ArrayList clonedSessions = null;
 
       // Create the sessions
       synchronized (serverSessions)
@@ -188,13 +189,14 @@
             serverSessions.add(session);
          }
          sessionCount = serverSessions.size();
+         clonedSessions = (ArrayList) serverSessions.clone();
+
       }
       
       // Start the sessions
-      ArrayList clonedSessions = (ArrayList) serverSessions.clone();
       for (int i = 0; i < clonedSessions.size(); ++ i)
       {
-         JmsServerSession session = (JmsServerSession) serverSessions.get(i);
+         JmsServerSession session = (JmsServerSession) clonedSessions.get(i);
          session.setup();
       }
    }