[jboss-cvs] JBossRemoting/src/main/org/jboss/remoting ...

Ron Sigal ron_sigal at yahoo.com
Wed Jan 17 21:37:27 EST 2007


  User: rsigal  
  Date: 07/01/17 21:37:27

  Modified:    src/main/org/jboss/remoting  Tag: remoting_2_x
                        InvokerRegistry.java
  Log:
  JBREM-662:  Removed reference to InvokeRegistry.reallyDestroyClientInvoker().
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.34.4.3  +1 -38     JBossRemoting/src/main/org/jboss/remoting/InvokerRegistry.java
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: InvokerRegistry.java
  ===================================================================
  RCS file: /cvsroot/jboss/JBossRemoting/src/main/org/jboss/remoting/InvokerRegistry.java,v
  retrieving revision 1.34.4.2
  retrieving revision 1.34.4.3
  diff -u -b -r1.34.4.2 -r1.34.4.3
  --- InvokerRegistry.java	11 Jan 2007 20:34:50 -0000	1.34.4.2
  +++ InvokerRegistry.java	18 Jan 2007 02:37:26 -0000	1.34.4.3
  @@ -48,7 +48,7 @@
    *
    * @author <a href="mailto:jhaynie at vocalocity.net">Jeff Haynie</a>
    * @author <a href="mailto:telrod at e2technologies.net">Tom Elrod</a>
  - * @version $Revision: 1.34.4.2 $
  + * @version $Revision: 1.34.4.3 $
    */
   public class InvokerRegistry
   {
  @@ -229,43 +229,6 @@
      }
   
      /**
  -    * (Temporary) method that fixes http://jira.jboss.org/jira/browse/JBREM-662.
  -    * Must be refactored (renamed, to start with).
  -    */
  -   public static void reallyDestroyClientInvoker(InvokerLocator locator, Map configuration)
  -   {
  -      synchronized(clientLock)
  -      {
  -         if (isTraceEnabled)
  -         {
  -            log.trace("really destroying client invoker " + locator + ", config " + configuration);
  -         }
  -
  -         // loop until last reference; really dangerous if the invoker is not in registry, because
  -         // it will loop forever. decrementClientInvokerCounter() semantics must change to clearly
  -         // indicate when it was a invoker and when it wasn't an invoker in registry.
  -
  -         int loops = 0;
  -         ClientInvoker invoker = null;
  -         while((invoker = decrementClientInvokerCounter(locator, configuration)) == null)
  -         {
  -            // loop, dangerous, a precautionary hack
  -            if (++loops == 50)
  -            {
  -               throw new IllegalStateException("got into a hopeless loop!");
  -            }
  -         }
  -
  -         if (isTraceEnabled)
  -         {
  -            log.trace("disconnecting " + invoker);
  -         }
  -         invoker.disconnect();
  -         invoker = null;
  -      }
  -   }
  -
  -   /**
        * create a ClientInvoker instance, using the specific InvokerLocator, which is just a client-side
       * invoker to a remote server.  Will use the default configuration values for the transport.
       *
  
  
  



More information about the jboss-cvs-commits mailing list