[jboss-cvs] JBoss Messaging SVN: r2024 - trunk/src/main/org/jboss/jms/server/remoting.

[jboss-cvs-commits at lists.jboss.org]

Author: ovidiu.feodorov at jboss.com
Date: 2007-01-23 05:37:21 -0500 (Tue, 23 Jan 2007)
New Revision: 2024

Modified:
   trunk/src/main/org/jboss/jms/server/remoting/JMSWireFormat.java
Log:
extra changes for http://jira.jboss.org/jira/browse/JBMESSAGING-773

Modified: trunk/src/main/org/jboss/jms/server/remoting/JMSWireFormat.java
===================================================================
--- trunk/src/main/org/jboss/jms/server/remoting/JMSWireFormat.java	2007-01-23 10:00:12 UTC (rev 2023)
+++ trunk/src/main/org/jboss/jms/server/remoting/JMSWireFormat.java	2007-01-23 10:37:21 UTC (rev 2024)
@@ -671,13 +671,13 @@
                
                mi.setArguments(args);
 
-               // the remoting server requires us to "mark" an one-way invocation redundantly once
+               // http://jira.jboss.org/jira/browse/JBMESSAGING-773
+               // The remoting server requires us to "mark" an one-way invocation redundantly once
                // by wrapping an OnewayInvocation within an InvocationRequest, and then placing
                // a Client.ONEWAY_FLAG in the same InvocationRequest's metadata. Why?
 
                OnewayInvocation oi = new OnewayInvocation(new MessagingMarshallable(version, mi));
 
-
                InvocationRequest request =
                   new InvocationRequest(null, ServerPeer.REMOTING_JMS_SUBSYSTEM,
                                         oi, ONE_WAY_METADATA, null, null);
@@ -946,14 +946,20 @@
                // recreate callback
                MessagingMarshallable mm = new MessagingMarshallable(version, dr);
                Callback callback = new Callback(mm);
-               InternalInvocation ii
-                  = new InternalInvocation(InternalInvocation.HANDLECALLBACK, new Object[]{callback});
 
+               InternalInvocation ii = new InternalInvocation(InternalInvocation.HANDLECALLBACK,
+                                                              new Object[]{callback});
+
+               // http://jira.jboss.org/jira/browse/JBMESSAGING-773
+               // The remoting server requires us to "mark" an one-way invocation redundantly once
+               // by wrapping an OnewayInvocation within an InvocationRequest, and then placing
+               // a Client.ONEWAY_FLAG in the same InvocationRequest's metadata. Why?
+
                OnewayInvocation oi = new OnewayInvocation(ii);
 
                InvocationRequest request
                   = new InvocationRequest(sessionId, CallbackManager.JMS_CALLBACK_SUBSYSTEM,
-                                          oi, null, null, null);
+                                          oi, ONE_WAY_METADATA, null, null);
    
                if (trace) { log.trace("read callback()"); }