[jboss-cvs] JBoss Messaging SVN: r2041 - trunk/src/main/org/jboss/jms/client.

[jboss-cvs-commits at lists.jboss.org]

Author: clebert.suconic at jboss.com
Date: 2007-01-24 16:32:35 -0500 (Wed, 24 Jan 2007)
New Revision: 2041

Modified:
   trunk/src/main/org/jboss/jms/client/FailoverCommandCenter.java
Log:
opening the valve before broadcast events

Modified: trunk/src/main/org/jboss/jms/client/FailoverCommandCenter.java
===================================================================
--- trunk/src/main/org/jboss/jms/client/FailoverCommandCenter.java	2007-01-24 19:46:02 UTC (rev 2040)
+++ trunk/src/main/org/jboss/jms/client/FailoverCommandCenter.java	2007-01-24 21:32:35 UTC (rev 2041)
@@ -117,22 +117,14 @@
       }
       finally
       {
-         // I have this secondary try/finally block, just because if broadcastFailoverEvent throws
-         // any exceptions I don't want a dead lock on everybody waiting the valve to be opened.
-         try
+         valve.open();
+         if (failoverSuccessful)
          {
-            if (failoverSuccessful)
-            {
-               broadcastFailoverEvent(new FailoverEvent(FailoverEvent.FAILOVER_COMPLETED, this));
-            }
-            else
-            {
-               broadcastFailoverEvent(new FailoverEvent(FailoverEvent.FAILOVER_FAILED, this));
-            }
+            broadcastFailoverEvent(new FailoverEvent(FailoverEvent.FAILOVER_COMPLETED, this));
          }
-         finally
+         else
          {
-            valve.open();
+            broadcastFailoverEvent(new FailoverEvent(FailoverEvent.FAILOVER_FAILED, this));
          }
       }
    }