[jboss-cvs] JBossAS SVN: r60081 - branches/Branch_4_0/tomcat/src/main/org/jboss/web/tomcat/tc5/session.

[jboss-cvs-commits at lists.jboss.org]

Author: bstansberry at jboss.com
Date: 2007-01-28 00:17:10 -0500 (Sun, 28 Jan 2007)
New Revision: 60081

Modified:
   branches/Branch_4_0/tomcat/src/main/org/jboss/web/tomcat/tc5/session/JBossCacheManager.java
Log:
[JBAS-3840] Don't rollback tx if not started; don't call printStackTrace()

Modified: branches/Branch_4_0/tomcat/src/main/org/jboss/web/tomcat/tc5/session/JBossCacheManager.java
===================================================================
--- branches/Branch_4_0/tomcat/src/main/org/jboss/web/tomcat/tc5/session/JBossCacheManager.java	2007-01-28 05:15:17 UTC (rev 60080)
+++ branches/Branch_4_0/tomcat/src/main/org/jboss/web/tomcat/tc5/session/JBossCacheManager.java	2007-01-28 05:17:10 UTC (rev 60081)
@@ -1099,14 +1099,17 @@
          
          try
          {
-//            if(doTx)
-               // Let's set it no matter what.
+            //if(doTx)
+            // Let's setRollbackOnly no matter what.
+            // (except if there's no tx due to SESSION (JBAS-3840))
+            if (notSession)
                tm.setRollbackOnly();
          }
          catch (Exception exn)
          {
-            exn.printStackTrace();
+            log_.error("Caught exception rolling back transaction", exn);
          }
+         
          // We will need to alert Tomcat of this exception.
          if (ex instanceof RuntimeException)
             throw (RuntimeException) ex;