[jboss-cvs] JBossAS SVN: r63786 - in projects/microcontainer/trunk: deployers-core-spi/src/main/org/jboss/deployers/spi/structure and 12 other directories.
jboss-cvs-commits at lists.jboss.org
jboss-cvs-commits at lists.jboss.org
Mon Jul 2 14:34:33 EDT 2007
Author: adrian at jboss.org
Date: 2007-07-02 14:34:33 -0400 (Mon, 02 Jul 2007)
New Revision: 63786
Modified:
projects/microcontainer/trunk/deployers-client-spi/src/main/org/jboss/deployers/client/spi/IncompleteDeploymentException.java
projects/microcontainer/trunk/deployers-core-spi/src/main/org/jboss/deployers/spi/structure/ClassPathEntry.java
projects/microcontainer/trunk/deployers-impl/src/main/org/jboss/deployers/plugins/classloading/ClassLoading.java
projects/microcontainer/trunk/deployers-impl/src/main/org/jboss/deployers/plugins/classloading/Module.java
projects/microcontainer/trunk/deployers-impl/src/main/org/jboss/deployers/plugins/deployers/DeployersImpl.java
projects/microcontainer/trunk/deployers-impl/src/main/org/jboss/deployers/plugins/main/MainDeployerImpl.java
projects/microcontainer/trunk/deployers-impl/src/tests/org/jboss/test/deployers/deployer/test/DeployerProtocolUnitTestCase.java
projects/microcontainer/trunk/deployers-impl/src/tests/org/jboss/test/deployers/managed/test/DeployerManagedObjectUnitTestCase.java
projects/microcontainer/trunk/deployers-spi/src/main/org/jboss/deployers/spi/deployer/managed/ManagedObjectCreator.java
projects/microcontainer/trunk/deployers-structure-spi/src/main/org/jboss/deployers/structure/spi/classloading/ClassLoaderMetaData.java
projects/microcontainer/trunk/deployers-vfs/src/main/org/jboss/deployers/vfs/plugins/classloader/VFSClassLoaderPolicy.java
projects/microcontainer/trunk/deployers-vfs/src/main/org/jboss/deployers/vfs/plugins/classloader/VFSTopLevelClassLoaderSystemDeployer.java
projects/microcontainer/trunk/deployers-vfs/src/tests/org/jboss/test/deployers/vfs/structure/AbstractStructureTest.java
projects/microcontainer/trunk/deployers-vfs/src/tests/org/jboss/test/deployers/vfs/structure/ear/support/MockEarStructureDeployer.java
projects/microcontainer/trunk/deployers-vfs/src/tests/org/jboss/test/deployers/vfs/structure/ear/test/EARStructureUnitTestCase.java
projects/microcontainer/trunk/deployers-vfs/src/tests/org/jboss/test/deployers/vfs/structurebuilder/test/VFSStructureBuilderUnitTestCase.java
Log:
Add jira references to all TODOs for the deployers.
Modified: projects/microcontainer/trunk/deployers-client-spi/src/main/org/jboss/deployers/client/spi/IncompleteDeploymentException.java
===================================================================
--- projects/microcontainer/trunk/deployers-client-spi/src/main/org/jboss/deployers/client/spi/IncompleteDeploymentException.java 2007-07-02 16:52:47 UTC (rev 63785)
+++ projects/microcontainer/trunk/deployers-client-spi/src/main/org/jboss/deployers/client/spi/IncompleteDeploymentException.java 2007-07-02 18:34:33 UTC (rev 63786)
@@ -72,7 +72,7 @@
return incompleteDeployments;
}
- // TODO Some of the calculations done in this method should be done upfront in IncompleteDeployments instead!
+ // TODO JBMICROCONT-188 Some of the calculations done in this method should be done upfront in IncompleteDeployments instead!
@Override
public String getMessage()
{
Modified: projects/microcontainer/trunk/deployers-core-spi/src/main/org/jboss/deployers/spi/structure/ClassPathEntry.java
===================================================================
--- projects/microcontainer/trunk/deployers-core-spi/src/main/org/jboss/deployers/spi/structure/ClassPathEntry.java 2007-07-02 16:52:47 UTC (rev 63785)
+++ projects/microcontainer/trunk/deployers-core-spi/src/main/org/jboss/deployers/spi/structure/ClassPathEntry.java 2007-07-02 18:34:33 UTC (rev 63786)
@@ -26,7 +26,7 @@
/**
* A classpath entry.
*
- * TODO other stuff e.g. inclusion/exclusion filters, etc.
+ * TODO JBMICROCONT-182 other stuff e.g. inclusion/exclusion filters, etc.
* @author Scott.Stark at jboss.org
* @author adrian at jboss.org
* @version $Revision: 1.1$
Modified: projects/microcontainer/trunk/deployers-impl/src/main/org/jboss/deployers/plugins/classloading/ClassLoading.java
===================================================================
--- projects/microcontainer/trunk/deployers-impl/src/main/org/jboss/deployers/plugins/classloading/ClassLoading.java 2007-07-02 16:52:47 UTC (rev 63785)
+++ projects/microcontainer/trunk/deployers-impl/src/main/org/jboss/deployers/plugins/classloading/ClassLoading.java 2007-07-02 18:34:33 UTC (rev 63786)
@@ -59,7 +59,7 @@
metadata = new ClassLoaderMetaData();
metadata.setName(deploymentContext.getName());
metadata.setExportAll(ExportAll.NON_EMPTY);
- // TODO default version
+ // TODO JBMICROCONT-182 default version
unit.addAttachment(ClassLoaderMetaData.class, metadata);
}
Modified: projects/microcontainer/trunk/deployers-impl/src/main/org/jboss/deployers/plugins/classloading/Module.java
===================================================================
--- projects/microcontainer/trunk/deployers-impl/src/main/org/jboss/deployers/plugins/classloading/Module.java 2007-07-02 16:52:47 UTC (rev 63785)
+++ projects/microcontainer/trunk/deployers-impl/src/main/org/jboss/deployers/plugins/classloading/Module.java 2007-07-02 18:34:33 UTC (rev 63786)
@@ -165,7 +165,7 @@
*/
public void createDependencies()
{
- // TODO createDependencies
+ // TODO JBMICROCONT-186 createDependencies
}
/**
Modified: projects/microcontainer/trunk/deployers-impl/src/main/org/jboss/deployers/plugins/deployers/DeployersImpl.java
===================================================================
--- projects/microcontainer/trunk/deployers-impl/src/main/org/jboss/deployers/plugins/deployers/DeployersImpl.java 2007-07-02 16:52:47 UTC (rev 63785)
+++ projects/microcontainer/trunk/deployers-impl/src/main/org/jboss/deployers/plugins/deployers/DeployersImpl.java 2007-07-02 18:34:33 UTC (rev 63786)
@@ -378,7 +378,7 @@
{
controller.uninstall(deploymentControllerContext.getName());
context.setState(DeploymentState.UNDEPLOYED);
- // TODO perform with the deployer that created the classloader?
+ // TODO JBMICROCONT-182 perform with the deployer that created the classloader?
context.removeClassLoader();
log.debug("Fully Undeployed " + context.getName());
}
@@ -569,7 +569,7 @@
if (context.isDeployed() == false)
deploymentsMissingDeployer = Collections.singleton(context.getName());
- // TODO go through controller contexts for the deployment + related contexts
+ // TODO JBMICROCONT-187 go through controller contexts for the deployment + related contexts
IncompleteDeployments incomplete = new IncompleteDeployments(deploymentsInError, deploymentsMissingDeployer, contextsInError, contextsMissingDependencies);
if (incomplete.isIncomplete())
Modified: projects/microcontainer/trunk/deployers-impl/src/main/org/jboss/deployers/plugins/main/MainDeployerImpl.java
===================================================================
--- projects/microcontainer/trunk/deployers-impl/src/main/org/jboss/deployers/plugins/main/MainDeployerImpl.java 2007-07-02 16:52:47 UTC (rev 63785)
+++ projects/microcontainer/trunk/deployers-impl/src/main/org/jboss/deployers/plugins/main/MainDeployerImpl.java 2007-07-02 18:34:33 UTC (rev 63786)
@@ -281,7 +281,7 @@
public void deploy(Deployment deployment) throws DeploymentException
{
addDeployment(deployment);
- // TODO just process this deployment
+ // TODO JBMICROCONT-187 just process this deployment
process();
checkComplete(deployment);
}
@@ -297,7 +297,7 @@
public boolean undeploy(String name) throws DeploymentException
{
boolean result = removeDeployment(name);
- // TODO just process this deployment
+ // TODO JBMICROCONT-187 just process this deployment
process();
return result;
}
Modified: projects/microcontainer/trunk/deployers-impl/src/tests/org/jboss/test/deployers/deployer/test/DeployerProtocolUnitTestCase.java
===================================================================
--- projects/microcontainer/trunk/deployers-impl/src/tests/org/jboss/test/deployers/deployer/test/DeployerProtocolUnitTestCase.java 2007-07-02 16:52:47 UTC (rev 63785)
+++ projects/microcontainer/trunk/deployers-impl/src/tests/org/jboss/test/deployers/deployer/test/DeployerProtocolUnitTestCase.java 2007-07-02 18:34:33 UTC (rev 63786)
@@ -64,7 +64,7 @@
assertEquals(expected, deployer.getDeployedUnits());
HashSet<String> types = new HashSet<String>();
types.add("test");
- // TODO types assertEquals(types, context.getTypes());
+ // TODO JBMICROCONT-185 types assertEquals(types, context.getTypes());
}
public void testUndeploy() throws Exception
Modified: projects/microcontainer/trunk/deployers-impl/src/tests/org/jboss/test/deployers/managed/test/DeployerManagedObjectUnitTestCase.java
===================================================================
--- projects/microcontainer/trunk/deployers-impl/src/tests/org/jboss/test/deployers/managed/test/DeployerManagedObjectUnitTestCase.java 2007-07-02 16:52:47 UTC (rev 63785)
+++ projects/microcontainer/trunk/deployers-impl/src/tests/org/jboss/test/deployers/managed/test/DeployerManagedObjectUnitTestCase.java 2007-07-02 18:34:33 UTC (rev 63786)
@@ -82,7 +82,7 @@
mo = mos.get(TestAttachment.class.getName());
assertNotNull(mo);
- // TODO the attachment should NOT be the top level managed object
+ // TODO JBMICROCONT-181 the attachment should NOT be the top level managed object
// that should be describing the structure and deployment state
// with the attachments as sub managed objects
@@ -107,7 +107,7 @@
assertEquals("changedString1", deployer.lastAttachment.getProperty("string1"));
assertEquals("initialString2", deployer.lastAttachment.getProperty("string2"));
- // TODO shouldn't have to reget the managed object handles across redeploys?
+ // TODO JBMICROCONT-181 shouldn't have to reget the managed object handles across redeploys?
mos = main.getManagedObjects(context.getName());
assertNotNull(mos);
mo = mos.get(TestAttachment.class.getName());
Modified: projects/microcontainer/trunk/deployers-spi/src/main/org/jboss/deployers/spi/deployer/managed/ManagedObjectCreator.java
===================================================================
--- projects/microcontainer/trunk/deployers-spi/src/main/org/jboss/deployers/spi/deployer/managed/ManagedObjectCreator.java 2007-07-02 16:52:47 UTC (rev 63785)
+++ projects/microcontainer/trunk/deployers-spi/src/main/org/jboss/deployers/spi/deployer/managed/ManagedObjectCreator.java 2007-07-02 18:34:33 UTC (rev 63786)
@@ -30,7 +30,7 @@
/**
* ManagedObjectCreator.
*
- * TODO Critique
+ * TODO JBMICROCONT-181 Critique
* Rather having the contexts create the managed objects directly
* they should provide the underlying metadata, e.g. the Fields + other information
* from which we can create the managed object.
Modified: projects/microcontainer/trunk/deployers-structure-spi/src/main/org/jboss/deployers/structure/spi/classloading/ClassLoaderMetaData.java
===================================================================
--- projects/microcontainer/trunk/deployers-structure-spi/src/main/org/jboss/deployers/structure/spi/classloading/ClassLoaderMetaData.java 2007-07-02 16:52:47 UTC (rev 63785)
+++ projects/microcontainer/trunk/deployers-structure-spi/src/main/org/jboss/deployers/structure/spi/classloading/ClassLoaderMetaData.java 2007-07-02 18:34:33 UTC (rev 63786)
@@ -27,7 +27,7 @@
/**
* ClassLoaderMetaData.
*
- * TODO needs greatly expanding
+ * TODO JBMICROCONT-182 needs greatly expanding
* @author <a href="adrian at jboss.org">Adrian Brock</a>
* @version $Revision: 1.1 $
*/
Modified: projects/microcontainer/trunk/deployers-vfs/src/main/org/jboss/deployers/vfs/plugins/classloader/VFSClassLoaderPolicy.java
===================================================================
--- projects/microcontainer/trunk/deployers-vfs/src/main/org/jboss/deployers/vfs/plugins/classloader/VFSClassLoaderPolicy.java 2007-07-02 16:52:47 UTC (rev 63785)
+++ projects/microcontainer/trunk/deployers-vfs/src/main/org/jboss/deployers/vfs/plugins/classloader/VFSClassLoaderPolicy.java 2007-07-02 18:34:33 UTC (rev 63786)
@@ -240,7 +240,7 @@
{
VirtualFile root = clazz.getVFS().getRoot();
URL codeSourceURL = root.toURL();
- Certificate[] certs = null; // TODO determine certificates
+ Certificate[] certs = null; // TODO JBMICROCONT-182 determine certificates
CodeSource cs = new CodeSource(codeSourceURL, certs);
PermissionCollection permissions = Policy.getPolicy().getPermissions(cs);
return new ProtectionDomain(cs, permissions);
Modified: projects/microcontainer/trunk/deployers-vfs/src/main/org/jboss/deployers/vfs/plugins/classloader/VFSTopLevelClassLoaderSystemDeployer.java
===================================================================
--- projects/microcontainer/trunk/deployers-vfs/src/main/org/jboss/deployers/vfs/plugins/classloader/VFSTopLevelClassLoaderSystemDeployer.java 2007-07-02 16:52:47 UTC (rev 63785)
+++ projects/microcontainer/trunk/deployers-vfs/src/main/org/jboss/deployers/vfs/plugins/classloader/VFSTopLevelClassLoaderSystemDeployer.java 2007-07-02 18:34:33 UTC (rev 63786)
@@ -45,7 +45,7 @@
Set<VirtualFile> roots = visitor.getClassPath();
VFSClassLoaderPolicy policy = new VFSClassLoaderPolicy(roots.toArray(new VirtualFile[roots.size()]));
policy.setExportAll(module.getExportAll());
- // TODO more policy from "module"
+ // TODO JBMICROCONT-182 more policy from "module"
return policy;
}
Modified: projects/microcontainer/trunk/deployers-vfs/src/tests/org/jboss/test/deployers/vfs/structure/AbstractStructureTest.java
===================================================================
--- projects/microcontainer/trunk/deployers-vfs/src/tests/org/jboss/test/deployers/vfs/structure/AbstractStructureTest.java 2007-07-02 16:52:47 UTC (rev 63785)
+++ projects/microcontainer/trunk/deployers-vfs/src/tests/org/jboss/test/deployers/vfs/structure/AbstractStructureTest.java 2007-07-02 18:34:33 UTC (rev 63786)
@@ -249,7 +249,7 @@
protected VirtualFile getVirtualFile(String root, String path) throws Exception
{
- // TODO THIS IS HACK TO MAKE THE TEST WORK IN MAVEN ???
+ // TODO JBMICROCONT-185 THIS IS HACK TO MAKE THE TEST WORK IN MAVEN ???
try
{
URL.setURLStreamHandlerFactory(new URLStreamHandlerFactory()
Modified: projects/microcontainer/trunk/deployers-vfs/src/tests/org/jboss/test/deployers/vfs/structure/ear/support/MockEarStructureDeployer.java
===================================================================
--- projects/microcontainer/trunk/deployers-vfs/src/tests/org/jboss/test/deployers/vfs/structure/ear/support/MockEarStructureDeployer.java 2007-07-02 16:52:47 UTC (rev 63785)
+++ projects/microcontainer/trunk/deployers-vfs/src/tests/org/jboss/test/deployers/vfs/structure/ear/support/MockEarStructureDeployer.java 2007-07-02 18:34:33 UTC (rev 63786)
@@ -133,7 +133,7 @@
// Add the ear manifest locations?
super.addClassPath(root, file, false, true, context);
- // TODO: need to scan for annotationss
+ // TODO JBMICROCONT-185 need to scan for annotationss
if (scan)
{
throw new RuntimeException("Scanning not implemented: "+file.getName());
Modified: projects/microcontainer/trunk/deployers-vfs/src/tests/org/jboss/test/deployers/vfs/structure/ear/test/EARStructureUnitTestCase.java
===================================================================
--- projects/microcontainer/trunk/deployers-vfs/src/tests/org/jboss/test/deployers/vfs/structure/ear/test/EARStructureUnitTestCase.java 2007-07-02 16:52:47 UTC (rev 63785)
+++ projects/microcontainer/trunk/deployers-vfs/src/tests/org/jboss/test/deployers/vfs/structure/ear/test/EARStructureUnitTestCase.java 2007-07-02 18:34:33 UTC (rev 63786)
@@ -72,7 +72,7 @@
public void testNotAnEAR() throws Throwable
{
- // TODO ??? This gets recognised by the jar deployer assertNotValid("/structure/ear", "notanear");
+ // TODO JBMICROCONT-185 This gets recognised by the jar deployer assertNotValid("/structure/ear", "notanear");
}
/**
Modified: projects/microcontainer/trunk/deployers-vfs/src/tests/org/jboss/test/deployers/vfs/structurebuilder/test/VFSStructureBuilderUnitTestCase.java
===================================================================
--- projects/microcontainer/trunk/deployers-vfs/src/tests/org/jboss/test/deployers/vfs/structurebuilder/test/VFSStructureBuilderUnitTestCase.java 2007-07-02 16:52:47 UTC (rev 63785)
+++ projects/microcontainer/trunk/deployers-vfs/src/tests/org/jboss/test/deployers/vfs/structurebuilder/test/VFSStructureBuilderUnitTestCase.java 2007-07-02 18:34:33 UTC (rev 63786)
@@ -129,7 +129,7 @@
assertNull(classPath);
else
{
- // TODO test it got the correct classpath
+ // TODO JBMICROCONT-185 test it got the correct classpath
}
}
}
More information about the jboss-cvs-commits
mailing list