[jboss-cvs] JBossAS SVN: r61546 - branches/Branch_4_0/messaging/src/main/org/jboss/mq/il/uil2.
jboss-cvs-commits at lists.jboss.org
jboss-cvs-commits at lists.jboss.org
Wed Mar 21 10:23:07 EDT 2007
Author: adrian at jboss.org
Date: 2007-03-21 10:23:07 -0400 (Wed, 21 Mar 2007)
New Revision: 61546
Modified:
branches/Branch_4_0/messaging/src/main/org/jboss/mq/il/uil2/ServerSocketManagerHandler.java
branches/Branch_4_0/messaging/src/main/org/jboss/mq/il/uil2/UILServerILService.java
Log:
Port JBAS-4222 from JBoss-4.2
Modified: branches/Branch_4_0/messaging/src/main/org/jboss/mq/il/uil2/ServerSocketManagerHandler.java
===================================================================
--- branches/Branch_4_0/messaging/src/main/org/jboss/mq/il/uil2/ServerSocketManagerHandler.java 2007-03-21 14:21:50 UTC (rev 61545)
+++ branches/Branch_4_0/messaging/src/main/org/jboss/mq/il/uil2/ServerSocketManagerHandler.java 2007-03-21 14:23:07 UTC (rev 61546)
@@ -55,6 +55,8 @@
import org.jboss.mq.il.uil2.msgs.PingMsg;
import org.jboss.mq.il.Invoker;
+import EDU.oswego.cs.dl.util.concurrent.SynchronizedBoolean;
+
/** This is the SocketManager callback handler for the UIL2 server side
* socket. This handles messages that are requests from clients.
*
@@ -68,13 +70,14 @@
private ConnectionToken connectionToken;
private Invoker server;
private SocketManager socketMgr;
- private boolean closed;
+ private UILServerILService uilServerILService;
+ private SynchronizedBoolean closed = new SynchronizedBoolean(false);
- public ServerSocketManagerHandler(Invoker server, SocketManager socketMgr)
+ public ServerSocketManagerHandler(Invoker server, SocketManager socketMgr, UILServerILService uilServerILService)
{
this.server = server;
this.socketMgr = socketMgr;
- this.closed = false;
+ this.uilServerILService = uilServerILService;
}
/** The callback from the SocketManager
@@ -127,7 +130,7 @@
break;
case m_connectionClosing:
server.connectionClosing(connectionToken);
- closed = true;
+ closed.set(true);
socketMgr.sendReply(msg);
socketMgr.stop();
break;
@@ -257,7 +260,8 @@
{
try
{
- if (closed == false)
+ uilServerILService.removeHandler(this);
+ if (closed.get() == false)
server.connectionClosing(connectionToken);
}
catch (Exception e)
Modified: branches/Branch_4_0/messaging/src/main/org/jboss/mq/il/uil2/UILServerILService.java
===================================================================
--- branches/Branch_4_0/messaging/src/main/org/jboss/mq/il/uil2/UILServerILService.java 2007-03-21 14:21:50 UTC (rev 61545)
+++ branches/Branch_4_0/messaging/src/main/org/jboss/mq/il/uil2/UILServerILService.java 2007-03-21 14:23:07 UTC (rev 61546)
@@ -27,18 +27,23 @@
import java.net.ServerSocket;
import java.net.Socket;
import java.net.UnknownHostException;
+import java.util.Iterator;
import java.util.Properties;
+
import javax.naming.InitialContext;
import javax.net.ServerSocketFactory;
import org.jboss.mq.il.Invoker;
import org.jboss.mq.il.ServerIL;
import org.jboss.mq.il.ServerILJMXService;
+import org.jboss.mq.il.uil2.msgs.BaseMsg;
import org.jboss.mq.il.uil2.msgs.MsgTypes;
-import org.jboss.mq.il.uil2.msgs.BaseMsg;
import org.jboss.security.SecurityDomain;
import org.jboss.system.server.ServerConfigUtil;
+import EDU.oswego.cs.dl.util.concurrent.CopyOnWriteArrayList;
+import EDU.oswego.cs.dl.util.concurrent.SynchronizedBoolean;
+
/** This is the server side MBean for the UIL2 transport layer.
*
* @author Scott.Stark at jboss.org
@@ -64,7 +69,7 @@
*/
private ServerSocket serverSocket;
private UILServerIL serverIL;
- private boolean running;
+ private SynchronizedBoolean running = new SynchronizedBoolean(false);
/** The server jms listening port */
private int serverBindPort = 0;
/** The server jms address the listening socket binds to */
@@ -113,6 +118,9 @@
*/
private Properties connectionProperties;
+ /** The server handlers */
+ private CopyOnWriteArrayList handlers = new CopyOnWriteArrayList();
+
/**
* Used to construct the GenericConnectionFactory (bindJNDIReferences()
* builds it) Sets up the connection properties need by a client to use this
@@ -142,7 +150,7 @@
public void run()
{
boolean trace = log.isTraceEnabled();
- while (running)
+ while (running.get())
{
Socket socket = null;
SocketManager socketMgr = null;
@@ -154,7 +162,8 @@
socket.setSoTimeout(readTimeout);
socket.setTcpNoDelay(enableTcpNoDelay);
socketMgr = new SocketManager(socket);
- ServerSocketManagerHandler handler = new ServerSocketManagerHandler(getJMSServer(), socketMgr);
+ ServerSocketManagerHandler handler = new ServerSocketManagerHandler(getJMSServer(), socketMgr, this);
+ handlers.add(handler);
socketMgr.setHandler(handler);
socketMgr.setBufferSize(bufferSize);
socketMgr.setChunkSize(chunkSize);
@@ -163,12 +172,12 @@
}
catch (IOException e)
{
- if (running)
+ if (running.get())
log.warn("Failed to setup client connection", e);
}
catch(Throwable e)
{
- if (running || trace)
+ if (running.get() || trace)
log.warn("Unexpected error in setup of client connection", e);
}
}
@@ -182,7 +191,6 @@
public void startService() throws Exception
{
super.startService();
- running = true;
// Use the default javax.net.ServerSocketFactory if none was set
if (serverSocketFactory == null)
@@ -219,6 +227,7 @@
InetAddress socketAddress = serverSocket.getInetAddress();
log.info("JBossMQ UIL service available at : " + socketAddress + ":" + serverSocket.getLocalPort());
acceptThread = new Thread(getJMSServer().getThreadGroup(), this, "UILServerILService Accept Thread");
+ running.set(true);
acceptThread.start();
/* We need to check the socketAddress against "0.0.0.0/0.0.0.0"
@@ -256,7 +265,7 @@
{
try
{
- running = false;
+ running.set(false);
unbindJNDIReferences();
// unbind Server Socket if needed
@@ -269,8 +278,29 @@
{
log.error("Exception occured when trying to stop UIL Service: ", e);
}
+
+ // Try to close any open sockets that we know about
+ for (Iterator i = handlers.iterator(); i.hasNext();)
+ {
+ ServerSocketManagerHandler handler = (ServerSocketManagerHandler) i.next();
+ if (handler != null)
+ {
+ try
+ {
+ handler.close();
+ }
+ catch (Throwable ignored)
+ {
+ }
+ }
+ }
}
+ protected void removeHandler(ServerSocketManagerHandler handler)
+ {
+ handlers.remove(handler);
+ }
+
/**
* Get the UIL server listening port
*
More information about the jboss-cvs-commits
mailing list