[jboss-cvs] JBossAS SVN: r61763 - projects/aop/trunk/aop/src/main/org/jboss/aop.

[jboss-cvs-commits at lists.jboss.org]

Author: kabir.khan at jboss.com
Date: 2007-03-27 18:30:58 -0400 (Tue, 27 Mar 2007)
New Revision: 61763

Modified:
   projects/aop/trunk/aop/src/main/org/jboss/aop/ClassAdvisor.java
   projects/aop/trunk/aop/src/main/org/jboss/aop/GeneratedClassAdvisor.java
Log:
[JBAOP-378] Optimization of InstanceAdvisor creation. We do not need to recreate the field tables, just copy them from the parent advisor

Modified: projects/aop/trunk/aop/src/main/org/jboss/aop/ClassAdvisor.java
===================================================================
--- projects/aop/trunk/aop/src/main/org/jboss/aop/ClassAdvisor.java	2007-03-27 21:49:06 UTC (rev 61762)
+++ projects/aop/trunk/aop/src/main/org/jboss/aop/ClassAdvisor.java	2007-03-27 22:30:58 UTC (rev 61763)
@@ -1384,7 +1384,7 @@
    /**
     * Gets advised methods.
     */
-   private void createFieldTable() throws Exception
+   protected void createFieldTable() throws Exception
    {
       ArrayList fields = new ArrayList();
 

Modified: projects/aop/trunk/aop/src/main/org/jboss/aop/GeneratedClassAdvisor.java
===================================================================
--- projects/aop/trunk/aop/src/main/org/jboss/aop/GeneratedClassAdvisor.java	2007-03-27 21:49:06 UTC (rev 61762)
+++ projects/aop/trunk/aop/src/main/org/jboss/aop/GeneratedClassAdvisor.java	2007-03-27 22:30:58 UTC (rev 61763)
@@ -699,7 +699,7 @@
    }
 
    /**
-    * Optimization so that when we create class advisors we don't have to bind the method chains again 
+    * Optimization so that when we create class advisors we don't have to create the method tables again 
     */
    @Override
    protected void createMethodTables() throws Exception
@@ -716,5 +716,21 @@
       }
    }
    
+   /**
+    * Optimization so that when we create class advisors we don't have to create the field tables again 
+    */
+   @Override
+   protected void createFieldTable() throws Exception
+   {
+      GeneratedClassAdvisor parent = getParentAdvisor();
+      if (parent != null)
+      {
+         this.advisedFields = parent.advisedFields;
+      }
+      else
+      {
+         super.createFieldTable();
+      }
+   }
    
 }