[jboss-cvs] JBossAS SVN: r62760 - projects/aop/trunk/aop/src/main/org/jboss/aop/advice/annotation.

[jboss-cvs-commits at lists.jboss.org]

Author: flavia.rainone at jboss.com
Date: 2007-05-02 16:58:12 -0400 (Wed, 02 May 2007)
New Revision: 62760

Modified:
   projects/aop/trunk/aop/src/main/org/jboss/aop/advice/annotation/AnnotatedParameterAdviceInfo.java
Log:
[JBAOP-37] Invalidate advices that should return void and dont' do this.

Modified: projects/aop/trunk/aop/src/main/org/jboss/aop/advice/annotation/AnnotatedParameterAdviceInfo.java
===================================================================
--- projects/aop/trunk/aop/src/main/org/jboss/aop/advice/annotation/AnnotatedParameterAdviceInfo.java	2007-05-02 20:54:21 UTC (rev 62759)
+++ projects/aop/trunk/aop/src/main/org/jboss/aop/advice/annotation/AnnotatedParameterAdviceInfo.java	2007-05-02 20:58:12 UTC (rev 62760)
@@ -97,6 +97,18 @@
                }
                return false;
             }
+            break;
+         case VOID:
+            if (method.getReturnType()!= void.class)
+            {
+               if (AspectManager.verbose)
+               {
+                  AdviceMethodFactory.adviceMatchingMessage.append("\n[warn] - '");
+                  AdviceMethodFactory.adviceMatchingMessage.append(method);
+                  AdviceMethodFactory.adviceMatchingMessage.append("' must return void");
+               }
+               return false;
+            }
       }
       
       for (int i = 0; i < mutuallyExclusive.length; i++)