[jboss-cvs] JBossCache/tests/functional/org/jboss/cache/pojo/jmx ...

[Manik Surtani]

  User: msurtani
  Date: 07/05/23 06:28:54

  Modified:    tests/functional/org/jboss/cache/pojo/jmx  
                        PojoCacheJmxWrapperTest.java
                        PojoCacheJmxWrapperTestBase.java
  Log:
  Initiated a bunch of performance fixes, including replacing CopyOnWriteArraySets with org.jboss.cache.util.concurrent.ConcurrentHashSet.
  Also ran an imports optimiser on the code base - there were a lot of unused imports floating about.
  
  Revision  Changes    Path
  1.4       +45 -41    JBossCache/tests/functional/org/jboss/cache/pojo/jmx/PojoCacheJmxWrapperTest.java
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: PojoCacheJmxWrapperTest.java
  ===================================================================
  RCS file: /cvsroot/jboss/JBossCache/tests/functional/org/jboss/cache/pojo/jmx/PojoCacheJmxWrapperTest.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -b -r1.3 -r1.4
  --- PojoCacheJmxWrapperTest.java	23 May 2007 01:37:03 -0000	1.3
  +++ PojoCacheJmxWrapperTest.java	23 May 2007 10:28:54 -0000	1.4
  @@ -7,8 +7,6 @@
   
   package org.jboss.cache.pojo.jmx;
   
  -import javax.management.ObjectName;
  -
   import org.jboss.cache.AbstractCacheListener;
   import org.jboss.cache.CacheSPI;
   import org.jboss.cache.LifecycleState;
  @@ -17,6 +15,8 @@
   import org.jboss.cache.pojo.PojoCacheException;
   import org.jboss.cache.pojo.test.Person;
   
  +import javax.management.ObjectName;
  +
   /**
    * Tests the PojoCacheJmxWrapper class
    *
  @@ -158,7 +158,9 @@
            wrapper.start();
            fail("Listener did not prevent start");         
         }
  -      catch (PojoCacheException good) {}
  +      catch (PojoCacheException good)
  +      {
  +      }
         
         assertEquals("Correct state", LifecycleState.FAILED, wrapper.getLifecycleState());
         
  @@ -177,7 +179,9 @@
            wrapper.stop();
            fail("Listener did not prevent stop");         
         }
  -      catch (IllegalStateException good) {}
  +      catch (IllegalStateException good)
  +      {
  +      }
         
         assertEquals("Correct state", LifecycleState.FAILED, wrapper.getLifecycleState());
         
  
  
  
  1.2       +32 -29    JBossCache/tests/functional/org/jboss/cache/pojo/jmx/PojoCacheJmxWrapperTestBase.java
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: PojoCacheJmxWrapperTestBase.java
  ===================================================================
  RCS file: /cvsroot/jboss/JBossCache/tests/functional/org/jboss/cache/pojo/jmx/PojoCacheJmxWrapperTestBase.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -b -r1.1 -r1.2
  --- PojoCacheJmxWrapperTestBase.java	11 May 2007 22:44:49 -0000	1.1
  +++ PojoCacheJmxWrapperTestBase.java	23 May 2007 10:28:54 -0000	1.2
  @@ -1,17 +1,16 @@
   package org.jboss.cache.pojo.jmx;
   
  +import junit.framework.TestCase;
  +import org.jboss.cache.config.Configuration;
  +import org.jboss.cache.pojo.PojoCache;
  +import org.jboss.cache.pojo.PojoCacheFactory;
  +
   import javax.management.MBeanServer;
   import javax.management.MBeanServerFactory;
   import javax.management.MBeanServerInvocationHandler;
   import javax.management.MalformedObjectNameException;
   import javax.management.ObjectName;
   
  -import junit.framework.TestCase;
  -
  -import org.jboss.cache.config.Configuration;
  -import org.jboss.cache.pojo.PojoCache;
  -import org.jboss.cache.pojo.PojoCacheFactory;
  -
   /**
    * Tests the JMX wrapper class around a PojoCache.
    *
  @@ -120,7 +119,9 @@
            {
               cache.stop();
            }
  -         catch (Exception ignored) {}
  +         catch (Exception ignored)
  +         {
  +         }
            
            cache = null;
         }
  @@ -131,7 +132,9 @@
               jmxWrapper.stop();
               jmxWrapper.destroy();
            }
  -         catch (Exception ignored) {}
  +         catch (Exception ignored)
  +         {
  +         }
            
            jmxWrapper = null;
         }