[jboss-cvs] JBossAS SVN: r67473 - projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/plugins/authorization.

[jboss-cvs-commits at lists.jboss.org]

Author: anil.saldhana at jboss.com
Date: 2007-11-26 20:42:02 -0500 (Mon, 26 Nov 2007)
New Revision: 67473

Modified:
   projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/plugins/authorization/JBossAuthorizationContext.java
Log:
SECURITY-96: improve AuthorizationContext error report

Modified: projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/plugins/authorization/JBossAuthorizationContext.java
===================================================================
--- projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/plugins/authorization/JBossAuthorizationContext.java	2007-11-27 01:41:05 UTC (rev 67472)
+++ projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/plugins/authorization/JBossAuthorizationContext.java	2007-11-27 01:42:02 UTC (rev 67473)
@@ -191,7 +191,7 @@
             decision = module.authorize(resource);
          }
          catch(Exception ae)
-         {
+         { 
             decision = DENY;
             if(moduleException == null)
                moduleException = new AuthorizationException(ae.getMessage());
@@ -229,10 +229,11 @@
       }
       
       //All the authorization modules have been visited.
+      String msg = getAdditionalErrorMessage(moduleException);
       if(encounteredRequiredError)
-         throw new AuthorizationException("Authorization Failed");
+         throw new AuthorizationException("Authorization Failed:"+ msg);
       if(overallDecision == DENY && encounteredOptionalError)
-         throw new AuthorizationException("Authorization Failed");
+         throw new AuthorizationException("Authorization Failed:" + msg);
       if(overallDecision == DENY)
          throw new AuthorizationException("Authorization Failed:No modules active.");
       return PERMIT;
@@ -271,7 +272,7 @@
       ClassLoader tcl = SecurityActions.getContextClassLoader();
       try
       {
-         Class clazz = tcl.loadClass(name);
+         Class<?> clazz = tcl.loadClass(name);
          am = (AuthorizationModule)clazz.newInstance();
       }
       catch ( Exception e)
@@ -335,4 +336,12 @@
          }
       return ai;
    }
+   
+   private String getAdditionalErrorMessage(Exception e)
+   {
+      StringBuilder msg = new StringBuilder(" ");
+      if(e != null)
+         msg.append(e.getLocalizedMessage());
+      return msg.toString();
+   }
 }
\ No newline at end of file