[jboss-cvs] JBossAS SVN: r65799 - in projects/microcontainer/trunk: kernel/src/main/org/jboss/kernel/plugins/registry/basic and 1 other directories.

[jboss-cvs-commits at lists.jboss.org]

Author: alesj
Date: 2007-10-03 10:55:53 -0400 (Wed, 03 Oct 2007)
New Revision: 65799

Modified:
   projects/microcontainer/trunk/deployers-client-spi/src/main/org/jboss/deployers/client/spi/DeployerClient.java
   projects/microcontainer/trunk/kernel/src/main/org/jboss/kernel/plugins/registry/basic/BasicKernelBus.java
   projects/microcontainer/trunk/managed/src/main/org/jboss/managed/plugins/ManagedComponentImpl.java
Log:
Remove redundant code, javadocs.

Modified: projects/microcontainer/trunk/deployers-client-spi/src/main/org/jboss/deployers/client/spi/DeployerClient.java
===================================================================
--- projects/microcontainer/trunk/deployers-client-spi/src/main/org/jboss/deployers/client/spi/DeployerClient.java	2007-10-03 13:52:54 UTC (rev 65798)
+++ projects/microcontainer/trunk/deployers-client-spi/src/main/org/jboss/deployers/client/spi/DeployerClient.java	2007-10-03 14:55:53 UTC (rev 65799)
@@ -156,9 +156,16 @@
     * 
     * @param name - the name of the top-level DeploymentContext to process.
     * @return the graph of managed objects for the top-level DeploymentContex and its children.
-    * @throws DeploymentException
+    * @throws DeploymentException for any error
     */
    Graph<Map<String, ManagedObject>> getDeepManagedObjects(String name) throws DeploymentException;
 
+   /**
+    * Get the managed deployment.
+    *
+    * @param name the name of the deployment
+    * @return the managed deployment
+    * @throws DeploymentException for any error
+    */
    ManagedDeployment getManagedDeployment(String name) throws DeploymentException;
 }

Modified: projects/microcontainer/trunk/kernel/src/main/org/jboss/kernel/plugins/registry/basic/BasicKernelBus.java
===================================================================
--- projects/microcontainer/trunk/kernel/src/main/org/jboss/kernel/plugins/registry/basic/BasicKernelBus.java	2007-10-03 13:52:54 UTC (rev 65798)
+++ projects/microcontainer/trunk/kernel/src/main/org/jboss/kernel/plugins/registry/basic/BasicKernelBus.java	2007-10-03 14:55:53 UTC (rev 65799)
@@ -56,8 +56,7 @@
    protected <T> Object execute(Object name, Class<T> clazz, Dispatcher<T> dispatcher) throws Throwable
    {
       KernelRegistryEntry entry = registry.getEntry(name);
-      if (entry == null)
-         throw new IllegalArgumentException("No such entry: " + name);
+      // entry is not null by KernelRegistry.getEntry contract
       if (clazz.isAssignableFrom(entry.getClass()) == false)
          throw new IllegalArgumentException("Cannot execute " + dispatcher + " on non " + clazz.getSimpleName() + " entry: " + entry);
       return dispatcher.dispatch(clazz.cast(entry));

Modified: projects/microcontainer/trunk/managed/src/main/org/jboss/managed/plugins/ManagedComponentImpl.java
===================================================================
--- projects/microcontainer/trunk/managed/src/main/org/jboss/managed/plugins/ManagedComponentImpl.java	2007-10-03 13:52:54 UTC (rev 65798)
+++ projects/microcontainer/trunk/managed/src/main/org/jboss/managed/plugins/ManagedComponentImpl.java	2007-10-03 14:55:53 UTC (rev 65799)
@@ -22,15 +22,11 @@
 package org.jboss.managed.plugins;
 
 import java.io.Serializable;
-import java.util.HashSet;
-import java.util.Map;
 
 import org.jboss.managed.api.ComponentType;
 import org.jboss.managed.api.ManagedComponent;
 import org.jboss.managed.api.ManagedDeployment;
 import org.jboss.managed.api.ManagedObject;
-import org.jboss.managed.api.ManagedOperation;
-import org.jboss.managed.api.ManagedProperty;
 
 /**
  * 
@@ -45,8 +41,7 @@
    private ManagedDeployment owner;
    private ComponentType type;
    
-   public ManagedComponentImpl(ComponentType type, ManagedDeployment owner,
-         ManagedObject mo)
+   public ManagedComponentImpl(ComponentType type, ManagedDeployment owner, ManagedObject mo)
    {
       super(mo);
       this.type = type;