[jboss-cvs] JBossAS SVN: r65489 - in trunk: profileservice/src/resources and 1 other directories.

[jboss-cvs-commits at lists.jboss.org]

Author: alesj
Date: 2007-09-20 08:25:57 -0400 (Thu, 20 Sep 2007)
New Revision: 65489

Modified:
   trunk/profileservice/src/main/org/jboss/profileservice/remoting/ProfileServiceInvocationHandler.java
   trunk/profileservice/src/resources/profileservice-beans.xml
   trunk/testsuite/src/main/org/jboss/test/profileservice/test/ProfileServiceUnitTestCase.java
Log:
Simple cleanup.

Modified: trunk/profileservice/src/main/org/jboss/profileservice/remoting/ProfileServiceInvocationHandler.java
===================================================================
--- trunk/profileservice/src/main/org/jboss/profileservice/remoting/ProfileServiceInvocationHandler.java	2007-09-20 11:59:57 UTC (rev 65488)
+++ trunk/profileservice/src/main/org/jboss/profileservice/remoting/ProfileServiceInvocationHandler.java	2007-09-20 12:25:57 UTC (rev 65489)
@@ -24,15 +24,12 @@
 import org.jboss.aop.joinpoint.InvocationResponse;
 import org.jboss.aspects.remoting.AOPRemotingInvocationHandler;
 import org.jboss.deployers.spi.management.ManagementView;
-import org.jboss.logging.Logger;
-import org.jboss.profileservice.management.ManagementViewImpl;
 import org.jboss.remoting.InvocationRequest;
 import org.jboss.remoting.ServerInvocationHandler;
 
 /**
  * The remoting ServerInvocationHandler implementation for the ProfileService.
  * 
- * 
  * @see AOPRemotingInvocationHandler
  * 
  * @author Scott.Stark at jboss.org
@@ -41,28 +38,18 @@
 public class ProfileServiceInvocationHandler extends AOPRemotingInvocationHandler
    implements ServerInvocationHandler
 {
-   private static final Logger log = Logger.getLogger(ProfileServiceInvocationHandler.class);
    private ManagementView mgtViewProxy;
-   private ManagementViewImpl mgtView;
 
    public ManagementView getManagementViewProxy()
    {
       return mgtViewProxy;
    }
+
    public void setManagementViewProxy(ManagementView mgtViewProxy)
    {
       this.mgtViewProxy = mgtViewProxy;
    }
 
-   public ManagementViewImpl getViewManager()
-   {
-      return mgtView;
-   }
-   public void setViewManager(ManagementViewImpl mgtView)
-   {
-      this.mgtView = mgtView;
-   }
-
    public Object invoke(InvocationRequest invocation)
       throws Throwable
    {

Modified: trunk/profileservice/src/resources/profileservice-beans.xml
===================================================================
--- trunk/profileservice/src/resources/profileservice-beans.xml	2007-09-20 11:59:57 UTC (rev 65488)
+++ trunk/profileservice/src/resources/profileservice-beans.xml	2007-09-20 12:25:57 UTC (rev 65489)
@@ -30,7 +30,6 @@
             <parameter>ProfileService</parameter>
         </uninstall>
         <property name="managementViewProxy"><inject bean="ProfileServiceProxyFactory" property="managementViewProxy"/></property>
-        <property name="viewManager"><inject bean="ManagementView"/></property>
     </bean>
 
     <bean name="RuntimeComponentDispatcher" class="org.jboss.profileservice.management.ControllerRuntimeComponentDispatcher">

Modified: trunk/testsuite/src/main/org/jboss/test/profileservice/test/ProfileServiceUnitTestCase.java
===================================================================
--- trunk/testsuite/src/main/org/jboss/test/profileservice/test/ProfileServiceUnitTestCase.java	2007-09-20 11:59:57 UTC (rev 65488)
+++ trunk/testsuite/src/main/org/jboss/test/profileservice/test/ProfileServiceUnitTestCase.java	2007-09-20 12:25:57 UTC (rev 65489)
@@ -344,8 +344,8 @@
       }
       assertNotNull("listFormattedSubPoolStatistics", listFormattedSubPoolStatistics);
       MetaValue[] params = {};
-      // TODO: JBAS-4678 this should not be null
       Object result = listFormattedSubPoolStatistics.invoke(params);
+      assertNotNull("Expecting non null result", result);
       log.info("listFormattedSubPoolStatistics.invoke: "+result);
    }