[jboss-cvs] JBossAS SVN: r72267 - projects/microcontainer/trunk/kernel/src/tests/org/jboss/test/kernel/config/test.

[jboss-cvs-commits at lists.jboss.org]

Author: alesj
Date: 2008-04-16 04:42:18 -0400 (Wed, 16 Apr 2008)
New Revision: 72267

Modified:
   projects/microcontainer/trunk/kernel/src/tests/org/jboss/test/kernel/config/test/AbstractKernelConfigTest.java
Log:
Simple optimization on configuration.

Modified: projects/microcontainer/trunk/kernel/src/tests/org/jboss/test/kernel/config/test/AbstractKernelConfigTest.java
===================================================================
--- projects/microcontainer/trunk/kernel/src/tests/org/jboss/test/kernel/config/test/AbstractKernelConfigTest.java	2008-04-16 07:54:52 UTC (rev 72266)
+++ projects/microcontainer/trunk/kernel/src/tests/org/jboss/test/kernel/config/test/AbstractKernelConfigTest.java	2008-04-16 08:42:18 UTC (rev 72267)
@@ -21,8 +21,6 @@
 */
 package org.jboss.test.kernel.config.test;
 
-import java.util.HashMap;
-import java.util.Map;
 import java.util.Set;
 
 import org.jboss.beans.info.spi.BeanInfo;
@@ -137,32 +135,25 @@
       configure(bean, info, metaData);
    }
 
-   protected static Map<String, ValueMetaData> getPropertyValueMap(BeanMetaData beanMetaData)
+   protected void configure(Object bean, BeanInfo info, BeanMetaData metaData) throws Throwable
    {
-      Map<String, ValueMetaData> map = new HashMap<String, ValueMetaData>();
-      Set<PropertyMetaData> properties = beanMetaData.getProperties();
-      if (properties != null && properties.size() > 0)
+      if (info == null)
+         throw new IllegalArgumentException("Null bean info");
+      if (metaData == null)
+         throw new IllegalArgumentException("Null bean meta data");
+
+      Set<PropertyMetaData> propertys = metaData.getProperties();
+      if (propertys != null && propertys.isEmpty() == false)
       {
-         for (PropertyMetaData prop : properties)
+         for (PropertyMetaData pmd : propertys)
          {
-            map.put(prop.getName(), prop.getValue());
+            PropertyInfo pi = info.getProperty(pmd.getName());
+            ValueMetaData value = pmd.getValue();
+            pi.set(bean, value.getValue(pi.getType(), Configurator.getClassLoader(metaData)));
          }
       }
-      return map;
    }
 
-   protected void configure(Object bean, BeanInfo info, BeanMetaData metaData) throws Throwable
-   {
-      Map<String, ValueMetaData> map = getPropertyValueMap(metaData);
-      Set<PropertyInfo> properties = info.getProperties();
-      for (PropertyInfo pi : properties)
-      {
-         ValueMetaData value = map.get(pi.getName());
-         if (value != null)
-            pi.set(bean, value.getValue(pi.getType(), Configurator.getClassLoader(metaData)));
-      }
-   }
-
    protected void configure(Object bean, BeanInfo info, PropertyMetaData metaData) throws Throwable
    {
       ClassLoader cl = getClass().getClassLoader();