[jboss-cvs] JBossAS SVN: r82083 - projects/jboss-cl/branches/Branch_2_0/classloading/src/main/java/org/jboss/classloading/spi/dependency.

[jboss-cvs-commits at lists.jboss.org]

Author: adrian at jboss.org
Date: 2008-12-05 10:07:51 -0500 (Fri, 05 Dec 2008)
New Revision: 82083

Modified:
   projects/jboss-cl/branches/Branch_2_0/classloading/src/main/java/org/jboss/classloading/spi/dependency/ClassLoadingSpace.java
   projects/jboss-cl/branches/Branch_2_0/classloading/src/main/java/org/jboss/classloading/spi/dependency/RequirementDependencyItem.java
Log:
[JBCL-77] - Only log the warning once

Modified: projects/jboss-cl/branches/Branch_2_0/classloading/src/main/java/org/jboss/classloading/spi/dependency/ClassLoadingSpace.java
===================================================================
--- projects/jboss-cl/branches/Branch_2_0/classloading/src/main/java/org/jboss/classloading/spi/dependency/ClassLoadingSpace.java	2008-12-05 15:07:42 UTC (rev 82082)
+++ projects/jboss-cl/branches/Branch_2_0/classloading/src/main/java/org/jboss/classloading/spi/dependency/ClassLoadingSpace.java	2008-12-05 15:07:51 UTC (rev 82083)
@@ -328,7 +328,8 @@
                   }
                   else
                   {
-                     log.warn(module + " resolved " + dependency.getRequirement() + " to " + otherModule + " which has import-all=true. Cannot check its consistency.");
+                     if (dependency.isResolved())
+                        log.warn(module + " resolved " + dependency.getRequirement() + " to " + otherModule + " which has import-all=true. Cannot check its consistency.");
                   }
                }
             }

Modified: projects/jboss-cl/branches/Branch_2_0/classloading/src/main/java/org/jboss/classloading/spi/dependency/RequirementDependencyItem.java
===================================================================
--- projects/jboss-cl/branches/Branch_2_0/classloading/src/main/java/org/jboss/classloading/spi/dependency/RequirementDependencyItem.java	2008-12-05 15:07:42 UTC (rev 82082)
+++ projects/jboss-cl/branches/Branch_2_0/classloading/src/main/java/org/jboss/classloading/spi/dependency/RequirementDependencyItem.java	2008-12-05 15:07:51 UTC (rev 82083)
@@ -26,6 +26,7 @@
 import org.jboss.dependency.spi.Controller;
 import org.jboss.dependency.spi.ControllerContext;
 import org.jboss.dependency.spi.ControllerState;
+import org.jboss.logging.Logger;
 import org.jboss.util.JBossStringBuilder;
 
 /**
@@ -36,6 +37,9 @@
  */
 public class RequirementDependencyItem extends AbstractDependencyItem
 {
+   /** The log */
+   private static final Logger log = Logger.getLogger(RequirementDependencyItem.class);
+   
    /** The module */
    private Module module;
    
@@ -94,6 +98,8 @@
             setIDependOn(context.getName());
             addDependsOnMe(controller, context);
             setResolved(true);
+            if (module.getClassLoadingSpace() == null)
+               log.warn(getModule() + " resolved " + getRequirement() + " to " + module + " which has import-all=true. Cannot check its consistency.");
          }
          else
          {