[jboss-cvs] JBossAS SVN: r76075 - projects/ejb3/trunk/pool/src/main/java/org/jboss/ejb3/pool/strictmax.

[jboss-cvs-commits at lists.jboss.org]

Author: ALRubinger
Date: 2008-07-21 18:41:47 -0400 (Mon, 21 Jul 2008)
New Revision: 76075

Modified:
   projects/ejb3/trunk/pool/src/main/java/org/jboss/ejb3/pool/strictmax/StrictMaxPool.java
Log:
Concurrency bug, synchronized access to pool on lifecycle stop, document the guard lock required

Modified: projects/ejb3/trunk/pool/src/main/java/org/jboss/ejb3/pool/strictmax/StrictMaxPool.java
===================================================================
--- projects/ejb3/trunk/pool/src/main/java/org/jboss/ejb3/pool/strictmax/StrictMaxPool.java	2008-07-21 22:40:30 UTC (rev 76074)
+++ projects/ejb3/trunk/pool/src/main/java/org/jboss/ejb3/pool/strictmax/StrictMaxPool.java	2008-07-21 22:41:47 UTC (rev 76075)
@@ -108,12 +108,12 @@
 
    public void stop()
    {
-      for(T obj : pool)
-      {
-         factory.destroy(obj);
-      }
       synchronized (pool)
       {
+         for (T obj : pool)
+         {
+            factory.destroy(obj);
+         }
          pool.clear();
       }
    }