[jboss-cvs] JBossAS SVN: r76304 - projects/jboss-cl/trunk/classloading/src/main/org/jboss/classloading/spi/dependency.

[jboss-cvs-commits at lists.jboss.org]

Author: adrian at jboss.org
Date: 2008-07-28 10:54:43 -0400 (Mon, 28 Jul 2008)
New Revision: 76304

Modified:
   projects/jboss-cl/trunk/classloading/src/main/org/jboss/classloading/spi/dependency/ClassLoadingSpace.java
   projects/jboss-cl/trunk/classloading/src/main/org/jboss/classloading/spi/dependency/Domain.java
   projects/jboss-cl/trunk/classloading/src/main/org/jboss/classloading/spi/dependency/Module.java
Log:
JBCL-7 - Split the corner case TODOs into seperate subtasks

Modified: projects/jboss-cl/trunk/classloading/src/main/org/jboss/classloading/spi/dependency/ClassLoadingSpace.java
===================================================================
--- projects/jboss-cl/trunk/classloading/src/main/org/jboss/classloading/spi/dependency/ClassLoadingSpace.java	2008-07-28 14:45:42 UTC (rev 76303)
+++ projects/jboss-cl/trunk/classloading/src/main/org/jboss/classloading/spi/dependency/ClassLoadingSpace.java	2008-07-28 14:54:43 UTC (rev 76304)
@@ -40,7 +40,7 @@
  * unjoin - remove a module from the space
  * unresolve - work out the new state after a module splits
  * 
- * TODO JBCL-7 handle split packages
+ * TODO JBCL-25 handle split packages
  * @author <a href="adrian at jboss.com">Adrian Brock</a>
  * @version $Revision: 1.1 $
  */
@@ -218,7 +218,7 @@
          for (String exportedPackage : exportedPackages)
          {
             Module otherModule = modulesByPackage.get(exportedPackage);
-            // TODO JBCL-7 ERRORS
+            // TODO JBCL-22 ERRORS
             if (otherModule != null)
                throw new IllegalStateException(module + " cannot be added because it is exports package " + exportedPackage + " which conflicts with " + otherModule);
          }
@@ -240,7 +240,7 @@
                   for (RequirementDependencyItem otherDependency : dependencies)
                   {
                      Requirement otherRequirement = otherDependency.getRequirement();
-                     // TODO JBCL-7 ERRORS
+                     // TODO JBCL-22 ERRORS
                      if (requirement.isConsistent(otherRequirement) == false)
                         throw new IllegalStateException(module + " has a requirement " + requirement + " which is inconsistent with " + otherRequirement + " from " + otherModule);
                   }

Modified: projects/jboss-cl/trunk/classloading/src/main/org/jboss/classloading/spi/dependency/Domain.java
===================================================================
--- projects/jboss-cl/trunk/classloading/src/main/org/jboss/classloading/spi/dependency/Domain.java	2008-07-28 14:45:42 UTC (rev 76303)
+++ projects/jboss-cl/trunk/classloading/src/main/org/jboss/classloading/spi/dependency/Domain.java	2008-07-28 14:54:43 UTC (rev 76304)
@@ -232,7 +232,7 @@
             return result;
       }
       
-      // TODO JBCL-7 check for self-dependency/circularity
+      // TODO JBCL-24 check for self-dependency/circularity
       for (Module other : modules)
       {
          List<Capability> capabilities = other.getCapabilities();

Modified: projects/jboss-cl/trunk/classloading/src/main/org/jboss/classloading/spi/dependency/Module.java
===================================================================
--- projects/jboss-cl/trunk/classloading/src/main/org/jboss/classloading/spi/dependency/Module.java	2008-07-28 14:45:42 UTC (rev 76303)
+++ projects/jboss-cl/trunk/classloading/src/main/org/jboss/classloading/spi/dependency/Module.java	2008-07-28 14:54:43 UTC (rev 76304)
@@ -532,7 +532,7 @@
    /**
     * Determine the package names
     * 
-    * TODO JBCL-7 Better handling of conflicts for optional packages
+    * TODO JBCL-23 Better handling of conflicts for optional packages
     * @param optional whether to include optional packages
     * @return the package names
     */