[jboss-cvs] JBossAS SVN: r74298 - in projects/jboss-man/trunk/managed/src: tests/org/jboss/test/managed/factory/support and 1 other directories.

[jboss-cvs-commits at lists.jboss.org]

Author: scott.stark at jboss.org
Date: 2008-06-08 19:29:47 -0400 (Sun, 08 Jun 2008)
New Revision: 74298

Added:
   projects/jboss-man/trunk/managed/src/tests/org/jboss/test/managed/factory/support/WriteOnlyPropertyObject.java
Modified:
   projects/jboss-man/trunk/managed/src/main/org/jboss/managed/plugins/factory/AbstractManagedObjectFactory.java
   projects/jboss-man/trunk/managed/src/tests/org/jboss/test/managed/factory/test/ManagementObjectPropertiesUnitTestCase.java
Log:
JBMAN-15, don't let failure to read a property fail ManagedObject/ManagedProperty creation.

Modified: projects/jboss-man/trunk/managed/src/main/org/jboss/managed/plugins/factory/AbstractManagedObjectFactory.java
===================================================================
--- projects/jboss-man/trunk/managed/src/main/org/jboss/managed/plugins/factory/AbstractManagedObjectFactory.java	2008-06-08 22:36:59 UTC (rev 74297)
+++ projects/jboss-man/trunk/managed/src/main/org/jboss/managed/plugins/factory/AbstractManagedObjectFactory.java	2008-06-08 23:29:47 UTC (rev 74298)
@@ -601,7 +601,17 @@
       {
          for (ManagedProperty property : properties.values())
          {
-            MetaValue value = icf.getValue(beanInfo, property, object);
+            MetaValue value = null;
+            try
+            {
+               value = icf.getValue(beanInfo, property, object);
+            }
+            catch(Throwable t)
+            {
+               if(log.isTraceEnabled())
+                  log.trace("Failed to access value for property: "+property);
+            }
+
             if (value != null)
                property.setField(Fields.VALUE, value);
             /* Need to look for a ManagementObjectID at the property level which

Added: projects/jboss-man/trunk/managed/src/tests/org/jboss/test/managed/factory/support/WriteOnlyPropertyObject.java
===================================================================
--- projects/jboss-man/trunk/managed/src/tests/org/jboss/test/managed/factory/support/WriteOnlyPropertyObject.java	                        (rev 0)
+++ projects/jboss-man/trunk/managed/src/tests/org/jboss/test/managed/factory/support/WriteOnlyPropertyObject.java	2008-06-08 23:29:47 UTC (rev 74298)
@@ -0,0 +1,47 @@
+/*
+* JBoss, Home of Professional Open Source
+* Copyright 2008, JBoss Inc., and individual contributors as indicated
+* by the @authors tag. See the copyright.txt in the distribution for a
+* full listing of individual contributors.
+*
+* This is free software; you can redistribute it and/or modify it
+* under the terms of the GNU Lesser General Public License as
+* published by the Free Software Foundation; either version 2.1 of
+* the License, or (at your option) any later version.
+*
+* This software is distributed in the hope that it will be useful,
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+* Lesser General Public License for more details.
+*
+* You should have received a copy of the GNU Lesser General Public
+* License along with this software; if not, write to the Free
+* Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+* 02110-1301 USA, or see the FSF site: http://www.fsf.org.
+*/
+package org.jboss.test.managed.factory.support;
+
+import java.io.Serializable;
+
+import javax.management.MBeanServer;
+
+import org.jboss.managed.api.annotation.ManagementObject;
+import org.jboss.managed.api.annotation.ManagementProperty;
+
+/**
+ * A managed object with a write-only property
+ * @author Scott.Stark at jboss.org
+ * @version $Revision:$
+ */
+ at ManagementObject
+public class WriteOnlyPropertyObject implements Serializable
+{
+   private static final long serialVersionUID = 1L;
+   private MBeanServer server;
+
+   @ManagementProperty(mandatory=true)
+   public void setServerProperty(MBeanServer server) 
+   {
+      this.server = server;
+   }
+}

Modified: projects/jboss-man/trunk/managed/src/tests/org/jboss/test/managed/factory/test/ManagementObjectPropertiesUnitTestCase.java
===================================================================
--- projects/jboss-man/trunk/managed/src/tests/org/jboss/test/managed/factory/test/ManagementObjectPropertiesUnitTestCase.java	2008-06-08 22:36:59 UTC (rev 74297)
+++ projects/jboss-man/trunk/managed/src/tests/org/jboss/test/managed/factory/test/ManagementObjectPropertiesUnitTestCase.java	2008-06-08 23:29:47 UTC (rev 74298)
@@ -24,11 +24,13 @@
 import junit.framework.Test;
 
 import org.jboss.managed.api.ManagedObject;
+import org.jboss.managed.api.ManagedProperty;
 import org.jboss.test.managed.factory.AbstractManagedObjectFactoryTest;
 import org.jboss.test.managed.factory.support.ManagementObjectAll;
 import org.jboss.test.managed.factory.support.ManagementObjectExplicit;
 import org.jboss.test.managed.factory.support.ManagementObjectIgnored;
 import org.jboss.test.managed.factory.support.ManagementObjectNone;
+import org.jboss.test.managed.factory.support.WriteOnlyPropertyObject;
 
 /**
  * ManagementObjectPropertiesUnitTestCase.
@@ -97,4 +99,16 @@
       checkManagedObjectDefaults(ManagementObjectExplicit.class, managedObject);
       checkManagedProperties(managedObject, "property1");
    }
-}
\ No newline at end of file
+
+   /**
+    * Validate that a write-only property does not fail the creation of
+    * a ManagedObject/ManagedProperty.
+    */
+   public void testWriteOnlyProperty()
+   {
+      ManagedObject managedObject = createManagedObject(WriteOnlyPropertyObject.class);
+      ManagedProperty serverProperty = managedObject.getProperty("serverProperty");
+      assertNotNull(serverProperty);
+      log.info(serverProperty);
+   }
+}