[jboss-cvs] JBossAS SVN: r74430 - trunk/cluster/src/main/org/jboss/ha/framework/server.

[jboss-cvs-commits at lists.jboss.org]

Author: pferraro
Date: 2008-06-11 18:08:25 -0400 (Wed, 11 Jun 2008)
New Revision: 74430

Modified:
   trunk/cluster/src/main/org/jboss/ha/framework/server/ClusterPartition.java
Log:
[JBAS-5509] Remove support for passing null types to HAPartition.callMethodOnCluster
Problematic methods were actually callMethodOnNode and callAsyncMethodOnNode.

Modified: trunk/cluster/src/main/org/jboss/ha/framework/server/ClusterPartition.java
===================================================================
--- trunk/cluster/src/main/org/jboss/ha/framework/server/ClusterPartition.java	2008-06-11 22:00:26 UTC (rev 74429)
+++ trunk/cluster/src/main/org/jboss/ha/framework/server/ClusterPartition.java	2008-06-11 22:08:25 UTC (rev 74430)
@@ -1053,12 +1053,10 @@
        if (!(targetNode instanceof ClusterNodeImpl))
           throw new IllegalArgumentException("targetNode " + targetNode + " is not an instance of " + 
                                           ClusterNodeImpl.class + " -- only targetNodes provided by this HAPartition should be used");
-       MethodCall m;
        boolean trace = this.log.isTraceEnabled();
-       if(types != null)
-          m=new MethodCall(serviceName + "." + methodName, args, types);
-       else
-          m=new MethodCall(serviceName + "." + methodName, args);
+       
+       MethodCall m = new MethodCall(serviceName + "." + methodName, args, types);
+
        if( trace )
        {
           this.log.trace("callMethodOnNode( objName="+serviceName
@@ -1112,12 +1110,10 @@
       if (!(targetNode instanceof ClusterNodeImpl))
          throw new IllegalArgumentException("targetNode " + targetNode + " is not an instance of " + 
                                          ClusterNodeImpl.class + " -- only targetNodes provided by this HAPartition should be used");
-      MethodCall m;
        boolean trace = this.log.isTraceEnabled();
-       if(types != null)
-          m=new MethodCall(serviceName + "." + methodName, args, types);
-       else
-          m=new MethodCall(serviceName + "." + methodName, args);
+
+       MethodCall m = new MethodCall(serviceName + "." + methodName, args, types);
+
        if( trace )
        {
           this.log.trace("callAsyncMethodOnNode( objName="+serviceName