[jboss-cvs] Re: jboss-cvs-commits Digest, Vol 24, Issue 581

[Ales Justin]

Why not making COMPARATOR also static then? ;-)

> ------------------------------
> 
> Message: 6
> Date: Thu, 26 Jun 2008 10:38:17 -0400
> From: jboss-cvs-commits at lists.jboss.org
> Subject: [jboss-cvs] JBossAS SVN: r75124 -
> 	projects/jboss-deployers/trunk/deployers-core-spi/src/main/org/jboss/deployers/spi.
> 	
> To: jboss-cvs-commits at lists.jboss.org
> Message-ID: <E1KBsc5-0007Pu-UG at committer01.frg.pub.inap.atl.jboss.com>
> Content-Type: text/plain; charset=UTF-8
> 
> Author: richard.opalka at jboss.com
> Date: 2008-06-26 10:38:17 -0400 (Thu, 26 Jun 2008)
> New Revision: 75124
> 
> Modified:
>    projects/jboss-deployers/trunk/deployers-core-spi/src/main/org/jboss/deployers/spi/Ordered.java
> Log:
> protect against field hacking attempts + fix memory vasting
> 
> Modified: projects/jboss-deployers/trunk/deployers-core-spi/src/main/org/jboss/deployers/spi/Ordered.java
> ===================================================================
> --- projects/jboss-deployers/trunk/deployers-core-spi/src/main/org/jboss/deployers/spi/Ordered.java	2008-06-26 14:38:15 UTC (rev 75123)
> +++ projects/jboss-deployers/trunk/deployers-core-spi/src/main/org/jboss/deployers/spi/Ordered.java	2008-06-26 14:38:17 UTC (rev 75124)
> @@ -45,15 +45,17 @@
>      * 
>      * @param order the order
>      */
> -   public void setRelativeOrder(int order);
> +   void setRelativeOrder(int order);
>  
> -   /** The comparator for relative ordering of deployers */
> -   Comparator<Ordered> COMPARATOR = new OrderedComparator();
> +   /** 
> +    * The comparator for relative ordering of deployers
> +    */
> +   final Comparator<Ordered> COMPARATOR = new OrderedComparator();
>     
>     /**
>      * The comparator for relative ordering
>      */
> -   public class OrderedComparator implements Comparator<Ordered>
> +   static class OrderedComparator implements Comparator<Ordered>
>     {
>        public int compare(Ordered o1, Ordered o2)
>        {