[jboss-cvs] JBossAS SVN: r80423 - projects/security/security-jboss-sx/trunk/jbosssx/src/main/java/org/jboss/security.

[jboss-cvs-commits at lists.jboss.org]

Author: anil.saldhana at jboss.com
Date: 2008-11-03 23:02:49 -0500 (Mon, 03 Nov 2008)
New Revision: 80423

Modified:
   projects/security/security-jboss-sx/trunk/jbosssx/src/main/java/org/jboss/security/Util.java
Log:
SECURITY-311: close the streams in finally

Modified: projects/security/security-jboss-sx/trunk/jbosssx/src/main/java/org/jboss/security/Util.java
===================================================================
--- projects/security/security-jboss-sx/trunk/jbosssx/src/main/java/org/jboss/security/Util.java	2008-11-04 04:01:04 UTC (rev 80422)
+++ projects/security/security-jboss-sx/trunk/jbosssx/src/main/java/org/jboss/security/Util.java	2008-11-04 04:02:49 UTC (rev 80423)
@@ -224,10 +224,23 @@
          {
             Runtime rt = Runtime.getRuntime();
             Process p = rt.exec(cmd);
-            InputStream stdin = p.getInputStream();
-            BufferedReader reader = new BufferedReader(new InputStreamReader(stdin));
-            String line = reader.readLine();
-            stdin.close();
+            InputStream stdin = null;
+            String line;
+            BufferedReader reader = null;
+            try
+            {
+               stdin = p.getInputStream();
+               reader = new BufferedReader(new InputStreamReader(stdin));
+               line = reader.readLine();   
+            }
+            finally
+            {
+               if(reader != null)
+                  reader.close();
+               if(stdin != null)
+                 stdin.close();   
+            }
+            
             int exitCode = p.waitFor();
             log.debug("Command exited with: "+exitCode);
             return line;