[jboss-cvs] JBossAS SVN: r80450 - in projects/security/security-spi/trunk: spi/src/main/org/jboss/security/javaee and 1 other directory.

[jboss-cvs-commits at lists.jboss.org]

Author: anil.saldhana at jboss.com
Date: 2008-11-03 23:48:25 -0500 (Mon, 03 Nov 2008)
New Revision: 80450

Modified:
   projects/security/security-spi/trunk/identity/src/main/org/jboss/security/identity/RoleFactory.java
   projects/security/security-spi/trunk/spi/src/main/org/jboss/security/javaee/SecurityHelperFactory.java
Log:
SECURITY-317: public static fields should be private

Modified: projects/security/security-spi/trunk/identity/src/main/org/jboss/security/identity/RoleFactory.java
===================================================================
--- projects/security/security-spi/trunk/identity/src/main/org/jboss/security/identity/RoleFactory.java	2008-11-04 04:29:15 UTC (rev 80449)
+++ projects/security/security-spi/trunk/identity/src/main/org/jboss/security/identity/RoleFactory.java	2008-11-04 04:48:25 UTC (rev 80450)
@@ -25,9 +25,7 @@
 import java.security.AccessController;
 import java.security.PrivilegedActionException;
 import java.security.PrivilegedExceptionAction;
-
-//$Id$
-
+ 
 /**
  *  Factory to create roles
  *  @author Anil.Saldhana at redhat.com
@@ -36,8 +34,8 @@
  */
 public class RoleFactory
 {
-   public static String SIMPLE_ROLE_CLASS = "org.jboss.security.identity.plugins.SimpleRole";
-   public static String SIMPLE_ROLEGROUP_CLASS = "org.jboss.security.identity.plugins.SimpleRoleGroup";
+   private static String SIMPLE_ROLE_CLASS = "org.jboss.security.identity.plugins.SimpleRole";
+   private static String SIMPLE_ROLEGROUP_CLASS = "org.jboss.security.identity.plugins.SimpleRoleGroup";
    
    public static Role createRole(final String name) throws PrivilegedActionException
    {
@@ -66,4 +64,14 @@
       }  
      });  
    } 
+   
+   public static void setSimpleRoleClass(String fqn)
+   {
+      SIMPLE_ROLE_CLASS = fqn;
+   }
+   
+   public static void setSimpleRoleGroupClass(String fqn)
+   {
+      SIMPLE_ROLEGROUP_CLASS = fqn;
+   }
 }

Modified: projects/security/security-spi/trunk/spi/src/main/org/jboss/security/javaee/SecurityHelperFactory.java
===================================================================
--- projects/security/security-spi/trunk/spi/src/main/org/jboss/security/javaee/SecurityHelperFactory.java	2008-11-04 04:29:15 UTC (rev 80449)
+++ projects/security/security-spi/trunk/spi/src/main/org/jboss/security/javaee/SecurityHelperFactory.java	2008-11-04 04:48:25 UTC (rev 80450)
@@ -31,17 +31,28 @@
  */
 public class SecurityHelperFactory
 {
-   public static String WebAuthorizationHelperClass = 
+   private static String WebAuthorizationHelperClass = 
                "org.jboss.security.plugins.javaee.WebAuthorizationHelper";
    
-   public static String EjbAuthorizationHelperClass = 
+   private static String EjbAuthorizationHelperClass = 
       "org.jboss.security.plugins.javaee.EJBAuthorizationHelper";
 
+   /**
+    * Get the EJB Authentication Helper given a security context
+    * @param sc
+    * @return
+    */
    public static EJBAuthenticationHelper getEJBAuthenticationHelper(SecurityContext sc)
    {
      return new EJBAuthenticationHelper(sc); 
    }
    
+   /**
+    * Get the Web Authorization Helper given a security context
+    * @param sc
+    * @return
+    * @throws Exception
+    */
    public static AbstractWebAuthorizationHelper getWebAuthorizationHelper(SecurityContext sc) 
    throws Exception
    {
@@ -51,6 +62,12 @@
       return awh;
    }
    
+   /**
+    * Get the EJB Authorization Helper given a security context
+    * @param sc
+    * @return
+    * @throws Exception
+    */
    public static AbstractEJBAuthorizationHelper getEJBAuthorizationHelper(SecurityContext sc) 
    throws Exception
    {
@@ -59,4 +76,22 @@
       awh.setSecurityContext(sc);
       return awh;
    }
+   
+   /**
+    * Set the FQN of the ejb authorization helper class
+    * @param fqn
+    */
+   public static void setEJBAuthorizationHelperClass(String fqn)
+   {
+      EjbAuthorizationHelperClass = fqn;
+   }
+   
+   /**
+    * Set the FQN of the web authorization helper class
+    * @param fqn
+    */
+   public static void setWebAuthorizationHelperClass(String fqn)
+   {
+      WebAuthorizationHelperClass = fqn;
+   }
 }
\ No newline at end of file