[jboss-cvs] JBossAS SVN: r81328 - in projects/jboss-man/branches/Branch_2_0/metatype/src: test/java/org/jboss/test/metatype/values/factory/test and 1 other directory.

[jboss-cvs-commits at lists.jboss.org]

Author: scott.stark at jboss.org
Date: 2008-11-19 17:10:45 -0500 (Wed, 19 Nov 2008)
New Revision: 81328

Modified:
   projects/jboss-man/branches/Branch_2_0/metatype/src/main/java/org/jboss/metatype/plugins/values/DefaultMetaValueFactory.java
   projects/jboss-man/branches/Branch_2_0/metatype/src/test/java/org/jboss/test/metatype/values/factory/test/UnwrapValueUnitTestCase.java
Log:
JBMAN-38, logging

Modified: projects/jboss-man/branches/Branch_2_0/metatype/src/main/java/org/jboss/metatype/plugins/values/DefaultMetaValueFactory.java
===================================================================
--- projects/jboss-man/branches/Branch_2_0/metatype/src/main/java/org/jboss/metatype/plugins/values/DefaultMetaValueFactory.java	2008-11-19 22:09:20 UTC (rev 81327)
+++ projects/jboss-man/branches/Branch_2_0/metatype/src/main/java/org/jboss/metatype/plugins/values/DefaultMetaValueFactory.java	2008-11-19 22:10:45 UTC (rev 81328)
@@ -45,6 +45,7 @@
 import org.jboss.beans.info.spi.PropertyInfo;
 import org.jboss.config.plugins.property.PropertyConfiguration;
 import org.jboss.config.spi.Configuration;
+import org.jboss.logging.Logger;
 import org.jboss.metatype.api.types.ArrayMetaType;
 import org.jboss.metatype.api.types.CollectionMetaType;
 import org.jboss.metatype.api.types.CompositeMetaType;
@@ -87,10 +88,12 @@
  * 
  * @author <a href="ales.justin at jboss.com">Ales Justin</a>
  * @author <a href="adrian at jboss.com">Adrian Brock</a>
- * @version $Revision: 1.1 $
+ * @version $Revision$
  */
 public class DefaultMetaValueFactory extends MetaValueFactory
 {
+   private static final Logger log = Logger.getLogger(DefaultMetaValueFactory.class);
+
    /** The metatype factory */
    private MetaTypeFactory metaTypeFactory = MetaTypeFactory.getInstance();
    
@@ -745,8 +748,11 @@
    @SuppressWarnings("unchecked")
    protected Object unwrapCollection(CollectionValue collectionValue, TypeInfo type)
    {
+      boolean trace = log.isTraceEnabled();
       try
       {
+         if (trace)
+            log.trace("unwrapCollection, type: "+type);
          BeanInfo collectionInfo;
          // null is not instance of
          if (type instanceof ClassInfo)
@@ -765,9 +771,17 @@
          {
             MetaValue metaValue = iter.next();
             TypeInfo componentType = classInfo.getComponentType();
+            if (trace)
+               log.trace("unwrapCollection, componentType: "+componentType);
             // try better
             if (OBJECT_TYPE_INFO.equals(componentType))
+            {
+               if (trace)
+                  log.trace("unwrapCollection, value.metaType: "+metaValue.getMetaType());
                componentType = getTypeInfo(metaValue.getMetaType(), null);
+               if (trace)
+                  log.trace("unwrapCollection, componentType#2: "+componentType);
+            }
             collection.add(unwrap(metaValue, componentType));
          }
          return collection;
@@ -1030,6 +1044,10 @@
       }
       catch (Throwable t)
       {
+         log.debug("convertValue failure("+t.getMessage()+"), value="+value.toString()
+               + ", value.class: "+value.getClass().getName()
+               + ", typeInfo: "+typeInfo.toString()
+               );
          throw new UndeclaredThrowableException(t);
       }
    }


Property changes on: projects/jboss-man/branches/Branch_2_0/metatype/src/main/java/org/jboss/metatype/plugins/values/DefaultMetaValueFactory.java
___________________________________________________________________
Name: svn:keywords
   + Id Revision

Modified: projects/jboss-man/branches/Branch_2_0/metatype/src/test/java/org/jboss/test/metatype/values/factory/test/UnwrapValueUnitTestCase.java
===================================================================
--- projects/jboss-man/branches/Branch_2_0/metatype/src/test/java/org/jboss/test/metatype/values/factory/test/UnwrapValueUnitTestCase.java	2008-11-19 22:09:20 UTC (rev 81327)
+++ projects/jboss-man/branches/Branch_2_0/metatype/src/test/java/org/jboss/test/metatype/values/factory/test/UnwrapValueUnitTestCase.java	2008-11-19 22:10:45 UTC (rev 81328)
@@ -350,8 +350,11 @@
    @SuppressWarnings("unchecked")
    protected Type getType(String type, Class<? extends Collection> clazz) throws Exception
    {
-      Method method = getClass().getDeclaredMethod("get" + type + "s" + clazz.getSimpleName());
-      return method.getGenericReturnType();
+      String methodName = "get" + type + "s" + clazz.getSimpleName();
+      Method method = getClass().getDeclaredMethod(methodName);
+      Type gtype = method.getGenericReturnType();
+      getLog().debug("getType(type="+type+", clazz="+clazz+" : "+gtype);
+      return gtype;
    }
 
    public List<Integer> getIntegersList()