[jboss-cvs] JBossAS SVN: r81447 - projects/aop/branches/Branch_2_0/asintegration-mc/src/main/org/jboss/aop/asintegration/jboss5.

[jboss-cvs-commits at lists.jboss.org]

Author: flavia.rainone at jboss.com
Date: 2008-11-21 12:22:47 -0500 (Fri, 21 Nov 2008)
New Revision: 81447

Added:
   projects/aop/branches/Branch_2_0/asintegration-mc/src/main/org/jboss/aop/asintegration/jboss5/SecurityActions.java
Modified:
   projects/aop/branches/Branch_2_0/asintegration-mc/src/main/org/jboss/aop/asintegration/jboss5/VFSClassLoaderDomainRegistry.java
Log:
[JBAOP-677] The bug is fixed (ClassLoader.getParent call is now inside a privileged action through a SecurityActions call)

Added: projects/aop/branches/Branch_2_0/asintegration-mc/src/main/org/jboss/aop/asintegration/jboss5/SecurityActions.java
===================================================================
--- projects/aop/branches/Branch_2_0/asintegration-mc/src/main/org/jboss/aop/asintegration/jboss5/SecurityActions.java	                        (rev 0)
+++ projects/aop/branches/Branch_2_0/asintegration-mc/src/main/org/jboss/aop/asintegration/jboss5/SecurityActions.java	2008-11-21 17:22:47 UTC (rev 81447)
@@ -0,0 +1,80 @@
+/*
+* JBoss, Home of Professional Open Source.
+* Copyright 2006, Red Hat Middleware LLC, and individual contributors
+* as indicated by the @author tags. See the copyright.txt file in the
+* distribution for a full listing of individual contributors. 
+*
+* This is free software; you can redistribute it and/or modify it
+* under the terms of the GNU Lesser General Public License as
+* published by the Free Software Foundation; either version 2.1 of
+* the License, or (at your option) any later version.
+*
+* This software is distributed in the hope that it will be useful,
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+* Lesser General Public License for more details.
+*
+* You should have received a copy of the GNU Lesser General Public
+* License along with this software; if not, write to the Free
+* Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+* 02110-1301 USA, or see the FSF site: http://www.fsf.org.
+*/ 
+package org.jboss.aop.asintegration.jboss5;
+
+import java.security.AccessController;
+import java.security.PrivilegedActionException;
+import java.security.PrivilegedExceptionAction;
+
+/**
+ * 
+ * @author <a href="kabir.khan at jboss.com">Kabir Khan</a>
+ * @version $Revision: 1.1 $
+ */
+class SecurityActions
+{
+   interface GetParentAction
+   {
+      ClassLoader getParent(ClassLoader loader);
+      
+      GetParentAction NON_PRIVILEGED = new GetParentAction()
+      {
+         public ClassLoader getParent(ClassLoader loader)
+         {
+            return loader.getParent();
+         }
+      };
+      
+      GetParentAction PRIVILEGED = new GetParentAction()
+      {
+         public ClassLoader getParent(final ClassLoader loader)
+         {
+            try
+            {
+               return AccessController.doPrivileged(new PrivilegedExceptionAction<ClassLoader>()
+               {
+                  public ClassLoader run() throws Exception
+                  {
+                     return loader.getParent();
+                  }
+               });
+            }
+            catch (PrivilegedActionException e)
+            {
+               throw new RuntimeException(e.getException());
+            }
+         }
+      };
+   }
+
+   public static ClassLoader getParent(ClassLoader loader)
+   {
+      if (System.getSecurityManager() == null)
+      {
+         return GetParentAction.NON_PRIVILEGED.getParent(loader);
+      }
+      else
+      {
+         return GetParentAction.PRIVILEGED.getParent(loader);
+      }
+   }
+}

Modified: projects/aop/branches/Branch_2_0/asintegration-mc/src/main/org/jboss/aop/asintegration/jboss5/VFSClassLoaderDomainRegistry.java
===================================================================
--- projects/aop/branches/Branch_2_0/asintegration-mc/src/main/org/jboss/aop/asintegration/jboss5/VFSClassLoaderDomainRegistry.java	2008-11-21 17:07:59 UTC (rev 81446)
+++ projects/aop/branches/Branch_2_0/asintegration-mc/src/main/org/jboss/aop/asintegration/jboss5/VFSClassLoaderDomainRegistry.java	2008-11-21 17:22:47 UTC (rev 81447)
@@ -128,7 +128,7 @@
          return clDomainRef.get();
       }
       
-      ClassLoader parent = cl.getParent();
+      ClassLoader parent = SecurityActions.getParent(cl);
       if (parent != null)
       {
          ClassLoaderDomain domain = getClassLoaderDomainForLoader(parent);