[jboss-cvs] JBossAS SVN: r81740 - trunk/server/src/main/org/jboss/deployment.

[jboss-cvs-commits at lists.jboss.org]

Author: adrian at jboss.org
Date: 2008-11-27 11:31:47 -0500 (Thu, 27 Nov 2008)
New Revision: 81740

Modified:
   trunk/server/src/main/org/jboss/deployment/FileNameVirtualFileFilter.java
Log:
Fix a classic example of how NOT to use log.isTraceEnabled()

Modified: trunk/server/src/main/org/jboss/deployment/FileNameVirtualFileFilter.java
===================================================================
--- trunk/server/src/main/org/jboss/deployment/FileNameVirtualFileFilter.java	2008-11-27 16:26:55 UTC (rev 81739)
+++ trunk/server/src/main/org/jboss/deployment/FileNameVirtualFileFilter.java	2008-11-27 16:31:47 UTC (rev 81740)
@@ -58,6 +58,8 @@
     */
    public boolean accepts(VirtualFile file)
    {
+      boolean trace = log.isTraceEnabled();
+      
       String pathName = file.getPathName();
       for (Map.Entry<String, Set<String>> entry : excludes.entrySet())
       {
@@ -68,7 +70,7 @@
             Set<String> value = entry.getValue();
             if (value == null || value.contains(simpleName))
             {
-               if (log.isTraceEnabled())
+               if (trace)
                   log.trace("Excluding " + pathName);
                
                return false;