[jboss-cvs] JBossAS SVN: r79395 - in projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss: security/auth/spi and 1 other directories.

[jboss-cvs-commits at lists.jboss.org]

Author: mmoyses
Date: 2008-10-13 10:29:36 -0400 (Mon, 13 Oct 2008)
New Revision: 79395

Modified:
   projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/resource/security/AbstractPasswordCredentialLoginModule.java
   projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/auth/spi/LdapExtLoginModule.java
   projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/auth/spi/LdapLoginModule.java
   projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/plugins/javaee/EJBAuthorizationHelper.java
   projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/plugins/javaee/WebAuthorizationHelper.java
Log:
SECURITY-281: include exception in trace and error level logging.

Modified: projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/resource/security/AbstractPasswordCredentialLoginModule.java
===================================================================
--- projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/resource/security/AbstractPasswordCredentialLoginModule.java	2008-10-13 14:25:26 UTC (rev 79394)
+++ projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/resource/security/AbstractPasswordCredentialLoginModule.java	2008-10-13 14:29:36 UTC (rev 79395)
@@ -123,7 +123,7 @@
          {
             log.error("The ConnectionManager mbean: " + managedConnectionFactoryName
                + " specified in a ConfiguredIdentityLoginModule could not be found."
-               + " ConnectionFactory will be unusable!");
+               + " ConnectionFactory will be unusable!", e);
             if( Boolean.TRUE != ignoreMissigingMCF )
             {
                throw new IllegalArgumentException("Managed Connection Factory not found: "

Modified: projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/auth/spi/LdapExtLoginModule.java
===================================================================
--- projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/auth/spi/LdapExtLoginModule.java	2008-10-13 14:25:26 UTC (rev 79394)
+++ projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/auth/spi/LdapExtLoginModule.java	2008-10-13 14:29:36 UTC (rev 79395)
@@ -348,7 +348,7 @@
       catch (Exception e)
       {
          if (trace)
-            log.trace("Failed to parse: " + strRecursion + ", disabling recursion");
+            log.trace("Failed to parse: " + strRecursion + ", disabling recursion", e);
          // its okay for this to be 0 as this just disables recursion
          recursion = 0;
       }
@@ -362,7 +362,7 @@
          catch (NumberFormatException e)
          {
             if (trace)
-               log.trace("Failed to parse: " + timeLimit + ", using searchTimeLimit=" + searchTimeLimit);
+               log.trace("Failed to parse: " + timeLimit + ", using searchTimeLimit=" + searchTimeLimit, e);
          }
       }
       String scope = (String) options.get(SEARCH_SCOPE_OPT);

Modified: projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/auth/spi/LdapLoginModule.java
===================================================================
--- projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/auth/spi/LdapLoginModule.java	2008-10-13 14:25:26 UTC (rev 79394)
+++ projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/auth/spi/LdapLoginModule.java	2008-10-13 14:29:36 UTC (rev 79395)
@@ -402,7 +402,7 @@
                catch (NumberFormatException e)
                {
                   if (trace)
-                     log.trace("Failed to parse: " + timeLimit + ", using searchTimeLimit=" + searchTimeLimit);
+                     log.trace("Failed to parse: " + timeLimit + ", using searchTimeLimit=" + searchTimeLimit, e);
                }
             }
             String scope = (String) options.get(SEARCH_SCOPE_OPT);

Modified: projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/plugins/javaee/EJBAuthorizationHelper.java
===================================================================
--- projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/plugins/javaee/EJBAuthorizationHelper.java	2008-10-13 14:25:26 UTC (rev 79394)
+++ projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/plugins/javaee/EJBAuthorizationHelper.java	2008-10-13 14:29:36 UTC (rev 79395)
@@ -176,7 +176,7 @@
       {
          isAuthorized = false; 
          if(log.isTraceEnabled()) 
-            log.trace(roleName + "::isCallerInRole check failed:"+e.getLocalizedMessage()); 
+            log.trace(roleName + "::isCallerInRole check failed:"+e.getLocalizedMessage(), e); 
          authorizationAudit(AuditLevel.ERROR,ejbResource,e);  
       } 
       return isAuthorized; 

Modified: projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/plugins/javaee/WebAuthorizationHelper.java
===================================================================
--- projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/plugins/javaee/WebAuthorizationHelper.java	2008-10-13 14:25:26 UTC (rev 79394)
+++ projects/security/security-jboss-sx/trunk/jbosssx/src/main/org/jboss/security/plugins/javaee/WebAuthorizationHelper.java	2008-10-13 14:29:36 UTC (rev 79395)
@@ -91,7 +91,7 @@
       {
          isAuthorized = false; 
          if(log.isTraceEnabled()) 
-            log.trace("hasResourcePermission check failed:"+e.getLocalizedMessage()); 
+            log.trace("hasResourcePermission check failed:"+e.getLocalizedMessage(), e); 
          if(this.enableAudit)
             authorizationAudit(AuditLevel.ERROR,webResource,e); 
       }
@@ -143,7 +143,7 @@
       {
          hasTheRole = false; 
          if(log.isTraceEnabled()) 
-            log.trace("hasRole check failed:"+e.getLocalizedMessage()); 
+            log.trace("hasRole check failed:"+e.getLocalizedMessage(), e); 
          if(this.enableAudit)
             authorizationAudit(AuditLevel.ERROR,webResource,e); 
       }
@@ -186,7 +186,7 @@
       {
          hasPerm = false; 
          if(log.isTraceEnabled()) 
-            log.trace("hasRole check failed:"+e.getLocalizedMessage()); 
+            log.trace("hasRole check failed:"+e.getLocalizedMessage(), e); 
          if(this.enableAudit)
             authorizationAudit(AuditLevel.ERROR,webResource,e); 
       }