[jboss-cvs] JBossAS SVN: r79602 - in projects/metadata/trunk/src/main/java/org/jboss/metadata/validation: validator/ejb/jboss and 1 other directory.

[jboss-cvs-commits at lists.jboss.org]

Author: ALRubinger
Date: 2008-10-16 14:45:39 -0400 (Thu, 16 Oct 2008)
New Revision: 79602

Added:
   projects/metadata/trunk/src/main/java/org/jboss/metadata/validation/validator/ejb/jboss/CompleteEjb2xViewValidator.java
Modified:
   projects/metadata/trunk/src/main/java/org/jboss/metadata/validation/chain/ejb/jboss/JBossMetaDataValidatorChain.java
Log:
[JBMETA-130] Validate a Complete EJB2.x View

Modified: projects/metadata/trunk/src/main/java/org/jboss/metadata/validation/chain/ejb/jboss/JBossMetaDataValidatorChain.java
===================================================================
--- projects/metadata/trunk/src/main/java/org/jboss/metadata/validation/chain/ejb/jboss/JBossMetaDataValidatorChain.java	2008-10-16 18:45:22 UTC (rev 79601)
+++ projects/metadata/trunk/src/main/java/org/jboss/metadata/validation/chain/ejb/jboss/JBossMetaDataValidatorChain.java	2008-10-16 18:45:39 UTC (rev 79602)
@@ -32,6 +32,7 @@
 import org.jboss.metadata.validation.chain.ValidatorChain;
 import org.jboss.metadata.validation.chain.ValidatorChainException;
 import org.jboss.metadata.validation.validator.Validator;
+import org.jboss.metadata.validation.validator.ejb.jboss.CompleteEjb2xViewValidator;
 import org.jboss.metadata.validation.validator.ejb.jboss.RemoteBindingsWithNoRemoteBusinessInterfaceValidator;
 
 /**
@@ -174,6 +175,8 @@
 
       // JBMETA-117 No @RemoteBindings if there's no remote business interface
       defaultValidators.add(RemoteBindingsWithNoRemoteBusinessInterfaceValidator.INSTANCE);
+      // JBMETA-130 Complete EJB2.x View
+      defaultValidators.add(CompleteEjb2xViewValidator.INSTANCE);
 
       // Return
       return defaultValidators;

Added: projects/metadata/trunk/src/main/java/org/jboss/metadata/validation/validator/ejb/jboss/CompleteEjb2xViewValidator.java
===================================================================
--- projects/metadata/trunk/src/main/java/org/jboss/metadata/validation/validator/ejb/jboss/CompleteEjb2xViewValidator.java	                        (rev 0)
+++ projects/metadata/trunk/src/main/java/org/jboss/metadata/validation/validator/ejb/jboss/CompleteEjb2xViewValidator.java	2008-10-16 18:45:39 UTC (rev 79602)
@@ -0,0 +1,113 @@
+/*
+ * JBoss, Home of Professional Open Source.
+ * Copyright 2008, Red Hat Middleware LLC, and individual contributors
+ * as indicated by the @author tags. See the copyright.txt file in the
+ * distribution for a full listing of individual contributors.
+  *
+ * This is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as
+ * published by the Free Software Foundation; either version 2.1 of
+ * the License, or (at your option) any later version.
+ *
+ * This software is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this software; if not, write to the Free
+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
+ */
+package org.jboss.metadata.validation.validator.ejb.jboss;
+
+import org.jboss.logging.Logger;
+import org.jboss.metadata.common.spi.ErrorCodes;
+import org.jboss.metadata.ejb.jboss.JBossSessionBeanMetaData;
+import org.jboss.metadata.validation.ValidationException;
+import org.jboss.metadata.validation.validator.ejb.JBossEjb3SessionBeanValidatorBase;
+
+/**
+ * CompleteEjb2xViewValidator
+ * 
+ * Raises a validation exception if there is an incomplete 
+ * EJB2.x View defined by the ejb-jar schema:
+ * 
+ * "Either both the local-home and the local elements 
+ * or both the home and the remote elements must be 
+ * specified for the session bean." 
+ * 
+ * JBMETA-130
+ *
+ * @author <a href="mailto:andrew.rubinger at jboss.org">ALR</a>
+ * @version $Revision: $
+ */
+public class CompleteEjb2xViewValidator extends JBossEjb3SessionBeanValidatorBase
+{
+   // --------------------------------------------------------------------------------||
+   // Class Members ------------------------------------------------------------------||
+   // --------------------------------------------------------------------------------||
+
+   private static final Logger log = Logger.getLogger(CompleteEjb2xViewValidator.class);
+
+   /**
+    * Convenience instance
+    */
+   public static CompleteEjb2xViewValidator INSTANCE = new CompleteEjb2xViewValidator();
+
+   // --------------------------------------------------------------------------------||
+   // Required Implementations -------------------------------------------------------||
+   // --------------------------------------------------------------------------------||
+
+   /**
+    * Validate the specified Session bean's metadata
+    * 
+    * @param smd
+    * @throws ValidationException
+    */
+   protected void validate(JBossSessionBeanMetaData smd) throws ValidationException
+   {
+      // Initialize
+      String errorCode = ErrorCodes.ERROR_CODE_JBMETA130;
+      String errorMessageSuffix = "; Incomplete EJB2.x View [" + errorCode + "]";
+
+      // Get component and home interfaces
+      String remote = smd.getRemote();
+      String home = smd.getHome();
+      String local = smd.getLocal();
+      String localHome = smd.getLocalHome();
+
+      // If remote, need home
+      if ((remote != null && remote.trim().length() > 0) && (home == null || home.trim().length() == 0))
+      {
+         throw new ValidationException("EJB " + smd.getName() + " has defined EJB2.x remote component interface of "
+               + remote + " but has no home; " + errorMessageSuffix);
+      }
+
+      // If home, need remote
+      if ((home != null && home.trim().length() > 0) && (remote == null || remote.trim().length() == 0))
+      {
+         throw new ValidationException("EJB " + smd.getName() + " has defined EJB2.x home interface of " + home
+               + " but has no remote component interface; " + errorMessageSuffix);
+      }
+
+      // If local, need localHome
+      if ((local != null && local.trim().length() > 0) && (localHome == null || localHome.trim().length() == 0))
+      {
+         throw new ValidationException("EJB " + smd.getName() + " has defined EJB2.x local component interface of "
+               + local + " but has no localHome; " + errorMessageSuffix);
+      }
+
+      // If localHome, need local
+      if ((localHome != null && localHome.trim().length() > 0) && (local == null || local.trim().length() == 0))
+      {
+         throw new ValidationException("EJB " + smd.getName() + " has defined EJB2.x local home interface of "
+               + localHome + " but has no local component interface; " + errorMessageSuffix);
+      }
+
+      // Log OK
+      log.trace("Passed validation for " + errorCode);
+
+   }
+
+}