[jboss-cvs] JBossAS SVN: r78084 - in projects/jboss-man/trunk/managed/src: main/java/org/jboss/managed/plugins/factory and 2 other directories.

[jboss-cvs-commits at lists.jboss.org]

Author: adrian at jboss.org
Date: 2008-09-05 09:31:48 -0400 (Fri, 05 Sep 2008)
New Revision: 78084

Modified:
   projects/jboss-man/trunk/managed/src/main/java/org/jboss/managed/api/annotation/ManagementParameter.java
   projects/jboss-man/trunk/managed/src/main/java/org/jboss/managed/plugins/factory/AbstractManagedObjectFactory.java
   projects/jboss-man/trunk/managed/src/main/java/org/jboss/managed/plugins/factory/AbstractManagedObjectPopulator.java
   projects/jboss-man/trunk/managed/src/test/java/org/jboss/test/managed/factory/support/WriteOnlyPropertyObject.java
   projects/jboss-man/trunk/managed/src/test/java/org/jboss/test/managed/factory/test/AbstractManagedObjectFactoryUnitTestCase.java
Log:
Source code tidyup and javadoc fixes

Modified: projects/jboss-man/trunk/managed/src/main/java/org/jboss/managed/api/annotation/ManagementParameter.java
===================================================================
--- projects/jboss-man/trunk/managed/src/main/java/org/jboss/managed/api/annotation/ManagementParameter.java	2008-09-05 13:20:37 UTC (rev 78083)
+++ projects/jboss-man/trunk/managed/src/main/java/org/jboss/managed/api/annotation/ManagementParameter.java	2008-09-05 13:31:48 UTC (rev 78084)
@@ -21,11 +21,8 @@
  */
 package org.jboss.managed.api.annotation;
 
-import java.lang.annotation.ElementType;
-import java.lang.annotation.Inherited;
 import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
-import java.lang.annotation.Target;
 
 import org.jboss.managed.spi.factory.ManagedParameterConstraintsPopulator;
 import org.jboss.managed.spi.factory.ManagedParameterConstraintsPopulatorFactory;

Modified: projects/jboss-man/trunk/managed/src/main/java/org/jboss/managed/plugins/factory/AbstractManagedObjectFactory.java
===================================================================
--- projects/jboss-man/trunk/managed/src/main/java/org/jboss/managed/plugins/factory/AbstractManagedObjectFactory.java	2008-09-05 13:20:37 UTC (rev 78083)
+++ projects/jboss-man/trunk/managed/src/main/java/org/jboss/managed/plugins/factory/AbstractManagedObjectFactory.java	2008-09-05 13:31:48 UTC (rev 78084)
@@ -161,7 +161,6 @@
     * @param defaultManagedObjectPopulator
     * @param builders
     * @param instanceFactories
-    * @param transformers
     */
    public AbstractManagedObjectFactory(MetaTypeFactory metaTypeFactory,
          MetaValueFactory metaValueFactory,
@@ -179,8 +178,9 @@
    }
 
    /**
+    * Get the configuration
     * 
-    * @return
+    * @return the configuration
     */
    public Configuration getConfiguration()
    {

Modified: projects/jboss-man/trunk/managed/src/main/java/org/jboss/managed/plugins/factory/AbstractManagedObjectPopulator.java
===================================================================
--- projects/jboss-man/trunk/managed/src/main/java/org/jboss/managed/plugins/factory/AbstractManagedObjectPopulator.java	2008-09-05 13:20:37 UTC (rev 78083)
+++ projects/jboss-man/trunk/managed/src/main/java/org/jboss/managed/plugins/factory/AbstractManagedObjectPopulator.java	2008-09-05 13:31:48 UTC (rev 78084)
@@ -44,6 +44,7 @@
  * for obtaining BeanInfos for a class, and InstanceClassFactorys for
  * class, name and values from a value to be managed.
  * 
+ * @param <T> the type to populate
  * @author Scott.Stark at jboss.org
  * @version $Revision$
  */
@@ -127,6 +128,7 @@
    /**
     * Get the instance factory for a class
     * 
+    * @param <T> the class to get an instance factory for
     * @param clazz the class
     * @return the InstanceClassFactory
     */

Modified: projects/jboss-man/trunk/managed/src/test/java/org/jboss/test/managed/factory/support/WriteOnlyPropertyObject.java
===================================================================
--- projects/jboss-man/trunk/managed/src/test/java/org/jboss/test/managed/factory/support/WriteOnlyPropertyObject.java	2008-09-05 13:20:37 UTC (rev 78083)
+++ projects/jboss-man/trunk/managed/src/test/java/org/jboss/test/managed/factory/support/WriteOnlyPropertyObject.java	2008-09-05 13:31:48 UTC (rev 78084)
@@ -37,6 +37,7 @@
 public class WriteOnlyPropertyObject implements Serializable
 {
    private static final long serialVersionUID = 1L;
+   @SuppressWarnings("unused")
    private MBeanServer server;
 
    @ManagementProperty(mandatory=true)

Modified: projects/jboss-man/trunk/managed/src/test/java/org/jboss/test/managed/factory/test/AbstractManagedObjectFactoryUnitTestCase.java
===================================================================
--- projects/jboss-man/trunk/managed/src/test/java/org/jboss/test/managed/factory/test/AbstractManagedObjectFactoryUnitTestCase.java	2008-09-05 13:20:37 UTC (rev 78083)
+++ projects/jboss-man/trunk/managed/src/test/java/org/jboss/test/managed/factory/test/AbstractManagedObjectFactoryUnitTestCase.java	2008-09-05 13:31:48 UTC (rev 78084)
@@ -21,13 +21,11 @@
  */
 package org.jboss.test.managed.factory.test;
 
-import java.io.Serializable;
 import java.math.BigDecimal;
 import java.util.ArrayList;
 import java.util.List;
 
 import junit.framework.Test;
-import junit.framework.TestCase;
 import junit.framework.TestSuite;
 
 import org.jboss.managed.api.ManagedObject;
@@ -35,8 +33,6 @@
 import org.jboss.managed.api.factory.ManagedObjectFactory;
 import org.jboss.managed.plugins.factory.AbstractInstanceClassFactory;
 import org.jboss.managed.plugins.factory.AbstractManagedObjectFactory;
-import org.jboss.managed.spi.factory.InstanceClassFactory;
-import org.jboss.metatype.api.values.ArrayValue;
 import org.jboss.metatype.api.values.CollectionValue;
 import org.jboss.metatype.api.values.GenericValue;
 import org.jboss.metatype.api.values.SimpleValueSupport;
@@ -124,6 +120,7 @@
  
    }
 
+   @SuppressWarnings("unchecked")
    public void testGenericValueUpdate()
    {
       AbstractManagedObjectFactory mof = new AbstractManagedObjectFactory();