[jboss-cvs] JBoss Messaging SVN: r5034 - trunk/src/main/org/jboss/messaging/core/server/impl.

jboss-cvs-commits at lists.jboss.org jboss-cvs-commits at lists.jboss.org
Fri Sep 26 17:32:15 EDT 2008


Author: clebert.suconic at jboss.com
Date: 2008-09-26 17:32:15 -0400 (Fri, 26 Sep 2008)
New Revision: 5034

Modified:
   trunk/src/main/org/jboss/messaging/core/server/impl/ServerSessionImpl.java
Log:
Tweaking some comments as the ID is not being assigned on paging

Modified: trunk/src/main/org/jboss/messaging/core/server/impl/ServerSessionImpl.java
===================================================================
--- trunk/src/main/org/jboss/messaging/core/server/impl/ServerSessionImpl.java	2008-09-26 19:58:12 UTC (rev 5033)
+++ trunk/src/main/org/jboss/messaging/core/server/impl/ServerSessionImpl.java	2008-09-26 21:32:15 UTC (rev 5034)
@@ -68,8 +68,11 @@
 import org.jboss.messaging.util.SimpleString;
 
 /*
- * Session implementation @author <a href="mailto:tim.fox at jboss.com">Tim Fox</a> @author <a
- * href="mailto:clebert.suconic at jboss.com">Clebert Suconic</a> @author <a href="mailto:jmesnil at redhat.com">Jeff Mesnil</a>
+ * Session implementation 
+ * 
+ * @author <a href="mailto:tim.fox at jboss.com">Tim Fox</a> 
+ * @author <a href="mailto:clebert.suconic at jboss.com">Clebert Suconic</a> 
+ * @author <a href="mailto:jmesnil at redhat.com">Jeff Mesnil</a>
  */
 
 public class ServerSessionImpl implements ServerSession, FailureListener, NotificationListener
@@ -296,16 +299,6 @@
       {
          if (!pager.page(msg))
          {
-            // We only set the messageID after we are sure the message is not
-            // being paged
-            // Paged messages won't have an ID until they are depaged
-            // This is because after restart we get the max id to use by looking at the journal.
-            // But if some messages are paged, we may get duplicates since id might be lower
-            // than it should be
-
-            // FIXME - the above won't work - we need to set the messsage id before send to be sure that
-            // messages on live and backup get the same ids
-
             List<MessageReference> refs = postOffice.route(msg);
 
             if (msg.getDurableRefCount() != 0)




More information about the jboss-cvs-commits mailing list