[jboss-cvs] JBossAS SVN: r86695 - in branches/Branch_5_x: profileservice/src/main/org/jboss/profileservice/management and 1 other directory.

[jboss-cvs-commits at lists.jboss.org]

Author: scott.stark at jboss.org
Date: 2009-04-02 17:12:18 -0400 (Thu, 02 Apr 2009)
New Revision: 86695

Modified:
   branches/Branch_5_x/messaging/src/main/org/jboss/jms/server/destination/QueueServiceMO.java
   branches/Branch_5_x/messaging/src/main/org/jboss/jms/server/destination/TopicServiceMO.java
   branches/Branch_5_x/profileservice/src/main/org/jboss/profileservice/management/ManagementViewImpl.java
Log:
JBAS-6689, only dipatch updates to the runtime component if the property ActivationPolicy is IMMEDIDATE.

Modified: branches/Branch_5_x/messaging/src/main/org/jboss/jms/server/destination/QueueServiceMO.java
===================================================================
--- branches/Branch_5_x/messaging/src/main/org/jboss/jms/server/destination/QueueServiceMO.java	2009-04-02 20:47:22 UTC (rev 86694)
+++ branches/Branch_5_x/messaging/src/main/org/jboss/jms/server/destination/QueueServiceMO.java	2009-04-02 21:12:18 UTC (rev 86695)
@@ -29,6 +29,7 @@
 import org.jboss.jms.server.messagecounter.MessageCounter;
 import org.jboss.jms.server.messagecounter.MessageStatistics;
 import org.jboss.managed.api.ManagedOperation.Impact;
+import org.jboss.managed.api.annotation.ActivationPolicy;
 import org.jboss.managed.api.annotation.ManagementComponent;
 import org.jboss.managed.api.annotation.ManagementObject;
 import org.jboss.managed.api.annotation.ManagementObjectID;
@@ -125,25 +126,29 @@
    
    @ManagementProperty(use={ViewUse.CONFIGURATION},
          description="The in-memory message limit, can only be set when queue is stopped",
-         includeInTemplate=true)
+         includeInTemplate=true,
+         activationPolicy=ActivationPolicy.DEPLOYMENT_RESTART)
    public int getFullSize() { return 0; }
    public void setFullSize(int arg0) { }
    
    @ManagementProperty(use={ViewUse.CONFIGURATION},
          description="The paging size, can only be set when queue is stopped",
-         includeInTemplate=true)
+         includeInTemplate=true,
+         activationPolicy=ActivationPolicy.DEPLOYMENT_RESTART)
    public int getPageSize() { return 0; }
    public void setPageSize(int arg0) { }
    
    @ManagementProperty(use={ViewUse.CONFIGURATION},
          description="The write-cache size, can only be set when queue is stopped",
-         includeInTemplate=true)
+         includeInTemplate=true,
+         activationPolicy=ActivationPolicy.DEPLOYMENT_RESTART)
    public int getDownCacheSize() { return 0; }
    public void setDownCacheSize(int arg0) { }
 
    @ManagementProperty(use={ViewUse.CONFIGURATION},
          description="Is this a clustered destination?",
-         includeInTemplate=true, readOnly=true)
+         includeInTemplate=true, readOnly=true,
+         activationPolicy=ActivationPolicy.DEPLOYMENT_RESTART)
    public boolean isClustered() { return false; }
    public void setClustered(boolean arg0) { }
 

Modified: branches/Branch_5_x/messaging/src/main/org/jboss/jms/server/destination/TopicServiceMO.java
===================================================================
--- branches/Branch_5_x/messaging/src/main/org/jboss/jms/server/destination/TopicServiceMO.java	2009-04-02 20:47:22 UTC (rev 86694)
+++ branches/Branch_5_x/messaging/src/main/org/jboss/jms/server/destination/TopicServiceMO.java	2009-04-02 21:12:18 UTC (rev 86695)
@@ -27,6 +27,7 @@
 import javax.management.ObjectName;
 
 import org.jboss.managed.api.ManagedOperation.Impact;
+import org.jboss.managed.api.annotation.ActivationPolicy;
 import org.jboss.managed.api.annotation.ManagementComponent;
 import org.jboss.managed.api.annotation.ManagementObject;
 import org.jboss.managed.api.annotation.ManagementObjectID;
@@ -113,25 +114,29 @@
    
    @ManagementProperty(use={ViewUse.CONFIGURATION},
          description="The in-memory message limit, can only be set when topic is stopped",
-         includeInTemplate=true)
+         includeInTemplate=true,
+         activationPolicy=ActivationPolicy.DEPLOYMENT_RESTART)
    public int getFullSize() { return 0; }
    public void setFullSize(int arg0) { }
    
    @ManagementProperty(use={ViewUse.CONFIGURATION},
          description="The paging size, can only be set when topic is stopped",
-         includeInTemplate=true)
+         includeInTemplate=true,
+         activationPolicy=ActivationPolicy.DEPLOYMENT_RESTART)
    public int getPageSize() { return 0; }
    public void setPageSize(int arg0) { }
    
    @ManagementProperty(use={ViewUse.CONFIGURATION},
          description="The write-cache size, can only be set when topic is stopped",
-         includeInTemplate=true)
+         includeInTemplate=true,
+         activationPolicy=ActivationPolicy.DEPLOYMENT_RESTART)
    public int getDownCacheSize() { return 0; }
    public void setDownCacheSize(int arg0) { }
 
    @ManagementProperty(use={ViewUse.CONFIGURATION},
          description="Is this a clustered destination?",
-         includeInTemplate=true, readOnly=true)
+         includeInTemplate=true, readOnly=true,
+         activationPolicy=ActivationPolicy.DEPLOYMENT_RESTART)
    public boolean isClustered() { return false; }
    public void setClustered(boolean arg0) { }
 

Modified: branches/Branch_5_x/profileservice/src/main/org/jboss/profileservice/management/ManagementViewImpl.java
===================================================================
--- branches/Branch_5_x/profileservice/src/main/org/jboss/profileservice/management/ManagementViewImpl.java	2009-04-02 20:47:22 UTC (rev 86694)
+++ branches/Branch_5_x/profileservice/src/main/org/jboss/profileservice/management/ManagementViewImpl.java	2009-04-02 21:12:18 UTC (rev 86695)
@@ -62,6 +62,7 @@
 import org.jboss.managed.api.MutableManagedComponent;
 import org.jboss.managed.api.MutableManagedObject;
 import org.jboss.managed.api.RunState;
+import org.jboss.managed.api.annotation.ActivationPolicy;
 import org.jboss.managed.api.annotation.ManagementComponent;
 import org.jboss.managed.api.annotation.ManagementObject;
 import org.jboss.managed.api.annotation.ManagementObjectID;
@@ -1132,10 +1133,11 @@
          
          // Dispatch any runtime component property values
          Object componentName = getComponentName(ctxProp);
-         if (componentName != null)
+         ActivationPolicy policy = ctxProp.getActivationPolicy();
+         if (componentName != null && policy.equals(ActivationPolicy.IMMEDIATE))
             dispatcher.set(componentName, ctxProp.getName(), metaValue);
       }
-      
+
       // Persist the changed values
       this.store.updateDeployment(compDeployment, serverComp);
       // Force reload